Comments (5)
Thanks for brining this up @bernardjoseph!
I think your solution is fine, but it could be in a better place.
The call to god-mode-lookup-command
could be done in either:
- The outer
let*
form, or - The
god-key-string-after-consuming-key
function (I think).
That would make it slightly cleaner.
If the tests are passing with your change in verbatim though, I'm happy to merge that in and refactor it later.
That being said, you shouldn't be using C-S-N
(or C-S-n
) in the spirit of modal editing 😄
Instead, you should call set-mark-command
and next-line
i.e. SPC n
in God mode.
Note that SPC n
doesn't use any modifier keys.
from god-mode.
Actually, I'm curious about the behavior with your change and the Caps Lock key turned on.
Is the behavior correct in that case?
from god-mode.
I must confess I do not know what the correct behavior is. Without God mode, pressing Ctrl-anything with Caps Lock on seems to ignore Caps Lock. With God mode enabled, with Caps Lock on, all alphanumeric keys are shifted. For me the behavior is ok and I am more wondering about the behavior with God mode turned off. What do you think?
from god-mode.
Sorry, after playing a bit more I am now convinced that the Caps Lock behavior is not good.
from god-mode.
A checked the behavior in View mode, which has some capital letter bindings. With Caps Lock on, all capital letter bindings are in effect. That is a strange behavior for me, I was not aware of until now. Caps Lock is not really recognized by Emacs in those cases.
from god-mode.
Related Issues (20)
- The function "my-god-mode-update-modeline" does not work reliably HOT 4
- Fix mode line suggested in README resulting in unreadable mode line HOT 3
- God mode does not work in Transient UI HOT 8
- god-mode-all doesn't work in shell-mode HOT 4
- Keybinds recommendation
- Use Eldev HOT 1
- Add customisation to disable sticky `god-literal-key` HOT 10
- Idea: One-shot god-mode HOT 3
- [Idea] Disabling god mode after certain functions/key-presses HOT 5
- Have a discussion page for this project? HOT 1
- Extending god-mode system wide outside of Emacs HOT 13
- feature request: make describe-key work with god-mode HOT 10
- Make ESC just enter god-mode HOT 3
- Conflict with lispy-mode HOT 3
- Customize option to disable head icon showing on mode-line HOT 7
- god-mode doesn't work in *scratch* buffer
- god-mode does not work with "un-initialized" `projectile-mode-map` HOT 17
- binding for <C-tab> doesn't work in god-mode HOT 10
- Org-mode header navigation. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from god-mode.