[Idea] Disabling god mode after certain functions/key-presses

[trev-dev]

[Idea] Disabling god mode after certain functions/key-presses

[trev-dev]

Knowing how to do it without it being built into god-mode is just as good in my opinion. I was thinking that someone like yourself might have some idea of how to do it.

I prefer to explicitly call a function that disables god mode and performs some related key-command. However, I think that advice tip is huge. I don't yet understand what advice actually does, but I'm going to dig into it.

Thanks @darth10

[trev-dev]

That advice tip is super cool. I was able to create a silly "insert-ahead" keybind for forward/backward motions that let me move 1 character in the correct direction and exit god-local-mode. This makes spamming forward-word/symbol or backward-word/symbol more useful because sometimes where I want to be is just after some word/symbol separator.

It looks like the :around option for advice-add is probably the way to go for these M-RET functions, as I would be able to capture the called function and execute it inside the body of my advice function 😎

[darth10]

No worries!

I can also suggest a few improvements to your ELisp snippet there:

(defun disable-god-mode (&rest _)
  (god-local-mode -1))

(advice-add 'org-meta-return :after #'disable-god-mode
            (function 'god/insert-after-org-meta-return))

(advice-add 'org-insert-todo-heading :after #'disable-god-mode
            (function 'god/insert-after-org-new-heading))

[darth10]

That's an interesting idea, but this sounds more like user-level customisation to me.

There are a couple ways to achieve this:

1. Use god-execute-with-current-bindings, which enables God mode for a single command, executes the command for a key binding, and disables God mode. If God mode is already enabled, then god-execute-with-current-bindings simply executes a command and disables God mode.
2. Use advice functions. For example:

   (defun disable-god-mode (&rest _)
     (god-local-mode -1))
   
   (advice-add 'end-of-line :after #'disable-god-mode)
   (advice-add 'back-to-indentation :after #'disable-god-mode)
   (advice-add 'org-insert-todo-heading :after #'disable-god-mode)
   ;; ...

   A potential problem that I see with this approach is that common functions like end-of-line may be called by other packages, which would disable God mode without the user intending to do so.

Does that help @trev-dev?

[trev-dev]

Meh, rather than try to hook into "Meta Return" I took the simpler route with advice as well.

(advice-add 'org-meta-return :after
            #'(lambda (&rest args) (god-local-mode -1))
            '(( name . "god/insert-after-org-meta-return")))

(advice-add 'org-insert-todo-heading :after
            #'(lambda (&rest args) (god-local-mode -1))
            '(( name . "god/insert-after-org-new-heading")))

This works great. Thanks again for the tip @darth10