View Code? Open in Web Editor
NEW
Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
Home Page: https://new.expensify.com
License: MIT License
JavaScript 0.49%
Starlark 0.01%
Java 0.21%
Ruby 0.10%
Objective-C 0.03%
HTML 0.04%
Shell 0.21%
CSS 0.06%
Swift 0.08%
Objective-C++ 0.09%
TypeScript 98.62%
Kotlin 0.05%
app's People
app's Issues
This is a little weird because it uses up half the screen. I suggest opening the keyboard closed.
Let's make sure our code represents the absolute best practice from day one.
let's not show the spinner after sending a message because it highlights how long it takes for the message to actually be delivered, whereas it would be nicer if it were presented as if instantaneous and only show that it wasn't delivered in the event there is some kind of error
I guess <Beforeunload>
isn't working for mobile.
it would be nice if the relative timestamps updated automatically but some kind of timer that fires every minute and updates them all.
Since we can just press enter to send a message, let's remove the send button.
Current:
Proposed:
this might be a stretch, but I think what would put this demo over the top as if we support image attachments out of the gate.
This would make it an amazing demo, but I don't think anyone expects it out of the gate.
Try using {clientID}
instead. But this really isn't used yet, so not as urgent to get this working.
Rather than use a green dot to indicate a new message, let's just make the report row a bold weight:
Ideally we should show the logged-in user's avatar in the bottom left.
Current:
Proposed:
cc @tgolen
Send a message, e.g. *hello world*
See <bold>hello world</bold>
flash for a second
Perhaps take a page from WhatsApp and use a little clock icon if we:
Write a message while offline (and thus don't attempt to deliver it)
Write a message that has an error when we attempt to deliver it
Assets:
@quinthar
expensidux
ree
reft
reply
rebind
restore
Stormtrooper
R2
proact
retain
recall
rejoin
react-ion
bks
databind
ksb
nvp
Pick a room to open to on start, rather than opening to nothing. Just pick the first in the LHN
When you click into a new "channel"/report it does not change the text next to Expensify Chat:
We need to add our brand fonts to the app:
GT America Exp Regular
GT America Exp Medium
GT America Exp Bold
I wonder if this is because we are reversing the list of reports when they are viewed?
the mobile app opens to a room scrolled to the top, whereas it should open to the room scrolled to the bottom.
inline links seem to render in a strange fashion showing the bra HTML surrounding an actual hyperlinked link. This might only be on mobile web, currently Android does not support style it all.
We used bootstrap tooltips before, but that's not going to work in RN
Show if we are currently connected to Pusher in order to correctly set the expectations of the user for what functionality will work.
The Android app does not scroll when adding new comments, meaning you cannot see the new, you just added until you manually scroll down.