working together

[expressjs]

working together

[dougwilson]

Feel free to email me (email is listed in GibHub profile) and we can always set up a call or whatever. I see you mentioned Skipper; just realize that this parser is meant to be a buffering all-at-once parser, so it would of course never do multipart (and it doesn't right now).

or pulling out shared dependencies

Whatever this module is actually in the process of being pulled apart as we speak by me, so that seems fine as well.

[dougwilson]

From looking at the source of skipper, it looks like it would continue to be it's own thing, but probably use the express stuff's parsing for the non-multipart. You could even change it right now, even while still on express 3 (this module doesn't even require express or connect and works on node 0.8+).

[dougwilson]

This module does this: https://github.com/balderdashy/skipper/blob/master/index.js#L65 and you can too just using type-is module :)

This: https://github.com/balderdashy/skipper/blob/master/index.js#L67 I am actually working into express and such, so I suppose express will have that soon.

[dougwilson]

https://github.com/balderdashy/skipper/blob/master/index.js#L19-L23 is the whole purpose of this module ;)

[dougwilson]

https://github.com/balderdashy/skipper/blob/master/index.js#L100-L102 you would just use the type-is module and then you don't have to care is there is a req.is or not.

[mikermcneil]

https://github.com/balderdashy/skipper/blob/master/index.js#L19-L23 is the whole purpose of this module ;)

awesome :)

Feel free to email me (email is listed in GibHub profile) and we can always set up a call or whatever

cool thanks! yeah mainly I just want to make sure I'm not messing up any of your plans

https://github.com/balderdashy/skipper/blob/master/index.js#L100-L102 you would just use the type-is module and then you don't have to care is there is a req.is or not.

perfect

[dougwilson]

yeah mainly I just want to make sure I'm not messing up any of your plans

well, you can't do anything that would "mess up plans", haha, more like just potential duplication of effort or whatever

[jonathanong]

@mikermcneil i would wait to use https://github.com/expressjs/request-body or at least its dependencies, which this library will eventually use. @dougwilson is doing some great stuff.

[mikermcneil]

@jonathanong Thanks for the heads up- it'll be a little while before I get a chance to spend a night on skipper to implement these changes anyways, so I'll check in before that and see where we stand?

Mike's phone

On Jun 17, 2014, at 2:58, Jonathan Ong [email protected] wrote:

@mikermcneil i would wait to use https://github.com/expressjs/request-body or at least its dependencies. @dougwilson is doing some great stuff.

—
Reply to this email directly or view it on GitHub.

[dougwilson]

so I'll check in before that and see where we stand?

Yep, that's fine :) P.S. I never ended up hearing from you, but feel free to contact me if you need anything :)

[mikermcneil]

@dougwilson my bad I've been a complete cornflake the last couple of weeks (I'm balderdashy on Skype)

[dougwilson]

Hi @mikermcneil I haven't heard much here for a while. I'm going to just close this issue for now, though we can still chat through it, of course.

[mikermcneil]

@dougwilson absolutely-- my bad for leaving it open