fcharron/prj-rev-bwfs-dasmoto

prj-rev-bwfs-dasmoto's Issues

classes vs id's

https://github.com/fcharron/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L7-L36

It seems you assigned classes to your brush, frames and paint elements, however since these are only used once and thus individual, unique elements they should be assigned id's rather than classes. Classes are more suitable for when you want to group multiple elements and give them all the same styling. Here is a great resource on classes vs. ids:

https://css-tricks.com/the-difference-between-id-and-class/__

HTML nicely organized/formatted

https://github.com/fcharron/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L1-L37

Your HTML is very nicely indented/formatted and easy to follow along -- make sure to keep it up!

nice job commenting main parts of code

https://github.com/fcharron/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L2-L37

You did a good job making sure to comment the main parts of your HTML, which is often something learners forget to do.

SUMMARY

Summary Grade: Satisfactory

Good job! Your files are organized nicely, and you did a great job of following the client specification -- this is an important skill to have as a developer and you seem to understand that. Moreover, you generally followed good code practice, so make sure to keep that up!

I have made some comments in your code to take note of. First off, good job making sure to comment your HTML. You should also make sure to comment the main parts of your CSS in future projects. This will greatly help your development flow, especially as your projects get larger and more complex. Here is a quick refresher on commenting in CSS:

Next off, rather than giving your brushes, frames and paint elements classes, you should instead assign them ID's since they are unique, individual elements. You usually use class when you want to give a group of elements the same styling. Here is a great resource that explains the difference between class and ID:

https://css-tricks.com/the-difference-between-id-and-class/

Good job overall! As a further challenge, try using css to design your webpage even further! You did a great job in following the client specification, but for your own practice you should see how creative you can get by taking the design/styling of your site to the next level (for example, you can try experimenting with background colors on your other divs).

CSS is clean and succinct

https://github.com/fcharron/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/resources/css/style.css#L1-L30

Your CSS is short and succinct -- good job! One area of improvement is to make sure to comment your main stylings so that when you come back to your code you remember exactly why you decided to style an element a particular way. Here is a quick refresher on commenting in CSS: