prj-rev-bwfs-dasmoto's Issues
SUMMARY
Summary Grade: Satisfactory
Good job! Your files are organized nicely, and you did a great job of following the client specification -- this is an important skill to have as a developer and you seem to understand that. Moreover, you generally followed good code practice, so make sure to keep that up!
I have made some comments in your code to take note of. First off, good job making sure to comment your HTML. You should also make sure to comment the main parts of your CSS in future projects. This will greatly help your development flow, especially as your projects get larger and more complex. Here is a quick refresher on commenting in CSS:
Next off, rather than giving your brushes, frames and paint elements classes, you should instead assign them ID's since they are unique, individual elements. You usually use class when you want to give a group of elements the same styling. Here is a great resource that explains the difference between class and ID:
https://css-tricks.com/the-difference-between-id-and-class/
Good job overall! As a further challenge, try using css to design your webpage even further! You did a great job in following the client specification, but for your own practice you should see how creative you can get by taking the design/styling of your site to the next level (for example, you can try experimenting with background colors on your other divs).
HTML nicely organized/formatted
https://github.com/fcharron/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L1-L37
Your HTML is very nicely indented/formatted and easy to follow along -- make sure to keep it up!
classes vs id's
https://github.com/fcharron/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L7-L36
It seems you assigned classes to your brush, frames and paint elements, however since these are only used once and thus individual, unique elements they should be assigned id's rather than classes. Classes are more suitable for when you want to group multiple elements and give them all the same styling. Here is a great resource on classes vs. ids:
https://css-tricks.com/the-difference-between-id-and-class/__
CSS is clean and succinct
https://github.com/fcharron/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/resources/css/style.css#L1-L30
Your CSS is short and succinct -- good job! One area of improvement is to make sure to comment your main stylings so that when you come back to your code you remember exactly why you decided to style an element a particular way. Here is a quick refresher on commenting in CSS:
nice job commenting main parts of code
https://github.com/fcharron/prj-rev-bwfs-dasmoto/blob/master/Dasmoto/index.html#L2-L37
You did a good job making sure to comment the main parts of your HTML, which is often something learners forget to do.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.