firebearstudio/shapeshift-magento2

Accept cryptocurrency payments without fee on Magento 2 by ShapeShift exchange API

shapeshift-magento2's Issues

Add a new tag (v1.0.13)

Can you add a new tag (v1.0.13), please? So https://packagist.org/packages/firebear/shapeshift detects it and I can get the latest changes via composer update?

Order confirmation message

When the ShapeShift extension is installed and disabled, the order confirmation page shows the message:
"Your order was placed with ShapeShift.io payment. " despite the use of another payment mechanism. I did not test the result when the extension is enabled and another payment mechanism is used.

Terms & Conditions checkbox doesn't show up

If terms and conditions are enabled and active there should be a checkbox to accept them on the checkout page. If I add a 'purchase order' payment option, the checkbox shows up as expected. It doesn't show up for the shapeshift payment method even when this is the only enabled payment method.

It should look like this:

I'm experiencing this issue with the default theme and Magento v2.2.3

If you want to reproduce this, add something under stores > terms & conditions and then for the settings in stores > sales > checkout enable onepage checkout and terms & conditions.

cannot complete order

After clicking 'place order' I am not redirected to Shape Shift to make the payment. Instead, it gives a spinning progress indicator for a few seconds, then a blank error:

The log doesn't show anything to tell me what's wrong either:

[2018-05-06 02:46:01] main.INFO: API START [] []
[2018-05-06 02:46:02] main.INFO: SELECT CURRENCY NAME: Litecoin [] []
[2018-05-06 02:46:03] main.INFO: DEPOSIT ADDRESS: LfEM5mhtRYVsemV16G3xaM55hH5WZg2uUW [] []
[2018-05-06 02:46:03] main.INFO: RETURN ADDRESS:  [] []
[2018-05-06 02:46:03] main.INFO: AMOUNT: 0.0557289345 [] []
[2018-05-06 02:46:03] main.INFO: API XCHECK DEFAULT [] []
[2018-05-06 02:46:03] main.INFO: API XCHECK AMOUNT [] []
[2018-05-06 02:46:03] main.INFO: sendFixedAmount() 1 [] []
[2018-05-06 02:46:03] main.INFO: sendFixedAmount() 2 [] []
[2018-05-06 02:46:03] main.INFO: sendFixedAmount() 3 [] []
[2018-05-06 02:46:21] main.INFO: sendFixedAmount() DATA:  {"success":{"orderId":"7d4ac5ce-e595-4080-ba83-8d262cce6c46","pair":"eth_ltc","withdrawal":"LfEM5mhtRYVsemV16G3xaM55hH5WZg2uUW","withdrawalAmount":"0.0557289345","deposit":"0x8ea24bd7de96e74cba59ab7b4d52432f3a893463","depositAmount":"0.0123313","expiration":1525575381542,"quotedRate":"4.58012726","maxLimit":6.01255456,"returnAddress":"","apiPubKey":"2106861f10516dabde38412e6568a11890605ccea018377daf8fa4378eeed12f33a7b73bda9ed23250fbbedf939e5101be80218746ac97edca6ab96516d92f73","minerFee":"0.00075"}} []

Order goes through fine if I choose a different payment method.
Magento v2.2.3

Shape Shift Minimum and Maximum

A few suggestions for the Shape Shift extension:

-- Add a min and max field to the configuration with the Shape Shift limits as the default and also the smallest and largest values that can be entered. Then, a checkbox to prevent the checkout option from being shown when the checkout total is outside the limits to prevent customer frustration in completing all the fields only to get the error from Shape Shift.

-- Add a description of what Shape Shift is on the payment type selection page, so people checking out will know it's for Crypto currency payment

-- Allow vendors to determine what payment options customers can use to make payments. Some vendors may not want to support all types of currency, despite receiving all payments with the selected type. Similar to selecting what countries they want to support.

-- The "return address" might need "(your receive address for any needed refunds)" or something similar added to the description so people don't put private keys in there.

Thanks for developing this extension.

input/output currency must be different, so don't allow that combination

I want to receive LTC
If the user tries to send me LTC, this plugin will get an error after the 'place order' is clicked:

It would be better if LTC or whatever coin the admin has selected to receive is just not shown in the dropdown.

Could checkout when ETH is set as currency

Steps to reproduce:

• Go to configuration (Stores=>Configuration=>Payment methods=>Shape Shift Payment)
• Set following values
  ** Enable => Yes
  ** What currency do you want to receive? => ETH
  ** Deposit Address => your address
  ** Allow currency => select all
• Go to frontend and try to checkout using Shape Shift

Actual result:
Call to http://host/shapeshift/api/index fails with 503
Debug message: "CoinMarketCap API error: id not found"

Expected result:
User friendly error message should be displayed on checkout page in case of error.

Notes:
Issue comes from different currency name used for\from api requests:
Call to https://shapeshift.io/getcoins gives ETH = ether. While https://api.coinmarketcap.com/v1/ticker/{currency_id} expect it to be "ethereum"
So wrong enpoint is used
https://api.coinmarketcap.com/v1/ticker/ether/
intead of
https://api.coinmarketcap.com/v1/ticker/ethereum

No client-side validation that a currency is selected

On the checkout page, if I select the Shapeshift payment method but do not select a valid entry from "What currency do you want to pay?" select field, I do not get a message about being required to select a currency, but a message "There was an error creating your order, please try again in a few minutes. (0x03331202) Request: https://shapeshift.io/sendamount" instead.