Comments (8)
Hello,
thanks for pointing that out.
require 'tzinfo'
p begin ::TZInfo::Timezone.get('+11') rescue nil; end # ==> nil
p begin ::TZInfo::Timezone.get('+1100') rescue nil; end # ==> nil
p begin ::TZInfo::Timezone.get('UTC/+11') rescue nil; end # ==> nil
p begin ::TZInfo::Timezone.get('Etc/GMT-11') rescue nil; end # ==> #<TZInfo::DataTimezone: Etc/GMT-11>
require 'fugit'
p Fugit::VERSION # ==> '1.1.5'
p Fugit::Cron.parse('29 9 16 * * +11') # ==> nil
p Fugit::Cron.parse('29 9 16 * * +1100') # ==> #<Fugit::Cron:...>
p Fugit::Cron.parse('29 9 16 * * UTC/+11') # ==> nil
p Fugit::Cron.parse('29 9 16 * * Etc/GMT-11') # ==> nil
I can't find UTC/+11
in the list of tz database time zones and TZInfo doesn't know about it. If you have a need for it, please tell me. (By the way are you on Windows?)
That leaves me Etc/GMT-11
to enable.
from fugit.
Hello @Tolsto,
please tell me if the changes I made fix the issue for you.
If you really need UTC/+11
, please tell me why you need it.
Thanks in advance.
from fugit.
Thanks for the fast reply @jmettraux
You are right, UTC/+11
doesn't exist. Sorry for the bad example. I'm not on Windows but Linux.
Your new code works for me. However, only for negative offsets. Something like Etc/GMT+5
still doesn't work.
from fugit.
Hello @Tolsto,
my bad. The above commit should solve that.
Thanks for the rapid feedback you gave me.
from fugit.
Thank you, I can confirm that it works now. Do you already know when you'll publish the next release that will include this?
from fugit.
You're welcome.
I'm thinking about releasing tomorrow, along with an et-orbi accommodation for the same Etc/GMT+11
and friends. I hope that matches your schedule.
from fugit.
👍
from fugit.
Fugit 1.1.6 is out.
Thanks again!
from fugit.
Related Issues (20)
- multi-headed Fugit::Cron instance
- Specify which sidekiq-cron version is available HOT 2
- Specify which sidekiq-cron version is available HOT 5
- Regression with parsing in 1.9+ HOT 5
- Behaviour change between 1.4.4 and 1.4.5 HOT 8
- be liberal with extra commas
- Implement the & cron modifier HOT 1
- Issue parsing 0/1 compared to * or */1 HOT 4
- Introduce OpenBSD cron ~ notation HOT 1
- Fugit.parse incorrectly parsing am/pm HOT 5
- time computation with monthly duration like "P-2M" is incorrect
- Un-representable inputs should raise an error HOT 4
- Incorrect next_time for cron that is supposed to run every 3 hours for America/New_York HOT 3
- If given 6 fields, the first one is interpreted as seconds HOT 2
- Version 1.10.0 not compatible with ruby 2.2.6 HOT 8
- Examples in Readme don't work: undefined method 'next' for Fugit::Cron HOT 1
- cron #previous_time loop breaker issue HOT 6
- cron #previous_time loop breaker issue HOT 3
- #next_time breaks on DST end HOT 4
- Cron inconsistent behaviour with union vs intersection HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fugit.