Borders and padding

[fossfreedom]

Borders and padding

[fossfreedom]

I've added a GtkFrame for the playbar.

With regards to the songs list - are you using Rhythmbox 3.2 or Rhythmbox 3.1? If the former you'll see the styling has changed to have flatter less bordered windows.

With regards to the sidebar - we may or may not have a sidebar in the future.

As to the playbuttons - feel free to have a play around with the padding values - the file is alttoolbar.ui in the ui sub-folder. Let me know what you think works best.

[satya164]

Well try.

On Fri, Apr 3, 2015, 3:43 AM David Mohammed [email protected]
wrote:

I've added a GtkFrame for the playbar.

With regards to the songs list - are you using Rhythmbox 3.2 or Rhythmbox
3.1? If the former you'll see the styling has changed to have flatter less
bordered windows.

With regards to the sidebar - we may or may not have a sidebar in the
future.

As to the playbuttons - feel free to have a play around with the padding
values - the file is alttoolbar.ui in the ui sub-folder. Let me know what
you think works best.

—
Reply to this email directly or view it on GitHub
#12 (comment)
.

[me4oslav]

I toyed a bit and added some padding.
Input, anyone?

Ignore the not working repeat and shuffle buttons, that is not related to my tweaks.

[satya164]

Cool!

[me4oslav]

@fossfreedom How do I submit a merge request? Or do you just want me to tell you what I've done so you can recreate it?

[fossfreedom]

just added you as a collaborator - you should now be able to check-in changes

[me4oslav]

I will push in the morning.

[me4oslav]

This commit fixes the issue:
77de760

Here is how it looks:

Closing the issue now.

[fossfreedom]

That looks much nicer. Thanks for that.

The volume-control button is now smaller though. Intentional?

[satya164]

Instead of adding a frame around the bar, which adds a border on all sides, we just need border at the top.

[me4oslav]

I did not touch volume. O.o

[fossfreedom]

@satya164 - better now?

[satya164]

@fossfreedom screenshot?

[me4oslav]

@satya164 -