fossfreedom/alternative-toolbar

Modern, minimal and music-focused interface for Rhythmbox

alternative-toolbar's Issues

search is broken between sources

one of the recent commits has managed to break the search function for different sources as well as hiding the secondary bar in sound-cloud.

Need to track down why.

[DESIGN] "Configure Plugins" screen redesign.

Before I start on the actual design rationale I must say that I am totally unsure if this screen can be changed via a plugin and even if that's possible, if this plugin is the correct one to file a bug report to.
Now, having said that - I have noticed that the "Configure plugins" has really outdated design that looks bad and also breaks the Gnome HIG. I did a quick redesign of it that looks better and obeys the Gnome HIG:

Rationale:
If possible it should become a screen with a headerbar (perhaps even modal dialog if possible) and close button on the right of it.
You have the plugins names followed by plugins description below them on the left and on/off switches for enabling/disabling a plugin on the right.
Below the plugins pane you have inline toolbar with a button <preferences | about> on the right and if doable button on the right. The symbolics for the button on the right are standard ones - "preferences-system-symbolic" and "dialog-information-symbolic".

P.S.
I don't know how much of this is doable (for example the CSD and the remove button don't exists as functions in the current implementation), so I know that if implementation is doable it might not be possible to match the wireframe perfectly. I was also considering requesting "Search", but decided that this is bit over the top. This design is a common thing in Gnome as is in System Settings for example:

So, can this be implemented and if so, how much of it?

Volume Control sizing is not the same as other playcontrols

Now using xpad, ypad values of 5 - xalign, yalign values of 1 for the images in the button controls to pad the buttons.

from #17 the above creates deprecated warnings.

From glade cannot set these same values for a volume-control. So how do we pad the volume-control correctly now i.e. shouldnt really use xpad, ypad, xalign, yalign ?

papercut - display cover in a GtkPopover

as per the design spec, look at invoking a GtkPopOver containing the cover image when hovering over the cover in the playcontrol bar.

Note - the plugin is - and should remain - Gtk+3.10 compatible - thus any implementation must use the alt_rb3.py function to decide if the 3.12 or later is being used - fallback being as current to be a tooltip popup.

no button to setting with this toolbar

i'm using rhythmbox on debian, i don't have menu in the music player and as soon i enable your plugin, is just change i can not access anymore to the settings and plugin manager to change setting on this plugin and anything else, there is a shortcut to do that? o how can i fix this?

thanks

[DESIGN] Borders.

This is more of a papercut bug.

Here is a screenshot of the current rhythmbox with this plugin enabled:

Now here are the issues:

• Right from where the tracklist starts X axis wise there is a some second headerbar border below the standard one;
• Tracklist should get borderless (without top, bottom and left borders) and get expanded to the bottom end of the headerbar, top end of the playbar and right end of the sidebar;
• Sidebar needs border on the right - #21

Window border & improved screenshots

First off thanks for the plugin, makes RB look much better under gnome. Considering the plugin has gonna over some significant clean-up I figured it might be good to improve the screenshots on the README to reflect that. When taking them (with the gnome-screenshot /w drop shadow) I noticed the windows lack a border. Many of the gnome applications have a light grey border to make the window pop. Is this intentional? Below are some of the screenshots.

Vanilla:

alternative-toolbar:

Notice the white border at the bottom:

Notice that this still has the border:

Which makes it pop over another window:

The reason the background window is not grayed out when a window is over it is because I individually overlayed them in GIMP, can't get the clean dropshadow with multiple windows. I'll fix that later plus I wanted to highlight the border issue.

Album version: http://imgur.com/a/IPNPg

I figured I would bring this up before doing a pull request with the new images, that is of course if you want them.

black stripe(s) separating the toolbar from the rest of the app

I'm wondering if sth can be done about that black stripe, separating the toolbar from the rest of the app? I've noticed that it's not there with the old (not gnome-shell) plugin and that it is there without the plugin. I hope you get what I mean.

Sidebar rebrushing.

Featuring:

• better organisation;
• new symbolic icons;
• ability to hide main categories (that's what the triangles do);

What do you think?

Deprecated warnings due to using xpad, ypad etc

The following is seen in a terminal on start-up:

(rhythmbox:18682): GLib-GObject-WARNING **: The property GtkWidget:margin-left is deprecated and shouldn't be used anymore. It will be removed in a future version.

(rhythmbox:18682): GLib-GObject-WARNING **: The property GtkWidget:margin-right is deprecated and shouldn't be used anymore. It will be removed in a future version.
/home/dad/.local/share/rhythmbox/plugins/alternative-toolbar/alttoolbar_type.py:158: Warning: The property GtkMisc:xpad is deprecated and shouldn't be used anymore. It will be removed in a future version.
  builder.add_from_file(ui)
/home/dad/.local/share/rhythmbox/plugins/alternative-toolbar/alttoolbar_type.py:158: Warning: The property GtkMisc:ypad is deprecated and shouldn't be used anymore. It will be removed in a future version.
  builder.add_from_file(ui)

(rhythmbox:18682): Gtk-WARNING **: Failed to set property GtkButtonBox.layout-style to : Could not parse enum: `'
/home/dad/.local/share/rhythmbox/plugins/alternative-toolbar/alttoolbar_controller.py:158: Warning: The property GtkButton:xalign is deprecated and shouldn't be used anymore. It will be removed in a future version.
  builder.add_from_file(ui)

(rhythmbox:18682): Gtk-WARNING **: Failed to set property GtkButtonBox.layout-style to : Could not parse enum: `'

(rhythmbox:18682): Gtk-WARNING **: Failed to set property GtkButtonBox.layout-style to : Could not parse enum: `'

(rhythmbox:18682): Gtk-WARNING **: Failed to set property GtkButtonBox.layout-style to : Could not parse enum: `'

Under GTK 3.14 no real impact ... may change in a future version.

Borders and padding

Some points,

• The play buttons in the bottom bar need more horizontal padding
• The bottom bar needs a border at the top
• The songs list needs to have no borders and should have no margin
• The sidebar will need a right border after that

papercut - tracks with no artist are not centered

Another inline label issue.

Inline labels are actually two labels - one song title, the second song artist.

In Sound Cloud - there are often no artists. Just the song title is filled - this leaves the whole displayed label slightly odd - the label is not centered (top label - no bottom label).

What is needed is a revision - when one or the other labels are not filled, the other label needs to be removed so that the space is taken by just one label ... and then would be automatically centered.

[DESIGN] Enhanced sidebar padding on the left.

Screenshot:

It can use some padding on the left. The elements can start a few pixels more to the right.

Provide an uninstall.sh?

Not that I want to uninstall this plugin (it works pretty well :) but I thought it would be reassuring for users to have an uninstall script (for the conf schemas etc)?

[FEATURE REQUEST] Graphic setup.

Wireframe:

The wireframe from above is pretty self explaining and sand the updates it should not be that hard to implement.
My idea about the updates is that it will only offer an update when there is version bump on github in the master branch. Of course this installer will only be for people that have grabbed the plugin from github and updates will also be handled by fetching from Githhub.
Updating is not a be all end all feature that must be implemented in the setup at all cost and can be delayed for later on or not be implemented at all. It would be to have it, but it is not really mandatory.
This design can be used for all your other plugins too.

moving the secondary toolbar into the CSD

The find option to toggle the visibility of the secondary toolbar might be a starting point here.

This pointer could mean that can actually move the secondary toolbar into the CSD.

Not sure though when & how the "secondary toolbar" that is now in the CSD should be activated i.e. flip back and forth between the main toolbar and the secondary toolbar.

Anyway - create this issue as a thinking point.

(rhythmbox:1726): libpeas-WARNING **: Could not find plugin 'rb' for plugin 'alternative-toolbar'

Hi!
I get an error when trying to enable alternative-toolbar from the plugins dialog. What am I missing?
(rhythmbox:1726): libpeas-WARNING **: Could not find plugin 'rb' for plugin 'alternative-toolbar'
I got the code from the master branch (commit 2dd420d) and installed it on Evolve OS beta 1.1 (https://github.com/evolve-os).
Thanks!

XFCE 4.12 CSD + Menubar

XFCE4.12 supports CSD.... so how do we also hide the menu-bar?

Podcast Category

I'm not entirely sure on Podcasts being an online source. I get the logic behind it, but it just doesn't fit in with the others. Radio, Last.fm and Libre.fm (along with the others which are available via plugins) are all online streaming services. Podcasts on the other hand passively download from RSS whenever Rhythmbox is open so the content can be (and has to be) listened to locally.

[DESIGN] About Dialog redesign.

Wireframe:

I did this in Glade:

But it is quite imperfect.

The pause button is not 16px, which makes it blurrry.

For some reason the pause symbolic icon size is different size than 16px.
Here is a screenshot of it in the UI zoomed at 800%:

As you can see it looks blurry and that is visible at normal size too.
And here is a screenshot from the play button from the same box:

The icon itself is perfecty aligned to grid:

Some translations for the CSD toolbar

Hello @fossfreedom @me4oslav I have two translations for the CSDs

Lang = es / es_ES es_MX and many other
1.- Songs = Canciones
2.- Categories = Categorías
3.- Use = Usar
4.- Compact progress slider = Deslizador de progreso compacto
5.- Enhanced sidebar = Barra lateral mejorada
6.- Modern = Moderno
7- Use compact controls = Usar controles compactos
8.- Album/genre/year for playing song = album/genero/año para la canción en reproducción
9.- Playback controls = controles de reproducciónn
10.- Volume control = Control de volumen
11.- Tooltips on playback controls = Consejos en los controles de reproducción
12.- Restart = Reinicar
13.- Resume or pause playback = Continuar o pausar la reproducción
14.- Play the next track = Reproducir la siguiente pista
15.- Play the previous track = Reproducir la pista anterior
-- I did not understod the "Inline Song/Artist Label option so I have not translation to it in Spanish

I hope this could be usefull for you, If I find more to translate I will report it to you 😄

use the new rb_header recommendation to display same coverart when entry changes

as per

GNOME/rhythmbox@5e1511e

lets look to using something similar to hold the display of coverart in compact view

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8141053-use-the-new-rb_header-recommendation-to-display-same-coverart-when-entry-changes?utm_campaign=plugin&utm_content=tracker%2F10046800&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F10046800&utm_medium=issues&utm_source=github).

Phones appears with improper naming in the new sidebar.

When I plugged my Nexus 5 in the new sidebar it appears in "Other sources" category and it first says "Media player", which after a while gets changed to "Nexus 5".
Ideally it should appear in "Local collection" as "Nexus 5".

Screenshots:

Search box papercuts.

There are two issues with the search box.
A) It should be toggable with Ctrl+F;
B) When it is shown it should look like this:

Just a box without text, which is selected by default, so after the users has clicked search / pressed ctrl+f he will be able to start typing in it without extra mouse clicks.
Both are Gnome HIG things.

The CSD progress bar slider width is hardcoded.

Which as you can imagine creates issue when the window is resized.


The first screenie is RB with minimum window width. I think the window size width wise is OK, but the progress bar should be longer. The second is with wider window and as you can see, the issue is very prominent.
We need it to be responsive and go longer when the user makes the window wider.

Magnatune and fmradio should appear in "online sources" in the new sidebar.

And currently they appear in "other sources".

[DESIGN] Plugin settings redesign.

Wireframe:

How an active button looks like:

It also needs more padding than it currently has right now.
Should I try to Glade the wireframe?

do not hide the song & category buttons

currently we hide the song and category buttons for sources that don't have "browse" capability

from fossfreedom/coverart-browser#359 (comment) this is apparently scary to people (!)

Thus - instead of removing those buttons - where a source doesnt have browser capability, these buttons should be actually disabled.

Once coverart issue 359 is implemented, the category button will be enabled for play-queue and music-library - these will enable the two new left hand-side header toggle options "list view and coverart view"

can't drag & drop songs to media player in enhanced sidebar

first of all thanks for all your work on this plugin. finally found a media player I like :)

However I've noticed some missing functionality when using the plugin with 'enhanced sidebar' enabled.

Without 'enhanced sidebar' enabled, you can add songs to your attached portable media player, by dragging and dropping songs from your library on to the media player icon on the sidebar.

With enhanced sidebar, dragging and dropping is simply not possible.

If i'm not mistaken, drag & drop is the only possible way to add songs to portable players in rhythmbox, so some users may need to keep the nicer sidebar disabled because of this.

plugins window icons need a tootips

from a G+ comment from @HEXcube, plugin icon toolbar need tooltips.

If we are a bit clever (dangerous I know) - we could reuse the rhythmbox strings so that we don't need to add more translation strings to launchpad.

Thus tooltips will use

• "_Preferences"
  • "_About"
  • "_Help"

Need to remember to remove _ chars as well as any strings such as (_x) from translated strings

Tooltips.

Gnome HIG is very much pro tooltips, so I guess we should add tooltips to the buttons on the header and playbar. However, the tooltips should also be meaningful, so the user will not get a toolip saying "Previous" when (s)he hovers over the previous song button.
So, here are some tooltips that I came up with:
Play - "Resume the playback"
Pause - "Pause the playback"
Stop - "Stock the playback"
Previous - "Play the previous song from the tracklist"
Next - "Play the next song from the tracklist"
Shuffle - "Play the songs in random order"
Repeat - "Repeat the current song"
Search - "Search for music in the selected view"
Now let us discuss if this wording is fine and if it not - what changes are needed.

Is there a point of the volume button?

So, I've been thinking - I am pretty sure that most desktop environments out there has a volume control. This might actually be true for all DEs. And I am 100% sure that all DEs that support CSD have a colume control on their panel. This makes me wonder - is the volume button on the headerbar really needed?
The way I see it:
A) Creates clutter, because it is an extra UI element;
B) Dublicates the system volume control, which creates confusion in the users;
Hence I am suggesting removing it or making it optional, but disabled out of the box.
I've attached a screenie of the issue.

Radio panel improvements.

Here is the list of issues in it:

• The "Songs" toggle should become "Stations";
• The repeat and shuffle don't make sense for the radio panel, so they should be disabled in it;
• The "Previous" and "Next" buttons currently do nothing, so they should either switch to previous and next stations or get disabled.

Some of the sidebar symbolic icons don't make sense.

I know this is not a headerbar thing, but like I said - the brushing I am planning goes beyond the scope of the CSD.
Anyways, look at the this screenshot:

First - "Play queue" uses documents icon. It should use custom symbolic icon, because there is no queue one in the icon themes.
Second - "Import errors" misses an icon and it should use - "dialog-error-symbolic.svg" icon.
Third - "libre.fm" service icon is very similar to wifi logo, so it should use "network-wireless-symbolic.svg"
Fourth - "Radio" needs a custom symbolic icon, because icon sets don't come with radio symbolic icons. Using a server symbolic icon is really confusing. I can do one.
Fifth - playlists should not look a search symbolic icon, but custom icons for the three default ypes of playlists. I will do them. a playlists icon. Also - for user created list a playlist icon should be used. Alas for some odd reasons iconsets don't ship with such icon, so I will have to do a custom one.

CSD setup is different than what is showed in the README

I have enabled CSD, but my rhythmbox appearance does not conform to what is show on the README. Instead it looks more like the compact toolbar.

I am using Gnome 3.16.x.

The repeat and shuffle buttons do not work?

This might not be an issue and be because I am stupid and am still a rookie in RB-ville.

Alternative Toolbar plugin causes application volume level to lower on each startup if not maxed

If this plugin is activated, and if Rhythmbox's volume was not left at 100%, on each subsequent start of the application, the volume will be lower.

This can be seen by opening gnome-control-center's volume settings, going to the Applications tab, setting rhythmbox's volume slider slightly below 100%, then restarting rhythmbox a few times.

This is with GNOME 3.14, RB 3.1 and plugin version da08d53

Add repeat once capability

coming out of #4 and other discussions, consider adding a repeat once function.

The method discussed in #4 to add an always on down arrow just doesnt work for me so not going to implement an always visible method.

Maybe consider looking at displaying a much narrower version of the drop-down when hovering over the repeat button - something like windows media player.

Papercut - Sidebar needs border on the right.

Because if it doesn't have one and when search is toggled, the area where the search bar and the sidebar meet looks funny.

Use GTKScale when using inline song/artist label

from #4 - consider using the standard GTKScale instead of the custom scrobble bar when using inline-label option

consider a popover showing albums for the artist

hover of the album art shows the large version of the coverart.

maybe better to consider making this a popover for GTK3.12+ users - likewise if clicking on the artist / song label then display a popover showing pictures of albums together with their track listing.

[DESIGN] "small_toolbar" branch design issues.

I just installed the small_toolbar branch and noticed the following issues:

• The joined buttons should go 5px to the top;
• The should start on the same point on the X axis that where the rest of the sidebar elements start;
  However before fixing the second issue, this needs fixing: #40

Papercut - the appmenu button needs framing.

'Cause it looks awkward with all the other buttons, which are framed.

papercut - large inline labels causes scrobble bar resizing issues

When using Sound Cloud I noticed that many tracks have very large titles.

Using the combined progress bar - no issues - it copes nicely.

However, the inline label format - the progress bar can shrink to quite small sizes.

A couple of changes required.

1. progress bar needs to have a minimum size to which it cannot shrink beyond
2. labels need to have ellipsizing turned on so that if too large for the space made available, the label should automatically be in ellipsis format.

add a pause-stop capability

from discussion in #4 consider adding a pause - stop function instead of the current pause button function.

like #15 - should be implemented in a consistent method with repeat once for whatever method is chosen.

Alternate Toolbar needs a rename

Though Alternate Toolbar started as a simple plugin to change the toolbar a bit, it has now grown much beyond it's initial goal. In addition to the toolbar, the plugin can now change the sidebar, plugins config screen, position of progress bar, enable CSD, compact style and more. The plugin has completely overhauled the visual style of Rhythmbox. Since the plugin gave Rhythmbox a total cosmetic redesign, I feel it needs a rename.

[DESIGN] Enhanced sidebar should remember subcategories expand-collapse states.

Test case:

• Enable the last.fm plugin and login with your credentials in it. Make sure you leave the last.fm category collapsed;
• Restart the player;
• The last.fm sucategory will start expanded, despite that you've left it collapsed;

Papercut - album art popover should go away when mouse doesn't hover the album art in the play bar.

Because it can be really irky to click somewhere in order to deactivate something that activates with hovering over an element.

New sidebar doesn't start with the expanded and collapsed statuses of the sources from the player last run.

The player always starts with local collection expanded and online sources and playlists collapsed. It should remember which categories are left expanded and which collapsed on startup;