Add repeat once capability

[fossfreedom]

Add repeat once capability

[me4oslav]

The Gnome HIG approved solution is like this:

Clicking on the arrow will open a menu with the repeat options.
This would mean that the repeat and shuffle buttons will have to be separated.

[me4oslav]

Any decision about this one? Because the sooner the remaining issues with alternative-toolbar are gone, the better.

[fossfreedom]

Repeat-once is not a core rhythmbox function - it needs code to be developed to support this function.

There is another plugin called repeat once. Myself (or someone else) will need to have a look at what is the best way to incorporate this plugin so that we dont start having to have a proliferation of additional add-ins.

Thus, the arrow issue is just the minor part of this.

[HEXcube]

What about clicking the repeat all songs button twice to make it repeat one song? I've seen it on many music players, especially those on mobile devices. This should give you an idea, though the mockup is terrible :-)
Button in default mode (Repeat All Songs):

When clicked again it should change into this:

@fossfreedom Or can you make the Repeat One Song plugin display icon on toolbar, like it did on Rhythmbox 2.xx?

[fossfreedom]

@HEXcube

thanks for your thoughts.

This would be ok if the repeat button was a standard button - it currently is a toggle button like the shuffle button - so being depressed show the repeat is in action - toggle off, repeat is not in action.

I dont like the idea of a second button.

My current thought is centering around using a Gtk Popover.

1. clicking repeat button will display the popover showing two icons side-by-side - one with the repeat all button (depressed), the other repeat once (not depressed)
2. moving the mouse within the popover allows you to choose the repeat mode you want. Clicking the mode in the popover changes the icon in the button
3. moving the mouse out of the repeat button boundary hides the popover. likewise moving the mouse outside of the popover boundary hides the popover.
4. if the repeat button is depressed and you move the mouse within the repeat button boundaries - the popover reappears allowing you to choose the repeat mode
5. toggling off the repeat button hides the popover

The above would work for GTK3.12 and above users (Ubuntu Utopic and vivid) but not for Ubuntu Trusty users. So not sure what to-do for these users.

[me4oslav]

I will have launch and read the discussion.

[me4oslav]

The popover solution is not a bad idea. I like it.
But like David himself outlined, it will not work for the Ubuntu LTS, which could prove itself problematic.
It is either that or the Gnome HIG solution. The latter will work on any GTK 3x, but its issues is that it wastes a bit of X space.

[fossfreedom]

ok - have now got some working code for this issue.

Only tested on ubuntu vivid at the moment.

Still to do:

1. test and fix any issues on Ubuntu trusty
2. sort out the tooltips on the popover (they are missing).

Note - the current tooltip for the repeat button is actually wrong ("Repeat the current track") since it repeats all tracks in the view/playlist etc. I've reused this tooltip for the repeat-one-song capability. The new default string is "Repeat all tracks" - this unfortunately requires an additional translation string.

[me4oslav]

Will test, outline issues and if possible fix papercuts too.

[me4oslav]

Ok, here are issues:

• The repeat and shuffle button now must get two separate buttons, because of the popover; It is repeat button specific, not repeat and shuffle specific;
• add tooltips in popover mode;
• the bugs you outlined;

One question - will there be a preference for that? 'Cause at least it this case, I don't see a point - if the user does not what repeat once capability (s)he will just ignore it in the popover.

[fossfreedom]

Don't really follow the request for a preference. I think most people will instantly recognise "repeat one" functionality - its common on most media players ... just not in rhythmbox until now!

Anyway - have split the buttons - 3px space between them ... and 3px for the volume control if that is also visible.

Tooltips in popover if the tooltip option is switched on in preferences.

BTW - 18 languages and locales is quite amazing. Very pleased personally that so many translators have invested their time in this project :)

[me4oslav]

Shall test and comment in the morning.

[me4oslav]

Shouldn't the spacing be 5px?
Apart from that - it seems fine.
The preferences request was about not adding a preference to do disable the ability to switch between repeat modes. The way I see it is that if the user does not want repeat once capability (s)he won't use it.

[fossfreedom]

thanks for the 5px change.

The repeat functionality is not an oft invoked capability nor "in your face" like a tooltip. Thus not convinced a preference option here will be necessary. If there was a clamour for this then will re-evaluate.

[me4oslav]

Excellent, so we both agree that a preference is not needed. :)
I will try to find some time for coverart design work too.
Meanwhile - there is are two issues standing for this plugin:

• papercut about the radio panel;
• graphic setup utility;

[HEXcube]

Tested the plugin from repeat-one-song branch (now merged to master) on Ubuntu 14.04LTS "Trusty" and I'm happy to say that it works fine.

• Unpressed (Default mode)
  
• Pressed (Popover shows Repeat options)
  
• Repeat One Song mode
  

Repeat One Song was one of the features I missed the most when Rhythmbox moved from v2.9x to v3.x series. Though the plugin was still usable, it could no longer add repeat-one-song icon to Rhythmbox 3.x's static toolbar. @fossfreedom n' @me4oslav Thank u guys, for bringing this much needed feature back, with a better implementation! :-)

[fossfreedom]

@HEXcube

excellent. Many thanks for testing this.

I'll be uploading the new version into my PPA in the next few days - I want to include most of the updated translations that are being worked on by the launchpad translation community.

[me4oslav]

BTW, David - if you wanna supply the community with bleeding edge builds it may be worth doing a daily PPA.
But I am not sure it is worth it.

[fossfreedom]

that's an interesting idea - I've meaning to investigate launchpad's autobuild facility. Might do this for coverart-browser.

[me4oslav]

I think @satya164 can teach you.

[me4oslav]

Or maybe @paolorotolo.