Comments (11)
correct - this goes beyond this particular plugin.
Three ways to address this. Obviously, upstream via a pull request to rhythmbox itself. The maintainer prefers coders and patches. I've noted that enhancement requests rarely get actioned - someone has to do the work before Jonathan Matthew (the maintainer) would consider pulling in the patch.
The second is distro specific - make those changes in the source itself and maintain the patches for every new rhythmbox version...
The third way is more speculative but possibly via another plugin - each of those options in the picture is in a RB.DisplayPageTree
Every item is ultimately a RB.DisplayPage (i.e. playlists etc are derived from RB.DisplayPage)
There is a property on the page called icon - its a Gio.Icon - so it should be possible (at least in theory) to assign your own Gio.Icon to it.
As I said - the third way is more speculative - not sure what event that could be used to tap into, to detect when a new RB.DisplayPage is created and then override the icon.
from alternative-toolbar.
Right, way one seems like the best option. I can do the icons, you can do the implementation work and send a pull request. But there is a but. Is the maintainer interested in merging cosmetics patches like this one?
I didn't get the second way.
Third way seems like last resort method, so I guess it should be avoided if possible.
I will do the icons right now.
from alternative-toolbar.
C programming isnt generally my forte - its been a while. Happy to give it a try though.
As to whether the maintainer of rhythmbox is interested - I've posted this bug report to sound him out.
from alternative-toolbar.
Commended there. I am now working on this:
#4
Would you prefer pen and paper wireframes or digital ones?
from alternative-toolbar.
web-links to the "-symbolic.svg" files themselves.
from alternative-toolbar.
No, no, I know abut the icons. :)
I was asking around the wireframes for issue #4 - do you want them digital or would you prefer them as sketches?
from alternative-toolbar.
sketches would be fine.
from alternative-toolbar.
As a person that dies a little on the inside when he has to do digital wireframes and/or mockups I can't thank you enough for not making me do such. :)
from alternative-toolbar.
Here is the tarball with the needed icons:
https://dl.dropboxusercontent.com/u/2656555/rb-symbolic-icons.tar.gz
When implementing them please put them in the same scalable subfolders as they are in the tarball and don't change the names. The folders structures and naming are XDG Gnome standards approved, so icon themes can theme them.
Rationale:
"Play queue" - "mimetypes/audio-x-queue-symbolic.svg" (in the tarball).
"Import errors" - "dialog-error-symbolic.svg" (no need for a custom icon).
"libre.fm" - "apps/librefm.svg" (in the tarball)
"Radio" - "devices/audio-radio.svg" (in the tarball).
"User created playlist" - "mimetypes/audio-x-playlist-symbolic.svg" (in the tarball).
"Top rated playlist" - "user-bookmarks-symbolic.svg" (no need for a custom icon).
"Recently added playlist" - "mimetypes/audio-x-playlist-recently-added-symbolic.svg" (in the tarball).
"Recently played playlist" - "mimetypes/audio-x-playlist-recently-played-symbolic.svg" (in the tarball).
Everything else is fine.
GTK doesn't need the ".svg" suffix when you're going to implemented those.
from alternative-toolbar.
Do we need this issue still open?
from alternative-toolbar.
guess not.
from alternative-toolbar.
Related Issues (20)
- The volume gauge often lag to change when using +/- HOT 1
- Empty windows toolbar after wrongly deactivating all options in plugins preference HOT 5
- Missing animation when clicking the search button in the headerbar
- Feature request: Remove this button HOT 1
- Use the headerbar for controls
- Global menu with controls at the bottom HOT 1
- Bind Ctrl+F to showing and focusing the search toolbar when it is not already shown HOT 2
- Closing the search bar with Escape keyboard shortcut confuses the toggled state HOT 1
- Columns cannot be moved HOT 1
- Prepare release 0.20.0
- No release file for 21.04 via apt reps HOT 1
- dialog asking for restart appears on close of rhythmbox HOT 1
- If a music file doesn't have an album name, album art won't be displayed. HOT 2
- Alternative toolbar plugin is not working on arch linux HOT 2
- Inaccuracy in README - wrong package name for Fedora HOT 2
- Missing file in tar.xz archive HOT 1
- Compilation issues for Fedora HOT 7
- Enhanced plugin dialog not working HOT 1
- Alternative Toolbar Removes Status Bar & Disables It In View Menu HOT 5
- Program freezes in terminal error HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from alternative-toolbar.