Giter Site home page Giter Site logo

Comments (20)

richardfrost avatar richardfrost commented on August 28, 2024

I'm sorry its not working for you @bdc0der. I haven't seen that issue before, but I'm happy to help get to the bottom of it.

Could you share an export of your config so I can test it using the same settings? If not, could you still export a copy of your config, reset the extension back to the defaults, enable audio muting again, and then test? Its definitely possible some settings could be interfering with it.

Another thing that might be good to test is see if another extension might be interfering with it. Just to confirm, you reported that muting is working on other sites such as YouTube, right? One thing you can try is setting up another browser profile (without other extensions) and see if it works there.

Which country are you watching Netflix from?

Let me know if you have any questions or have any feedback.

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

Wow, thanks for the fast response. Yes, I can confirm it's working for other websites, I'm watching from the U.S. in Oregon. Here is the opera backup: https://file.io/Nd3bJwiS3zcU
The backup for chrome windows 10 I might be able to get shared tomorrow, I'm not sure, I'll respond again when I get the chance
I will try creating another chrome profile without extensions. Thanks for the help

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

You're welcome @bdc0der. Thanks for confirming those details, and sharing the config.

I just imported the config into a new Chrome profile. It looks like that config had filtering disabled on www.netflix.com (Domains tab), but once I removed it I tested it on a couple videos and they all worked for me as expected. That tells me it shouldn't be an issue with your settings in the extension, so its likely something else. I'd still like to see if you could test it with a new profile, just to see if it might be another extension that could be preventing it from working correctly.

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

Here is the link for the version I use on chrome on windows 10: https://file.io/l542t59oTax8

(I wouldn't be surprised if a problem with the extension was a result of other extensions on OperaGX, I have like 10, but it would seem strange on chrome as the only other thing I use is uBlock origin and I have it whitelisted for Netflix)

Would it be enough to simply whitelist an extension, or would I have to manually disable it altogether?

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

Ok, I tried reinstalling on a different brand-new browser with the default extension settings, and the audio muting still didn't work. Are there any browser-based features or something else you know of that might interfere with it? It could very well be an extension, but seeing that it still doesn't work even with no other extensions installed on a brand-new browser can make me think it's 1 of 2 things:

  1. It's tough luck and just an isolated case with something that can't be fixed
  2. It's a problem with a specific browser function.

Thanks for sticking with me and continuing to help me

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

Thanks for testing on a new profile @bdc0der, that shows its likely not an issue with a conflict between another extension.

On that new Chrome profile, while on Netflix with a video playing and captions enabled, do you see this?

image

You should either see the extension's badge be purple, which means its actively watching for captions, but hasn't found them yet, or green (as shown in the screenshot), which means it has found the captions. So, when the Netflix page loads it should be purple, but does it ever change to green while playing the video?

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

One thing I do notice (this has always been the case) is the sentence with the bad word will be in bold font instead of the regular font like the rest. Yes, when I first load Netflix it's purple and when it then finds the word it turns green.
I have 2 screenshots that elaborate on this

Screen Shot 2022-12-02 at 4 43 22 PM

Screen Shot 2022-12-02 at 4 45 22 PM

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

Interesting find @bdc0der. Could you pause the video when that happens, right-click on the caption text and choose "Inspect", and then send me a screenshot of the HTML element it shows there?

I'm assuming you've tested it on multiple videos, right? If not, could you try on an episode of Stranger Things and see if that works?

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

I have not tried it on multiple videos, I have mainly been testing it on a single video. I'll try it on a few others tomorrow.
Screenshots:
Screen Shot 2022-12-02 at 6 53 28 PM
Screen Shot 2022-12-02 at 6 54 33 PM

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

Could I have you search in that "Inspector" tab (CTRL+F) for a phrase shown in the captions, like this:

image

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

Screen Shot 2022-12-03 at 6 53 34 AM

Are there other parts of the HTML editor I might wanna have open for you to look at besides just the raw code in the inspector area?

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

Not that I can think of right now, but that did help @bdc0der. Could you share which video and approximate timestamp you have been testing with? I want to see if I can replicate it here, and I have a couple ideas that I'd like to try.

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

Jim Gaffigan: Obsessed - 32:04

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

What version of Firefox were those screenshots taken with? When I go to ~38:00 (about where I found those captions), I'm seeing this:

image

Not sure why they are different, but one difference I see is on my, the captions have a font-size:34px, and yours has font-size:1px. Not sure if that makes a difference, but it is a differences. Muting for me is also working fine on both Firefox (107.0.1) and Chrome with the settings you shared (once I enable the Netflix domain again, as mentioned above). I haven't seen anywhere on Netflix to make changes to the captions display, but maybe I just missed it? Do you know if you changed anything that could have changed it for your account?

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

@richardfrost
Version 107.0.1 (64-bit)
The firefox version I installed is brand-new. I didn't go to the settings and enable or disable anything new.
Firefox and APF are both on the newest-installed default versions. (Only thing I changed for APF was enabling "Mute audio on supported video sites ")

One thing I did find though that allows me to change caption settings is by going to Netflix Account, clicking the profile I want, and scrolling down until I found "Subtitle Appearance"

These are my caption preferences:
Screen Shot 2022-12-03 at 1 28 04 PM

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

Thanks for sending those subtitle settings over @bdc0der. I haven't been able to replicate it to reflect what you are seeing. I've tried changing the settings, and also reset to default. No matter what I have selected, it is still muting for me correctly.

Could you try resetting those Netflix subtitle options back to default and see if its still not working for you? Also, do you have any other Add-ons/extensions running aside from APF? Do you have anything that might be changing/applying styles on the page?

image

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

It works! Resetting the captions to their default settings did the trick! This means it wasn't an extension causing it, and it wasn't a specific OS or browser, it was just the settings in Netflix. Thank you so much for your patience and help with this persistent issue.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

That's great @bdc0der! Let me know how it goes with testing on other browsers now.

from advancedprofanityfilter.

bdc0der avatar bdc0der commented on August 28, 2024

It works perfectly fine on the rest of the browsers I have tried, Firefox, Chrome, Opera GX, etc. Thank you for your help. Since the issue is resolved, I'll be closing the issue. Have a good day and good luck with future plans for APF.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on August 28, 2024

You're welcome @bdc0der. Thanks for helping to get to the bottom of the issue. Take care!

from advancedprofanityfilter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.