Giter Site home page Giter Site logo

Comments (9)

Seby68 avatar Seby68 commented on July 24, 2024

Hi Richard, how can you, check out this extension, as far as we are. Evaluate, which could be very useful, because we could filter two subtitle languages, at the same time. For example, I have included English, Italian, Polish and Spanish in your extension. Hello and thanks in advance.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on July 24, 2024

@Seby68 I took a look at it, and I think I should be able to support it with a little bit of work. I'll let you know how it goes in the next few days.

from advancedprofanityfilter.

Seby68 avatar Seby68 commented on July 24, 2024

Thank you very much . I hope you succeed, there may be, quite useful. Good work.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on July 24, 2024

@Seby68, here is a preview version that should support what you are looking for. If this works alright for you I'll go ahead and release a version with these new code changes.

extension-mv3-chrome-netflix-dual-subs.zip

Note: Learn more about using an unpacked extension here.

I wasn't able to find a good way to keep a single config working in both cases where "NflxMultiSubs 2021" was installed and not installed. As such, I won't be making a change to the official Netflix config included in the extension. So, if someone wanted to use Netflix normally (without "NflxMultiSubs 2021", or if they only care about muting for the primary language subtitle) they won't have to do anything.

If you want to enable muting for both the primary and secondary subtitles (available in NflxMultiSubs 2021) then you'll need to add this to your Custom Sites config, which will take precedence over the included Netflix config:

{
  "www.netflix.com": [
    {
      "mode": "watcher",
      "subtitleSelector": "div.player-timedtext-text-container span span &&& div.nflxmultisubs-subtitle-container svg.nflxmultisubs-subtitle-svg text tspan"
    }
  ]
}

Note: If you have other "Custom Sites config" already, feel free to send it to me and I can help you combine it with this new one.

Let me know how it works for you, and if it is acceptable I'll get an official release ready.

from advancedprofanityfilter.

Seby68 avatar Seby68 commented on July 24, 2024

[Thanks, I'll let you know by testing it well. Have a nice weekend.

from advancedprofanityfilter.

Seby68 avatar Seby68 commented on July 24, 2024

Sorry Richard, but I didn't install the zip file, I'll let you know.

from advancedprofanityfilter.

Seby68 avatar Seby68 commented on July 24, 2024

Richard, I tested one language 4 times and the other 2 times and it worked fine. Streaming over audio also stops fine. By my choice I lengthened the downtime, by 1200, because sometimes the second audio arrives late on the subtitles. Thanks again .

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on July 24, 2024

Thanks for testing that @Seby68. I'll go ahead and get those changes added into the next official version so you can start using it then. I will try to get it submitted in the next day or so, and then it will just depend on how long the various store's review process takes before you'll be able to download the update. I'll update here once its available.

from advancedprofanityfilter.

richardfrost avatar richardfrost commented on July 24, 2024

This has been included in version 3.1.0. Feel free to comment here if you have any feedback for this update.

@Seby68 you'll need to keep that custom config if you want to use the "dual subtitles" on Netflix as it isn't being included with the official supported sites.

from advancedprofanityfilter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.