Compiler and path error

[fsharp]

Compiler and path error

[migueldeicaza]

Sounds like shoudlWrap is wrong in the first place

On Mon, Aug 29, 2011 at 4:01 PM, mithunder <
[email protected]>wrote:

I have encountered a path error on Windows 7, and found a possible
solution. When trying to compile, the compiler gives an error over the
following paths:

-r:C:\Program Files (x86)\FSharp-2.0.0.0\bin\FSharp.Core.dll
-r:"C:\Program Files (x86)\FSharp-2.0.0.0\bin\FSharp.Core.dll"

The first line seems to be the problem, not wrapping the line. I solved the
issue by replacing line 299 in src/Services/Common.fs:

let wrapf = if shouldWrap then wrapFile else id

with

let wrapf = if shouldWrap then wrapFile else wrapFile

and getting

-r:"C:\Program Files (x86)\FSharp-2.0.0.0\bin\FSharp.Core.dll"
-r:"C:\Program Files (x86)\FSharp-2.0.0.0\bin\FSharp.Core.dll"

thus ensuring it is always wrapped. I have tested the solution on Debian
and Windows 7, and it seems to work fine. If the fix is fine, I would
suggest it is committed to master.

Reply to this email directly or view it on GitHub:
#21

[mithunder]

Yeah, it seems plausible. I don't know under which circumstances it would be useful to have an unquoted path instead of a quoted path, but having only quoted paths worked fine on Debian and Windows 7.

[tpetricek]

The wrapping of paths is not done in the 'generateCompilerOptions' function, which is used in CompilerService.fs (to generate command line options for the compiler) and in LanguageService.fs (to call the service provided by F# compiler to do the IntelliSense).

In the first case, it would be probably correct to wrap the file name. In the second case, I'm not 100% sure. I think the IntelliSense may fail to load assemblies if it gets wrapped path. I suggest you modify the patch to only wrap the path when the function is called from CompilerService.fs.

[mithunder]

I don't know how the IntelliSense handles wrapped and unwrapped paths, so you might be right. In any case, I implemented your suggested modifications (wrapping in Compiler, not wrapping in Language), and the compiling as well as the IntelliSense seems to work fine when I test it on Debian and Windows 7. Would you like the diffs per email, or here in the thread?

[mithunder]

I've set up a pull request containing the changes.

[tpetricek]

The pull request looks good - thanks for submitting it! I merged it with the master branch.