fulcrologic/fulcro-template

A sample project that could be used as a starting point for a Fulcro 3 project.

fulcro-template's Issues

Error in Readme instructions for server startup

The readme suggests starting the server with the command:

## Start the backend process:
clojure -A:dev -Dtrace -Dguardrails.enabled=true

Which fails with:

➜  fulcro-template git:(master) ✗ clojure -A:dev -Dtrace -Dguardrails.enabled=true
Execution error (FileNotFoundException) at java.io.FileInputStream/open0 (FileInputStream.java:-2).
-Dtrace (No such file or directory)

Full report at:
/var/folders/1h/ky9z5q955p397p2p6qz_z1cc0000gp/T/clojure-1941805994198538015.edn

Using the command:

➜  fulcro-template git:(master) ✗ clojure -A:dev -J-Dtrace -J-Dguardrails.enabled=true
Clojure 1.10.1
user=>

Displays the clojure REPL without errors.

Typo? 'ghostwheel' vs. 'guardrails'

Should these 3 mentions of ghostwheel actually be guardrails?

1. in https://github.com/fulcrologic/fulcro-template/blob/master/package.json#L15
   "server": "clojure -A:dev -J-Dtrace -J-Dghostwheel.enabled=true",

2. in https://github.com/fulcrologic/fulcro-template/blob/master/README.adoc
   clj -A:dev -J-Dtrace -J-Dghostwheel.enabled=true

3. in the actual guardrails repo..
   in https://github.com/fulcrologic/guardrails/blob/d53c48eeca875a336c71cc6084b81e920191d9d7/src/main/com/fulcrologic/guardrails/config.cljc#L33
   ;; defn-like macros, you can have Ghostwheel desugar to

Yarn works but NPM does not

According to the directions, you can either use "yarn install" or "npm install"

However, using npm, it errors out due to dependency mismatches; for example:

While resolving: [email protected]
Found: [email protected]
node_modules/react
  dev react@"^17.0.1" from the root project

Could not resolve dependency:
peer react@"^0.14.0 || ^15.0.0 || ^16.0.0" from [email protected]
node_modules/react-icons
  dev react-icons@"^2.2.7" from the root project

Using yarn works and warns about these problems:

warning "react-grid-layout > [email protected]" has incorrect peer dependency "[email protected] || 15.x || 16.x".
warning "react-grid-layout > [email protected]" has incorrect peer dependency "[email protected] || 15.x || 16.x".
warning " > [email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".
warning " > [email protected]" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0 || ^16.0.0".
warning "react-icons > [email protected]" has unmet peer dependency "prop-types@*".
warning " > [email protected]" has unmet peer dependency "prop-types@^15.0.0".
warning " > [email protected]" has incorrect peer dependency "react@^16.3.0".
warning " > [email protected]" has incorrect peer dependency "react-dom@^16.3.0".
warning "reakit > [email protected]" has incorrect peer dependency "react@^16.3.0".
warning "reakit > [email protected]" has incorrect peer dependency "react-dom@^16.3.0".
warning "reakit > [email protected]" has incorrect peer dependency "react@>= 0.14.0 < 17.0.0-0".

I don't know enough about JS to debug this, but a quick-start template that sends me down a dependency rat-hole is not very friendly to new users.

Suggestion: Change documentation to remove or npm install

hello world

Hi this is likely a naive question

But how do I do hello world in this stack?

I've tried:
npm install
npm run client/main

Compiling the main build via http://localhost:9630/dashboard
Creating an index.html in public/resources pointed to /js/main/main.js with div#app

Accessing the page at: http://localhost:8022/

index.html for workspaces seems to be missing

Just toying with Fulcro. And trying to learn from this template.

I noticed that workspaces index.html is nowhere to be found after enabling the workspaces build (at least http://localhost:8023/workspaces does not have it).

I fixed it by placing index.html similar into resources/public/workspaces dir.
I took this one. And updated the path to the main.js (should be js/main.js).

lol，what is a Template?

install peer-dependencies: object-assign, scheduler

with pnpm install i get the errors

The required JS dependency "object-assign" is not available, it was required by "node_modules/react/cjs/react.production.min.js".
The required JS dependency "scheduler" is not available, it was required by "node_modules/react-dom/cjs/react-dom.production.min.js".

fixed by

pnpm i -D object-assign [email protected]

because https://www.kochan.io/nodejs/pnpms-strictness-helps-to-avoid-silly-bugs.html