Suggestion - Region Enum

[gavinpower747]

Suggestion - Region Enum

[ItsNovaHere]

I've started work on it, should I put the enum-to-string class/method in the same .cs file or separate it?

[GavinPower747]

Yeah moving the regions to enums is definitely something that I intended to do. Probably the thing to do is rather than having a ToString on it, I have a json converter in another project that will just convert it to a string at serialization so we just deal with it as the enum and then let newtonsoft take care of converting it to a string behind the scenes.

[GavinPower747]

My mistake actually it's built into Json.Net I'll use the game modes for example

using Newtonsoft.Json;
using Newtonsoft.Json.Converters;
using System.Runtime.Serialization;

    [JsonConverter(typeof(StringEnumConverter))]
    public enum PubgGameMode
    {
        [EnumMember(Value = "squad")]
        Squad,
        [EnumMember(Value = "solo")]
        Solo,
        [EnumMember(Value = "duo")]
        Duo
    }

When that's serialized it'll output the value specified in the enum member attribute, saves having to write anything extra

[GavinPower747]

And yeah definitely any suggestions you can come up with feel free to throw in an issue or DM me on Discord

[GavinPower747]

I'll be out for the rest of the night (I'm in GMT) but I'll respond first thing in the morning

[ItsNovaHere]

Ah okay. I'll use the JsonConverter then.

[ItsNovaHere]

I don't know enough about GitHub, but do you think you could give me permissions to push to the repository? Both GitHub desktop and the Visual Studio plugin like to fuck me over.

[GavinPower747]

Added you as a Contributor, will review the PR now

[GavinPower747]

PR Merged Closing