gianpispi/bauletto

Display iOS 13 style banner with ease.

bauletto's Issues

Title not showed with Icon and if Icon is nil showed empty space

If icon is nil
let settings = BaulettoSettings(icon: nil, title: "Test title", dismissMode: .never) Bauletto.show(withSettings: settings)

with icon
let settings = BaulettoSettings(icon: UIImage(systemName: "checkmark.seal.fill"), title: "Test title", dismissMode: .never) Bauletto.show(withSettings: settings)

no xcode project file

In example no xcode project file found.

Thanks,
MohsinAli Matiya

Property cannot be declared public because its type uses an internal type

Bauletto.swift throws the error

Property cannot be declared public because its type uses an internal type

in line 171.

Ideas for improving

• Customizable duration fo the animation, 1 second feels unnecessary long for the slide animation
• Banner grows if image is big, I think the height of the banner should be locked to certain value so it looks more concise
• If text is too long, the banner just expands horizontally, sometimes even outside screen's bounds. Using something like MarqueeLabel or at least multi-line label would be great.
• The forceShowNext() method does not seem to work, it makes the current banner disappear and doesn't show the next one. For now I had to use a workaround shown below:

            Bauletto.hide()
            Bauletto.shared.removeBannersInQueue()
            DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
                Bauletto.show(withSettings: settings)
            }

• Adding tap gesture so touching the banner would perform some action
• Swiping the banner out of the screen, that's the thing I don't like about stock banners, they lack any interactivity
• There should be a way to figure out publicly if a banner is currently visible
• If nil is passed as icon, the image of heart appears, I think it should be empty in this case. For now I'm passing UIImage() instead of nil

I think this library is great and I love how it looks, but it could use some improvements. If I ever find some time I'm gonna try to submit a PR with some of those changes 😃