gohypernet/hypernet-protocol

Mono-repository containing all on-chain and off-chain code for implementing the Hypernet Protocol.

hypernet-protocol's Issues

embark exec issue

Trying to run embark exec fails due to an error about "unable to add property to string". A workaround provided by an embark labs employee bypasses this error, but then we get an "unknown service: blockchain" error.

npm & dependency issues

Had to switch off of Yarn due to strange incompatibility issues (of all the things!)
OpenZeppelin & the NitroProtocol aren't playing well together - a referenced, imported OZ package (SafeMath) in the Nitro SingleAssetPayments.sol contract isn't being detected at all, probably due to a conflict because we're using OZ's "contracts-ethereum-package" library, but Nitro is trying to use OZ's "contracts" library. (The contracts-ethereum-package library is upgradeable; the other is not.)

Simple workaround that seems to be fine: rename the import to "contracts-ethereum-package" and use a relative file path to the correct node_modules folder instead of using the @ style package import; compiles and deploys fine. Not a viable long term solution, need to investigate further.

shelljs circular dependency issue causing console output spam (when calling `embark run`)

Embark currently is detecting every single sub-contract and interface and trying to deploy them

When creating a new registry entry on the User Dashboard, you are *always* asked to approve Hypertoken to the smart contract, even if you already have.

https://rinkeby.launchpad.hypernet.foundation/registries/Hypernet%20Profiles/entries

When creating a new entry, there are two steps if this is the first time: first, approving Hypertoken to the smart contract; second, sending the create-new-entry transaction, which costs one Hypertoken that is pulled from your balance.

The second time you use this, it still asks for an "approval" erc20 transaction, even though you've already sent this in the first transaction.