Comments (1)
dometto
commented on June 5, 2024
1
Thanks for the report. I was able to reproduce and write a test case. The problem was we were HTML escaping the entire YAML string before loading it, so the > was getting scrubbed, invalidating the YAML.
See gollum/gollum-lib#454 for the test case and fix.
Instead of trying to handle this one exception, I thought it might be better to go for a robust approach and not touch the YAML before we parse it. I think the new approach is robust and secure, but of course it will be slower. Feedback very welcome!
from gollum.
Related Issues (20)
- Cancellation should prompt before data loss HOT 2
- Checkout System?
- Feature request: support for wikis in subdirectories HOT 1
- How to fast forward when possible? HOT 1
- Running Docker image results in error due to git security configuration HOT 2
- Running tests fails if git's `init.defaultbranch` is not set to `master` HOT 5
- Setting the gollum author environment variables doesn't make the Git commit use them. HOT 1
- Symlink page edit editing the symlink instead of target + leaves tree with unstaged changes HOT 1
- Investigate server error reporting on save HOT 2
- Failed to install on Ubuntu 22.04 HOT 3
- Failed to run `java gollum.war` resulting in thread error HOT 3
- Ask a question
- Problems caused by language HOT 4
- Navigation macro does not recognize explicit false for sub_path HOT 2
- git creates 'main' as default branch HOT 1
- Redirects to incorrect page when being served behind nginx proxy HOT 4
- Move from RACK_ENV to APP_ENV HOT 4
- Move from master to main as default branch HOT 4
- No API in `A simple, Git-powered wiki with a sweet API and local frontend. ` HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gollum.