Giter Site home page Giter Site logo

Comments (9)

sethvargo avatar sethvargo commented on May 23, 2024

Hi @archita-desai

Thank you for opening an issue. I believe we fixed this bug but have not released a new version yet. Could you please temporarily try using google-github-actions/deploy-appengine@main to see if that resolves the issue? If not, can you please share the output from running @main? If it does fix your issue, we plan on releasing a new version this week.

from deploy-appengine.

archita-desai avatar archita-desai commented on May 23, 2024

Hi @sethvargo,
As you can see in the Action YAML file shared above, we are always running deployment using google-github-actions/deploy-appengine@main and still we are receiving the error shared above.

We have been running with this mode of pipeline and Action YAML for quite a few months and never faced such an issue.

from deploy-appengine.

sethvargo avatar sethvargo commented on May 23, 2024

Hi @archita-desai

Are you able to share the full log output?

from deploy-appengine.

archita-desai avatar archita-desai commented on May 23, 2024

@sethvargo please share your email address so that I can share the log output file with you as it is confidential.

from deploy-appengine.

archita-desai avatar archita-desai commented on May 23, 2024

@sethvargo some points from what I have observed from logs and debugging:

  1. Inside src/deploy-app-engine.ts file, the logs can be seen till line 157: logInfo(`Running: ${commandString}`);
  2. It seems that code is failing somewhere on line 160 inside deploy-app-engine.ts file and hence going inside the catch block.
  3. Please note, when trying to run gcloud app deploy dev-app.yaml command locally on the terminal, the build gets deployed as expected.

from deploy-appengine.

sethvargo avatar sethvargo commented on May 23, 2024

Hi @archita-desai it look like you found my email. In reviewing the logs, I see some inconsistencies with the Action YAML you shared. Specifically, I see ##[group]Run google-github-actions/auth@v0 which is not in your Action YAML. Can you please share your complete Action YAML?

The issue here is that GitHub Actions is swallowing the output from our gcloud command. I've submitted #216 which, once merged, should make it so we see the complete error output that gcloud is providing.

from deploy-appengine.

archita-desai avatar archita-desai commented on May 23, 2024

@sethvargo yes, just tried the same combination as here and found email.

Since we were receiving deprecation warning of passing auth variables, I had tried the newer way of passing credentials to see if it resolves the error. However, the error still persisted.
Hence, with both Action YAMLs, we are receiving the same error.

Here is the action YAML with google-github-actions/auth@v0:

name: Manual Branch
on:
  workflow_dispatch:
    inputs:
      branch:
        description: "Enter branch to deploy"
        required: true
        default: "staging"
jobs:
  deploy:
    name: Deploy
    runs-on: ubuntu-latest
    steps:
      - id: checkout
        uses: actions/checkout@v2
        with:
          ref: ${{ github.event.inputs.branch }}
      - uses: actions/setup-node@v1
        with:
          node-version: "10"
      - run: npm ci
      - run: npm run build
      - id: Auth
        uses: google-github-actions/auth@v0
        with:
          credentials_json: ${{ secrets.DEPLOYMENT_ACCOUNT }}
      - id: Deploy
        uses: google-github-actions/deploy-appengine@main
        with:
          deliverables: dev-app.yaml

Hope this helps.

from deploy-appengine.

sethvargo avatar sethvargo commented on May 23, 2024

Hi @archita-desai

Since #216 is merged, can you try re-running your workload using deploy-appengine@main and see if there's additional error output?

from deploy-appengine.

archita-desai avatar archita-desai commented on May 23, 2024

Hi @sethvargo
I tried re-running the deployments and they are running successfully now.
Thanks for the update with detailed error output, if this happens again we can re-open this issue with a detailed error output.

from deploy-appengine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.