Giter Site home page Giter Site logo

Comments (4)

sethvargo avatar sethvargo commented on June 20, 2024

The default value in the action.yml is true. Are you seeing a different behavior?

from deploy-appengine.

joeyparrish avatar joeyparrish commented on June 20, 2024

Yes. I was passing a value that happened to be blank due to a dumb workflow bug.

    with:
      promote: ${{ env.APPSPOT_PROMOTE }}

That variable was meant to be "true" or "false", but it was left out of the environment entirely. It would appear that the default in action.yml was not used in this case.

This didn't become obvious until I upgraded from v0 to v2, since v0 had the default implemented explicitly in TypeScript.

from deploy-appengine.

sethvargo avatar sethvargo commented on June 20, 2024

Right - if you pass in a value, it will use the empty string (whereas not providing a value uses the default).

from deploy-appengine.

joeyparrish avatar joeyparrish commented on June 20, 2024

Thanks!

from deploy-appengine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.