grpc-ecosystem/grpcdebug

grpcdebug is a command line interface focusing on simplifying the debugging process of gRPC applications.

grpcdebug's Issues

Crash when running channelz channels

Version: https://github.com/grpc-ecosystem/grpcdebug/releases/tag/v1.0.4

$ grpcdebug localhost:50051 channelz channels
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0xb977fc]

goroutine 1 [running]:
github.com/grpc-ecosystem/grpcdebug/cmd.channelzChannelsCommandRunWithError(0x1fd33c0?, {0x20177a0?, 0x0?, 0x0?})
        /home/veblush/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/cmd/channelz.go:118 +0x1bc
github.com/spf13/cobra.(*Command).execute(0x1fd33c0, {0x20177a0, 0x0, 0x0})
        /home/veblush/go/pkg/mod/github.com/spf13/[email protected]/command.go:850 +0x67c
github.com/spf13/cobra.(*Command).ExecuteC(0x1fd4b60)
        /home/veblush/go/pkg/mod/github.com/spf13/[email protected]/command.go:958 +0x39d
github.com/spf13/cobra.(*Command).Execute(...)
        /home/veblush/go/pkg/mod/github.com/spf13/[email protected]/command.go:895
github.com/grpc-ecosystem/grpcdebug/cmd.Execute()
        /home/veblush/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/cmd/root.go:107 +0xde
main.main()
        /home/veblush/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/main.go:163 +0x17

@menghanl: PTAL

@menghanl: PTAL

Here is the code stats:

-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Go                               9            112             69           1277
Markdown                         1             77              0            338
-------------------------------------------------------------------------------
SUM:                            10            189             69           1615
-------------------------------------------------------------------------------

Link to https://github.com/spf13/cobra
Link to design doc http://go/gdebug-cli

panic for unix:/// addresses

$ grpcdebug unix:///home/howardjohn/kube/local/proxy/XDS channelz servers
panic: Address type not supported for uds_address:<filename:"/home/howardjohn/kube/local/proxy/SDS" >

goroutine 1 [running]:
github.com/grpc-ecosystem/grpcdebug/cmd.prettyAddress(0xc000113440, 0xc0006813e0, 0xc000595cf8)
        /home/howardjohn/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/cmd/channelz.go:40 +0x145
github.com/grpc-ecosystem/grpcdebug/cmd.channelzServersCommandRunWithError(0x16ceba0, 0x170ca70, 0x0, 0x0, 0x0, 0x0)
        /home/howardjohn/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/cmd/channelz.go:320 +0x170
github.com/spf13/cobra.(*Command).execute(0x16ceba0, 0x170ca70, 0x0, 0x0, 0x16ceba0, 0x170ca70)
        /home/howardjohn/go/pkg/mod/github.com/spf13/[email protected]/command.go:850 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0x16cf380, 0xc000000180, 0x200000003, 0xc000000180)
        /home/howardjohn/go/pkg/mod/github.com/spf13/[email protected]/command.go:958 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        /home/howardjohn/go/pkg/mod/github.com/spf13/[email protected]/command.go:895
github.com/grpc-ecosystem/grpcdebug/cmd.Execute()
        /home/howardjohn/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/cmd/root.go:107 +0xc5
main.main()
        /home/howardjohn/go/pkg/mod/github.com/grpc-ecosystem/[email protected]/main.go:160 +0x25

other commands seem to work with UDS, so this seems unexpected, especially since its just on trying to print the address

Channelz requests for subchannel information should be able to handle `null` Socket address values

The Socket field remote is explicitly allowed to be absent, but the code to handle it unconditionally passes it to prettyAddress, which panics if the value is nil. It would also be good to handle the field local similarly, because output that shows that it is nil (incorrectly) would be more useful than a panic.