Comments (7)
Done! Thank you for the great work @Vrixyz @johanhelsing 🎉
from bevy_ggrs.
Yay!
I guess it's time for a new release then?
bevy_ggrs is currently depending on the git version of ggrs, so I guess that means a release of both is needed, and by extension also matchbox_socket, since the matchbox ggrs feature depends on ggrs?
from bevy_ggrs.
It should be possible to list all resources again with iter()
function as of bevy 0.9.1: https://github.com/bevyengine/bevy/blob/v0.9.1/crates/bevy_ecs/src/storage/resource.rs#L141.
link to bevy PR for context: bevyengine/bevy#6592.
from bevy_ggrs.
Yes! I will close this issue once a new version is published.
from bevy_ggrs.
This seems to be non-trivial on first glance:
- GGRS sessions are added as resources and thus now need to derive bevy's Resource trait through a feature flag in GGRS. Otherwise a wrapper struct is necessary.
- taking a snapshot of registered resources used a now no longer available API (link). In this PR resource was moved to world storage, but iterating over all resource indices is no longer possible.
world.archetypes().resource().unique_components()
gave direct access to the underlyingSparseSet<ComponentId, ResourceData>
; but in the newworld.storage.resources
, this is now private (link). This change was made since full access enabled unsafe or unsound code. Since we only used the indices, this was not an issue for us. But for now we will have to find another way.
from bevy_ggrs.
Is it something we could try to bring back in Bevy 0.9.1 with a different name and/or unsafe warnings?
from bevy_ggrs.
I think they conciously removed this and it will not come back:
All APIs accessing the raw data of individual resources (mutable and read-only) have been removed as these APIs allowed for unsound unsafe code. All usages of these APIs should be changed to use World::{get, insert, remove}_resource.
We only used the keys of the sparse set, so maybe there is hope. I do however think that there might be a nicer way to do this.
from bevy_ggrs.
Related Issues (20)
- Potential Scalability Refactor HOT 6
- Sessions `.with_desync_detection(DesyncDetection::On)` always reports false positives HOT 1
- Integration Tests incorrect HOT 2
- More idiomatic component/resource checksums for float types?
- Adding non-rollbacked children to rollbacked entities break the hierarchy HOT 1
- Desync detection appears to compare the checksum of predicted frames to confirmed frames HOT 8
- Sprite Component doesn't get respawned after rollback HOT 5
- panic: `Rollback requested was not created using AddRollbackCommand!`
- When rollbacks happen across entity spawning, desyncs are reported HOT 1
- Despawned entities are not restored HOT 2
- Convenient way to end a session HOT 5
- Checksums are not portable HOT 5
- [Question] How to sync elapsed time since startup among peers? HOT 4
- 3d example, and other questions HOT 4
- Update entity IDs in Children/Parent components on rollback. HOT 2
- Update to Bevy 0.13
- Document idiomatic way to sort rollback related queries
- Synctest session doesn't detect all desyncs that it could/should
- Adding players after p2p session already started HOT 3
- Support synchronizing parts of world state, since Rust isn't deterministic. HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bevy_ggrs.