Giter Site home page Giter Site logo

Comments (4)

sameer avatar sameer commented on July 16, 2024 1

If you would be interested in creating a pull request for this, I would be happy to review it 🙂. Otherwise, I'll update the repo at some point.

Let me know how you'd like to proceed. Thanks again for finding this and reporting it

from hdmi.

sameer avatar sameer commented on July 16, 2024

Hi Kris,

Thanks for the detailed report, you're definitely correct. The data island preamble starts prematurely and runs for 8 pixels, when instead it should be delayed by >=4 to get the control period length of 12 pixels.

I'm surprised this has not come up before, maybe most sinks are a little forgiving on this.

There are a few things that need to change:

  • data_island_guard (8 to 12, 10 to 14)
  • data_island_preamble (0 to 4, 8 to 12)
  • data_island_period_instantaneous (10 to 14)
  • packet_enable (22 to 18)
  • max_num_packets_alongside -- I think this is slightly wrong, too. Need to remove v preamble / d preamble (-16), replace with additional control period (12). There's 4 extra pixels that are not considered

from hdmi.

sameer avatar sameer commented on July 16, 2024

Looking through the issues, this could be the root cause of the issue @mopplayer was having in #35

from hdmi.

krisdover avatar krisdover commented on July 16, 2024

Looking through the issues, this could be the root cause of the issue @mopplayer was having in #35

https://imgur.com/ArIkfPk

Yes, I was definitely getting the same 2-pixel white bar to the left of the display as reported in issue #35, that is until I fixed the minimum control period bug.

from hdmi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.