heapwolf/level-mget

get multiple values from leveldb

level-mget's Issues

Complex keys

This module currently only supports simple string keys. As leveldb supports complex key types, it would be nice to also support them here.

I can put together a PR that uses a Map to represent the return values, if that is something you would be interested in let me know.

Example:

mget(db, [['namespace', 'key']], function (err, vals) {
  console.log(vals); // Map{['namespace', 'key']: 'value'}
});

Handling of NotFound errors

Having only one error returned seems inconsistent when a NotFound error, which is most likely a "soft error", is treated just like a "real error". What do you think about adding handling for NotFound errors where the error is not set, but the value is set to undefined?

Consider this case:

1. First get operation is an error opening the database, like a permissions error
2. Some other condition causes access to be restored, like during execution, the permissions are fixed
3. The next key is NotFound

The result of this sequence is a single NotFound error, and the other more important error being discarded silently. Thus hiding a race condition in your code, and a difficult to debug scenario.

The solution above will still swallow an error, but atleast it will not be the more common "soft error" case of a key not found.

Another more comprehensive solution, would be to accumulate all the errors, and make them come back as null || Map, where the key is set to the error in the map.

Thought?