hexafluoride/byteflood

A free as in freedom BitTorrent client, designed for everyone.

byteflood's Issues

Resizing Bug

If the window is resized smaller to a certain point vertically the program crashes.

The attached images contain the offending code, and (slightly larger than) the size that it crashes at.

You could either not draw if the calculated height is < 0 (save on resource usage) or simply set it to 1px.

Loading torrents from state.xml fails.

It hashchecks in the usual way, but after that, it switches to the "Error" state and just sits there.

Inspecting ti.Torrent using debugging tools revealed nothing suspicious.

I also had to move int ticks = 120; in MainWindow.xaml.cs - Update() to outside the function, and initialize it with 0 to make it not throw an exception.

monotorrent license mit

it states you have to include it
so
include it

RSS support is partly broken

The current RSS implementation expects the torrent link to be in the <link> tag, but in all feeds I have seen so far, it exists in the <enclosure> tag.

Doing a simple links.Where(link => link.EndsWith(".torrent")) won't work because some feeds have torrent files that don't end with .torrent.

Cannot load torrent from state if the original torrent file was removed.

Possible fixes:

• Check file existence before calling MonoTorrent.Common.Torrent.Load, if it doesn't, drop the torrent or display an error message like uTorrent.
• Copy .torrent files to a temporary directory (in the user app data for example), like transmission.

Magnet still not fully functional

Hi there.

Tried your client and saw the latest release, where Magnet links should be fixed (and you've indeed made it more stable). But for instance, it doesn't work with this torrent:

http://www.mininova.org/tor/13205249

This is what I see: http://i.imgur.com/6FC3ou4.png

And it stays there forever.

I am very interested in a fix, since some of my own torrent client borrowed code from yours. You've done a great job in debugging and maintaining the original MonoTorrent framework, and I hope to hear more from you in the regards of Magnet support.

Resizing canvas is buggy

NotifyIcon implementation details.

I think this control

http://visualstudiogallery.msdn.microsoft.com/aacbc77c-4ef6-456f-80b7-1f157c2909f7
http://www.hardcodet.net/wpf-notifyicon

is our best bet.

What do you think, hex?

Incorrect ratio mapping

When I add a new torrent to download it displays "ration is NaN" is this correct behavior?

Bugs.

• Incorrect download size (the torrent was finished with an additional ~0.6 MB)

• Can't stop a torrent if the queue is enabled.
• Enable queue setting checkbox doesn't work.

Implement torrent queuing

Any chance of a new binary release?

Seems like a lot of functionality has been added since the last release which was almost a month ago. Would love to see a new release!

Have an auto updater.

Saw this feature requested a lot in the last thread. It would be nice to have. Should I do it or you, hex?

So here is what I got:

• Have an update.xml file in the repository, containing the URL of the latest release and change log.
• The rest is consist of having a mechanism of update checking and downloading in ByteFlood.

Support sequential downloading

Most other torrent clients support "in order" or sequential downloading. I love byteflood, it runs great on my Microsoft Windows™ 10 Zune™, but I can't recommend it to all my Microsoft Windows™-loving friends without sequential downloading. Please add this essential feature.

Dragging .magnet link into Byteflood will crash.

Make Ragnar better.

Can't compile in Visual Studio 2010

Can compile/build the project. The ByteFlood project appears to be a VS 2013 while the rest of the other project is for VS 2010. Can someone fix this?

Localisations?

There's no easy way to localise ByteFlood to other languages yet.
Would it be possible to implement that? It'd be only beneficial to both the end-user and the gaining of popularity.

Cannot download magnet URI

When I entered the following magnet URL (it's nothing special, just a .txt file) Byteflood crashed and generated the following error message:

Magnet URI: magnet:?xt=urn:btih:7F43F86D537F4BCE3E9C5A992DF7B7F8ED354EB1
Error message:

Buffer cannot be null.
Parameter name: buffer
Stacktrace:
at System.IO.MemoryStream..ctor(Byte[] buffer, Boolean writable)
at System.IO.MemoryStream..ctor(Byte[] buffer)
at ByteFlood.Utility.DecompressGzip(Byte[] gzip_data) in c:\Users\Istan\Documents\GitHub\byteflood\ByteFlood\Utility.cs:line 320
at ByteFlood.Services.TorrentCache.Torrage.Fetch(MagnetLink magnet) in c:\Users\Istan\Documents\GitHub\byteflood\ByteFlood\Services\TorrentCache\Torrage.cs:line 38
at ByteFlood.State.GetMagnetFromCache(MagnetLink mg) in c:\Users\Istan\Documents\GitHub\byteflood\ByteFlood\State.cs:line 185
at ByteFlood.State.AddTorrentByMagnet(String magnet) in c:\Users\Istan\Documents\GitHub\byteflood\ByteFlood\State.cs:line 150
at ByteFlood.MainWindow.Commands_AddMagnet(Object sender, ExecutedRoutedEventArgs e) in c:\Users\Istan\Documents\GitHub\byteflood\ByteFlood\UI\MainWindow.xaml.cs:line 372
at System.Windows.Input.CommandBinding.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
at System.Windows.Input.CommandManager.ExecuteCommandBinding(Object sender, ExecutedRoutedEventArgs e, CommandBinding commandBinding)
at System.Windows.Input.CommandManager.FindCommandBinding(CommandBindingCollection commandBindings, Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
at System.Windows.Input.CommandManager.FindCommandBinding(Object sender, RoutedEventArgs e, ICommand command, Boolean execute)
at System.Windows.Input.CommandManager.OnExecuted(Object sender, ExecutedRoutedEventArgs e)
at System.Windows.UIElement.OnExecutedThunk(Object sender, ExecutedRoutedEventArgs e)
at System.Windows.Input.ExecutedRoutedEventArgs.InvokeEventHandler(Delegate genericHandler, Object target)
at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
at System.Windows.Input.RoutedCommand.ExecuteImpl(Object parameter, IInputElement target, Boolean userInitiated)
at System.Windows.Input.RoutedCommand.ExecuteCore(Object parameter, IInputElement target, Boolean userInitiated)
at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(ICommandSource commandSource, Boolean userInitiated)
at System.Windows.Controls.Primitives.ButtonBase.OnClick()
at System.Windows.Controls.Button.OnClick()
at System.Windows.Controls.Primitives.ButtonBase.OnMouseLeftButtonUp(MouseButtonEventArgs e)
at System.Windows.UIElement.OnMouseLeftButtonUpThunk(Object sender, MouseButtonEventArgs e)
at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
at System.Windows.UIElement.OnMouseUpThunk(Object sender, MouseButtonEventArgs e)
at System.Windows.Input.MouseButtonEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
at System.Windows.Input.InputManager.ProcessStagingArea()
at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)

Source:
mscorlib

Torrents don't resume.

Possible memory leaks.

I have been running ByteFlood to download torrents for real-world usage testing, and I have noticed that after a while, memory usage is pretty high.

This was token after 10 minutes, while downloading only 1 large (13GB) torrent:

And this one running 3 normal torrents until they all finished downloading:

Obviously something is wrong here. I will try to investigate the problem, but I thought I should let you be aware of it.

v0.6?

Are there any enhancements/bugfixes that are needed before releasing v0.6?

GlobalMaxDownloadSpeed and GlobalMaxUploadSpeed doesn't work.

I can see that the calls are being made to RateLimiter, but it doesn't actually limit the speed for some reason.

Adding a magnet link crashes the whole application.

Added a magnet link from a certain resilient torrent site.

Output from Windows:
Problem signature:
Problem Event Name: CLR20r3
Problem Signature 01: byteflood.exe
Problem Signature 02: 1.0.0.0
Problem Signature 03: 53f91c47
Problem Signature 04: mscorlib
Problem Signature 05: 4.0.0.0
Problem Signature 06: 52ccf750
Problem Signature 07: 3fde
Problem Signature 08: 105
Problem Signature 09: System.IO.DirectoryNotFound
OS Version: 6.1.7601.2.1.0.256.1
Locale ID: 2057
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789

Read our privacy statement online:
http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement offline:
C:\Windows\system32\en-US\erofflps.txt

New torrents are always downloaded into C:\Users\xxx\Downloads regardless of the selected folder

you have my permission to pentest toxme.io

you can't break it hex

Theme colours

Hurry up and support changing theme colour. It's like byteflood is stuck in 2008. I mean come on.

Finished torrent size and downloaded amount mismatch

Status says seeding, size 2.84 GB, downloaded 2.83 GB.