Giter Site home page Giter Site logo

introduce ActionMailer mixin about reactor HOT 2 OPEN

hired avatar hired commented on July 28, 2024 1
introduce ActionMailer mixin

from reactor.

Comments (2)

sirwolfgang avatar sirwolfgang commented on July 28, 2024

This issue has been sitting for awhile. Can this code be extracted and shared? How different is it from Subscribable?

from reactor.

sirwolfgang avatar sirwolfgang commented on July 28, 2024

Looking the current mailer worker code, I am not entirely sure how that is supposed to be used? The specs make it look like you need to create a worker per email, which doesn't seem right to me.

That said, the regular subscriber mixin looks to work if you change the class_exec to be an instance_exec like this:

mailer.run_callbacks(:process_action) do
  if action.is_a?(Symbol)
    mailer.public_send(action, event)
  else
    mailer.instance_exec(event, &action)
  end
end

Then all the binding for the view like @user = event.actor bind correctly. I still need to run an integration test to make sure the emails get out the door, but all my specs are working.

from reactor.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.