Giter Site home page Giter Site logo

Comments (6)

winfred avatar winfred commented on July 28, 2024

cc @heythisisnate @joelmichael @dashkb and @schlende

from reactor.

heythisisnate avatar heythisisnate commented on July 28, 2024

I think this is a great idea for 1.0. RailsConf hack project?

from reactor.

schlende avatar schlende commented on July 28, 2024

Pretty interested in getting #21 out of the way. I keep needing that kind of functionality and feel weird about future jobs sitting in Redis.

from reactor.

winfred avatar winfred commented on July 28, 2024

this is pretty close to a total re-write.

  • Reactor::Publishable is being removed, recommend users switch to hired/chron for this functionality.
  • Reactor::Subscriber will need an ActiveJob wrapper, no longer using Sidekiq's Class.delay hack
  • The whole static subscriber pattern needs to inherit from ActiveJob... may be easier to dump that pattern and go with a more sensible parameterized container job. (Like in hired/chron)

from reactor.

winfred avatar winfred commented on July 28, 2024

oh yeah, also it looks like the GlobalId support only applies to bare/unnamed arguments and not the contents of an arbitrary hash of data, so we can't really use it in this case. =(

discovered this "the hard way" by seeing this while TDD http://edgeapi.rubyonrails.org/classes/ActiveJob/SerializationError.html

oh well, the old serializing code will still work

from reactor.

winfred avatar winfred commented on July 28, 2024

I still get jokes about ActiveJob vs. Sidekiq on my twitter feed.

❤️ you rails but it sounds like most people are staying on vanilla sidekiq.

feel free to resurrect this if want!

from reactor.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.