Reschedule Functionality Has Highly Variable Performance

[therabidbanana]

Reschedule Functionality Has Highly Variable Performance

[therabidbanana]

Likely instead of having a hook for rescheduling:

reactor/lib/reactor/models/concerns/publishable.rb

Lines 31 to 47 in f41266a

	def reschedule_events_on_update
	self.class.events.each do |name, data|
	attr_changed_method = data[:watch] || data[:at]
	if previous_changes[attr_changed_method]
	reschedule(name, data)
	end
	end
	end
	def reschedule(name, data)
	if data[:at]
	event = event_data_for_signature(data).merge(
	was: previous_changes[data[:at]].try(:first) || send("#{data[:at]}_was")
	)
	Reactor::Event.reschedule(name, event) if should_fire_reactor_event?(data)
	end
	end

We would make it so scheduled events could abort by updating the need_to_fire logic to care about scheduling as well as the generic "ifarg" logic:

reactor/lib/reactor/event.rb

Lines 24 to 37 in 8c68156

	if data['actor_type']
	actor = data["actor_type"].constantize.unscoped.find(data["actor_id"])
	publishable_event = actor.class.events[name.to_sym]
	ifarg = publishable_event[:if] if publishable_event
	end
	need_to_fire = case ifarg
	when Proc
	actor.instance_exec(&ifarg)
	when Symbol
	actor.send(ifarg)
	when NilClass
	true
	end

In theory, if we queue a job with Reactor data including the attribute we're watching to schedule and current value, then we can check the value is still equal to the most recent value when the actor gets hydrated:

reactor/lib/reactor/event.rb

Line 25 in 8c68156

actor = data["actor_type"].constantize.unscoped.find(data["actor_id"])

In publishable, we use the :at param and call that method to get the value - we could save :at_attribute as the actual attribute so we can compute this check on

reactor/lib/reactor/models/concerns/publishable.rb

Line 72 in f41266a

at: (signature[:at] ? send(signature[:at]) : nil)