homebridge-openwebif-tv

[homebridge]

homebridge-openwebif-tv

[oznu]

• - The plugin must successfully install.
• - The plugin must impliment the Homebridge Plugin Settings GUI.
• - The plugin must not start unless it is configured.
• - The plugin must not execute postinstall scripts that modify the users system in any way.
• - The plugin must not contain any analytics or calls that enable you to track the user.
• - The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.
• - The plugin must be published to npm and the source code available on GitHub.
• - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
• - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

---

The plugin must not start unless it is configured.

If the plugin is not configured Homebridge wish crash with:

[3/29/2020, 20:48:40] TypeError: this.log is not a function
    at new openwebIfTvPlatform (/Users/john/src/homebridge/homebridge-openwebif-tv/index.js:23:9)

To fix this change:

this.log('No configuration found for homebridge-openwebif-tv');
return;

To:

log('No configuration found for homebridge-openwebif-tv');
return;

Or you can move the this.log = log; line to the top.

---

Everything else looks good 😄

I would recommend adding a .gitignore file to your project to exclude the node_modules folder.

[grzegorz914]

fixed

[oznu]

Thanks 😄