Giter Site home page Giter Site logo

Comments (7)

matlabbe avatar matlabbe commented on July 17, 2024

I've noticed too this morning the long compilation of CoreWrapper.cpp. On Trusty, the amd64 binary of rtabmap_ros took around 50 min:

I've already seen a long compilation time of rtabmap_ros when I used "catkin -j4" on a machine with RAM available below 6 Gig. Some files require over 1 Gig to compile (thx PCL!), so with 4 threads, the swap was required. Using the swap memory increases a lot the compilation time.

Well, I tried with a fresh virtual machine with Ubuntu 15.04 + Jade and built rtabmap + rtabmap_ros. It builds flawlessly. The maximum RAM used was 1.9 Gig for CoreWrapper.cpp. This may be the problem.

from rtabmap_ros.

vrabaud avatar vrabaud commented on July 17, 2024

ok, well, you're on top of it :) Probably highly templated code.Maybe you can split it in smaller files.

from rtabmap_ros.

matlabbe avatar matlabbe commented on July 17, 2024

I'll check if I can split some of the PCL headers to reduce the memory load used for compilation. What is the RAM available on the buildfarm machines so I can target a memory usage limit?

from rtabmap_ros.

vrabaud avatar vrabaud commented on July 17, 2024

some code could not use PCL. E.g. https://github.com/introlab/rtabmap_ros/blob/master/src/CoreWrapper.cpp#L765 could use tf2_sensor_msgs by keeping a PointCloud2 (got added recently). You don't even need the whole tf2 infrastructure, you can just use: https://github.com/ros/geometry_experimental/blob/indigo-devel/tf2_sensor_msgs/include/tf2_sensor_msgs/tf2_sensor_msgs.h#L59

from rtabmap_ros.

matlabbe avatar matlabbe commented on July 17, 2024

Thank you, I'll look at this!

from rtabmap_ros.

matlabbe avatar matlabbe commented on July 17, 2024

Some refactoring were done in upstream rtabmap library (particularly the big rtabmap/core/util3d.h file, which included many pcl headers) as well as splitting CoreWrapper.cpp in two files.

Looking on Jenkins, the long build time seems not here anymore. It took 18 min on the latest version 0.9.0 on vivid amd64 (instead of 1 hr 34 min for previous 0.8.12 version):
http://jenkins.ros.org/job/ros-jade-rtabmap-ros_binarydeb_vivid_amd64/5/

from rtabmap_ros.

vrabaud avatar vrabaud commented on July 17, 2024

thx !

from rtabmap_ros.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.