izuzak/atom-pdf-view

Support for viewing PDF files in Atom.

atom-pdf-view's Issues

Update to the latest pdf.js library

Pdf-view is currently using mozilla/pdf.js@ae92b6f, which is almost 3 months old. It seems that there have been a few changes in pdf.js related to how PDFs are loaded, so I need to check this out more closely.

Implement search

Would be 🆒 to provide a way to find text in the PDF (even without highlighting the specific match), perhaps even with the standard search package somehow.

Should be possible to get to the text of the PDF with page.getTextContent which is provided by pdf.js -- see this example.

Not actually working.

Installed and open PDF , but just only PDF binary datas displayed.
Tested on atom 0.128

Install fails when atom binary is not named "atom"

Attempt to install after v0.6.0 fails if atom is not named "atom" in the filesystem.

Upgrade will fail.

Update for Atom 0.121

Pathwatcher is reported to be incompatible ..? It fails with Error: no error.

Native Modules Not Compatible With Atom

I got the following message with Atom 0.189:

The following packages could not be loaded because they contain native modules that aren't compatible with this version of Atom.

Previous Atom versions shipped with Chrome 31 and Node 0.11.10 but Atom now ships with Chrome 41.0.2272.76 and Node 1.5.1.

The packages listed should now ship versions of these native modules that are compatible with Node 1.5.1.

Updates for these packages may already be available that resolve this issue.

If no update is available you may want to notify the package author that their package isn't supported in Atom 0.189.0 because of the Chrome 41.0.2272.76 and Node 1.5.1 upgrade.

If you think a package is listed here and should no longer be, click the button below to reload Atom and recheck all packages.

Reload Atom And Recheck Packages
Pdf View 0.17.0Check for UpdateReport IssueDisable Package
Listed below are the incompatible native modules that this package depends on.

[email protected]
Error message: Module version mismatch. Expected 43, got 41.
[email protected]
Error message: Module version mismatch. Expected 43, got 41.

Zooming is incorrect sometimes

Steps to reproduce:

1. open node_modules/pdf.js/web/compressed.tracemonkey-pldi-09.pdf from the package's folder
2. scroll to the last page 14/14
3. zoom in
4. observe that you're no longer on the last page, but on the previous page 13/14
5. zoom out
6. observe that you're on the last page again

GIF time:

Build error

OS: Win 8 64bits

I'm having this issue when trying to update not sure why.

fs.js:760
  return binding.unlink(pathModule._makeLong(path));
                 ^
Error: EPERM, operation not permitted 'C:\Users\arguser\.atom\packages\pdf-view\node_modules\pathwatcher\build\Release\pathwatcher.node'
    at Object.fs.unlinkSync (fs.js:760:18)
    at fixWinEPERMSync (c:\Program Files (x86)\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\fs-plus\node_modules\rimraf\rimraf.js:152:13)
    at rimrafSync (c:\Program Files (x86)\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\fs-plus\node_modules\rimraf\rimraf.js:216:26)
    at c:\Program Files (x86)\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\fs-plus\node_modules\rimraf\rimraf.js:245:5
    at Array.forEach (native)
    at rmkidsSync (c:\Program Files (x86)\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\fs-plus\node_modules\rimraf\rimraf.js:244:26)
    at rmdirSync (c:\Program Files (x86)\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\fs-plus\node_modules\rimraf\rimraf.js:237:7)
    at fixWinEPERMSync (c:\Program Files (x86)\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\fs-plus\node_modules\rimraf\rimraf.js:150:5)
    at rimrafSync (c:\Program Files (x86)\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\fs-plus\node_modules\rimraf\rimraf.js:216:26)
    at c:\Program Files (x86)\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\fs-plus\node_modules\rimraf\rimraf.js:245:5

Uncaught SyntaxError: /home/fabio/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^Unexpected token ILLEGAL

Atom Version: 0.190.0
System: linux 3.19.3-200.fc21.x86_64
Thrown From: pdf-view package, v0.17.0

Stack Trace

Uncaught SyntaxError: /home/fabio/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26
PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unexpected token ILLEGAL

At /home/fabio/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26

/home/fabio/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26
PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Unexpected token ILLEGAL
  at exports.runInThisContext (vm.js:53:16)
  at Module._compile (module.js:435:25)
  at Object.loadFile [as .js] (/usr/share/atom/resources/app/src/babel.js:162:21)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at Object.<anonymous> (/home/fabio/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:4:1)
  at Object.<anonymous> (/home/fabio/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:1:1)
  at Module._compile (module.js:452:26)
  at Object.requireCoffeeScript (/usr/share/atom/resources/app/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at openUri (/home/fabio/.atom/packages/pdf-view/lib/pdf-editor.coffee:18:22)
  at wrappedOpener (/usr/share/atom/resources/app/src/workspace.js:510:18)
  at Workspace.module.exports.Workspace.openURIInPane (/usr/share/atom/resources/app/src/workspace.js:432:22)
  at Workspace.module.exports.Workspace.open (/usr/share/atom/resources/app/src/workspace.js:365:19)
  at TreeView.module.exports.TreeView.openSelectedEntry (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:710:31)
  at TreeView.module.exports.TreeView.entryClicked (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:427:18)
  at tree-view-file.<anonymous> (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:178:26)
  at space-pen-div.jQuery.event.dispatch (/usr/share/atom/resources/app/node_modules/jquery/dist/jquery.js:4430:9)
  at space-pen-div.elemData.handle (/usr/share/atom/resources/app/node_modules/jquery/dist/jquery.js:4116:28)

Commands

     -2:21.7 core:confirm (atom-text-editor.editor.mini)
     -2:11.7 core:close (ol.tree-view.list-tree.has-collapsable-children.focusable-panel.full-menu)
     -2:08.2 find-and-replace:show (atom-text-editor.editor)
     -2:06.3 find-and-replace:focus-next (atom-text-editor.editor.mini)
     -2:00.4 editor:consolidate-selections (atom-text-editor.editor)
     -2:00.4 core:cancel (atom-text-editor.editor)
     -1:59.1 core:save (atom-text-editor.editor)
     -0:57.0 core:select-to-bottom (atom-text-editor.editor)
     -0:56.2 core:paste (atom-text-editor.editor)
     -0:55.1 core:undo (atom-text-editor.editor)
     -0:47.3 core:paste (atom-text-editor.editor)
     -0:45.9 core:save (atom-text-editor.editor)
  2x -0:23.6 core:backspace (atom-text-editor.editor)
     -0:22.2 core:move-up (atom-text-editor.editor)
     -0:22.0 core:move-left (atom-text-editor.editor)
  2x -0:21.0 core:save (atom-text-editor.editor)

Config

{
  "core": {}
}

Installed Packages

# User
autocomplete-bibtex, v0.5.6
autocomplete-css, v0.6.0
autocomplete-glsl, v0.2.1
autocomplete-haskell, v0.2.1
autocomplete-html, v0.5.0
autocomplete-paths, v1.0.2
autocomplete-plus, v2.9.0
autocomplete-plus-jedi, v0.0.9
bezier-curve-editor, v0.6.6
color-picker, v1.6.0
git-log, v0.3.0
highlight-line, v0.10.1
language-cmake, v0.1.1
language-d, v3.1.2
language-diff, v0.3.0
language-erlang, v2.0.0
language-gitignore, v0.2.0
language-glsl, v2.0.0
language-haskell, v1.0.0
language-idl, v0.2.0
language-latex, v0.6.0
language-llvm, v0.1.0
language-opencl, v0.1.0
language-qml, v0.1.0
language-r, v0.1.1
language-sln, v0.1.0
language-svg, v0.8.0
language-swig, v0.1.0
language-twig, v1.6.0
language-x86, v0.1.0
linter, v0.12.0
linter-clang, v2.25.1
linter-javac, v0.1.3
linter-js-yaml, v1.0.0
linter-python-pep8, v0.2.0
minimap, v4.7.6
minimap-git-diff, v4.1.2
ogg-preview, v0.2.0
pdf-view, v0.17.0
project-manager, v1.15.5
quick-move-file, v0.7.0
svg-preview, v0.5.1

# Dev
No dev packages

Uncaught Error: ENOENT: no such file or directory, open '/home/ivan/latex/cubawiki/AED3-Apunte-sa...

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 1.0.0
System: Ubuntu 14.04.2
Thrown From: pdf-view package, v0.22.0

Stack Trace

Uncaught Error: ENOENT: no such file or directory, open '/home/ivan/latex/cubawiki/AED3-Apunte-sacamacho/apunte.pdf'

At fs.js:519

Error: ENOENT: no such file or directory, open '/home/ivan/latex/cubawiki/AED3-Apunte-sacamacho/apunte.pdf'
    at Error (native)
    at Object.fs.openSync (fs.js:544:18)
    at Object.module.(anonymous function) [as openSync] (ATOM_SHELL_ASAR.js:118:20)
    at Object.fs.readFileSync (fs.js:396:15)
    at Object.fs.readFileSync (ATOM_SHELL_ASAR.js:369:29)
    at PdfEditorView.module.exports.PdfEditorView.updatePdf (/home/ivan/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:155:35)
    at /home/ivan/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:61:26
    at later (/usr/share/atom/resources/app.asar/node_modules/underscore-plus/node_modules/underscore/underscore.js:724:25)

Commands

     -2:14.3.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -2:07.9.0 editor:newline (atom-text-editor.editor.is-focused)
     -2:07.6.0 core:paste (atom-text-editor.editor.is-focused)
     -2:07.1.0 core:save (atom-text-editor.editor.is-focused)
     -1:47.4.0 latex:build (atom-text-editor.editor.is-focused)
     -0:36.4.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:35.9.0 core:save (atom-text-editor.editor.is-focused)
  2x -0:35.1.0 latex:build (atom-text-editor.editor.is-focused)
     -0:27 core:save (atom-text-editor.editor.is-focused.autocomplete-active)
     -0:26.2.0 latex:build (atom-text-editor.editor.is-focused)
     -0:22.9.0 editor:move-to-beginning-of-word (atom-text-editor.editor.is-focused)
     -0:18.5.0 core:move-left (atom-text-editor.editor.is-focused)
     -0:18.2.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:17.8.0 core:save (atom-text-editor.editor.is-focused)
     -0:12.5.0 latex:build (atom-text-editor.editor.is-focused)
     -0:04.3.0 core:save (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "latexer"
    ]
  }
}

Installed Packages

# User
file-type-icons, v0.7.0
language-latex, v0.6.1
language-x86asm, v0.5.1
latex, v0.24.2
pdf-view, v0.22.0

# Dev
No dev packages

Failed to activate the pdf-view package

Steps to reproduce:

1. Install atom v.0.190.0
2. Install pdf-view package
3. Run atom in 1.0 API preview mode: atom -1

Atom Version: 0.190.0
System: linux 3.19.3-200.fc21.x86_64
Thrown From: pdf-view package, v0.17.0

Stack Trace

Failed to activate the pdf-view package

At undefined is not a function

TypeError: undefined is not a function
  at Object.module.exports.activate (/home/fabio/.atom/packages/pdf-view/lib/pdf-editor.coffee:7:19)
  at Package.module.exports.Package.activateNow (/usr/share/atom/resources/app/src/package.js:225:19)
  at /usr/share/atom/resources/app/src/package.js:206:30
  at Package.module.exports.Package.measure (/usr/share/atom/resources/app/src/package.js:152:15)
  at Package.module.exports.Package.activate (/usr/share/atom/resources/app/src/package.js:199:14)
  at PackageManager.module.exports.PackageManager.activatePackage (/usr/share/atom/resources/app/src/package-manager.js:435:21)
  at /usr/share/atom/resources/app/src/package-manager.js:419:29
  at Config.module.exports.Config.transact (/usr/share/atom/resources/app/src/config.js:302:16)
  at PackageManager.module.exports.PackageManager.activatePackages (/usr/share/atom/resources/app/src/package-manager.js:414:19)
  at PackageManager.module.exports.PackageManager.activate (/usr/share/atom/resources/app/src/package-manager.js:395:46)
  at Atom.module.exports.Atom.startEditorWindow (/usr/share/atom/resources/app/src/atom.js:634:21)
  at Object.<anonymous> (/usr/share/atom/resources/app/src/window-bootstrap.js:12:8)
  at Object.<anonymous> (/usr/share/atom/resources/app/src/window-bootstrap.js:23:4)
  at Module._compile (module.js:452:26)
  at Object.loadFile [as .js] (/usr/share/atom/resources/app/src/babel.js:162:21)
  at Module.load (module.js:347:32)
  at Function.Module._load (module.js:302:12)
  at Module.require (module.js:357:17)
  at require (module.js:376:17)
  at window.onload (file:///usr/share/atom/resources/app/static/index.js:54:25)

Commands

Config

{
  "core": {}
}

Installed Packages

# User
autocomplete-bibtex, v0.5.6
autocomplete-css, v0.6.0
autocomplete-glsl, v0.2.0
autocomplete-haskell, v0.2.1
autocomplete-html, v0.5.0
autocomplete-paths, v1.0.2
autocomplete-plus, v2.9.0
autocomplete-plus-jedi, v0.0.9
bezier-curve-editor, v0.6.6
color-picker, v1.6.0
fancy-new-file, v0.7.0
format-sql, v0.2.0
git-blame, v0.4.0
git-history, v2.5.0
git-log, v0.3.0
highlight-line, v0.10.1
linter, v0.12.0
linter-clang, v2.25.1
linter-javac, v0.1.3
linter-js-yaml, v1.0.0
linter-python-pep8, v0.2.0
minimap, v4.7.6
minimap-git-diff, v4.1.2
ogg-preview, v0.2.0
pdf-view, v0.17.0
project-manager, v1.15.5
quick-move-file, v0.7.0
scroll-sync, v0.1.1
svg-preview, v0.5.1
task-list, v0.7.0

# Dev
No dev packages

Cannot install in windows 8.1 x64

Cannot compile in windows
Atom version 0.179.0
MS VC++ 2010 Express installed
Python 2.7.9 x64 installled

Installing “[email protected]” failed.Hide output…

> [email protected] install C:\Users\Marco\AppData\Local\Temp\apm-install-dir-115116-4704-bsagyz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas
> node-gyp rebuild


C:\Users\Marco\AppData\Local\Temp\apm-install-dir-115116-4704-bsagyz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas>node "C:\Users\Marco\AppData\Local\atom\app-0.179.0\resources\app\apm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild 
Los proyectos de esta soluci�n se van a compilar de uno en uno. Para habilitar la compilaci�n en paralelo, agregue el modificador "/m".
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppBuild.targets(396,5): warning MSB8029: The Intermediate directory or Output directory cannot reside under the Temporary directory as it could lead to issues with incremental build. [C:\Users\Marco\AppData\Local\Temp\apm-install-dir-115116-4704-bsagyz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas\build\runas.vcxproj]
  main.cc
  runas_win.cc
c:\users\marco\.atom\.node-gyp\.node-gyp\0.21.0\deps\uv\include\uv-win.h(32): fatal error C1083: Cannot open include file: 'winsock2.h': No such file or directory (..\src\main.cc) [C:\Users\Marco\AppData\Local\Temp\apm-install-dir-115116-4704-bsagyz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas\build\runas.vcxproj]

gypnpm ERR! Windows_NT 6.2.9200
npm ERR! argv "C:\\Users\\Marco\\AppData\\Local\\atom\\app-0.179.0\\resources\\app\\apm\\bin\\\\node.exe" "C:\\Users\\Marco\\AppData\\Local\\atom\\app-0.179.0\\resources\\app\\apm\\node_modules\\npm\\bin\\npm-cli.js" "--globalconfig" "C:\\Users\\Marco\\.atom\\.apm\\.apmrc" "--userconfig" "C:\\Users\\Marco\\.atom\\.apmrc" "install" "C:\\Users\\Marco\\AppData\\Local\\Temp\\d-115116-4704-17ggql4\\package.tgz" "--target=0.21.0" "--arch=ia32" "--msvs_version=2013"
npm ERR! node v0.10.35
npm ERR! npm  v2.3.0
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls runas
npm ERR! There is likely additional logging output above.

Not compatible with Atom 0.187

The latest version of Atom doesn't work with Pdf View 0.17.0. (Atom now ships with Chrome 40.0.2214.91 and Node 1.0.0-pre).

PDF stopped rendering

With the latest update of atom, the pdfs no longer open in PDF view and the raw-text of the PDF is shown instead. Could you fix this?

Uncaught TypeError: undefined is not a function

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 0.187.0
System: Mac OS X 10.10.3
Thrown From: pdf-view package, v0.19.0

Stack Trace

Uncaught TypeError: undefined is not a function

At /Users/craigbenko/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:24

TypeError: undefined is not a function
  at PdfEditorView.module.exports.PdfEditorView.initialize (/Users/craigbenko/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:24:17)
  at PdfEditorView.View (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-space-pen-views/node_modules/space-pen/lib/space-pen.js:184:25)
  at PdfEditorView.ScrollView (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-space-pen-views/lib/scroll-view.js:12:47)
  at new PdfEditorView (/Users/craigbenko/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:12:3)
  at openUri (/Users/craigbenko/.atom/packages/pdf-view/lib/pdf-editor.coffee:18:5)
  at wrappedOpener (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:578:16)
  at Workspace.module.exports.Workspace.openURIInPane (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:495:22)
  at Workspace.module.exports.Workspace.open (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:428:19)
  at TreeView.module.exports.TreeView.openSelectedEntry (/Applications/Atom.app/Contents/Resources/app/node_modules/tree-view/lib/tree-view.js:710:31)
  at TreeView.module.exports.TreeView.entryClicked (/Applications/Atom.app/Contents/Resources/app/node_modules/tree-view/lib/tree-view.js:427:18)
  at tree-view-file.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/tree-view/lib/tree-view.js:178:26)
  at space-pen-div.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/jquery/dist/jquery.js:4430:9)
  at space-pen-div.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/jquery/dist/jquery.js:4116:28)

Commands

     -4:15.1 project-manager:save-project (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -4:13.9 core:confirm (input.native-key-bindings)
  2x -4:13.9 focus (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -4:07.9 command-palette:toggle (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -4:05.0 core:move-down (atom-text-editor.editor.mini)
     -4:04.3 core:confirm (atom-text-editor.editor.mini)
     -4:04.3 latex:build (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
     -3:53.1 command-palette:toggle (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)
  7x -3:48.7 core:backspace (atom-text-editor.editor.mini)
     -3:43.5 settings-view:open (atom-text-editor.editor.vim-mode.command-mode)
     -3:20.0 command-palette:toggle (atom-text-editor.editor.vim-mode.command-mode)
     -3:16.5 core:move-down (atom-text-editor.editor.mini)
     -3:15.8 core:confirm (atom-text-editor.editor.mini)
     -3:15.8 latex:build (atom-text-editor.editor.vim-mode.command-mode)
     -2:25.5 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:15.9 core:cancel (a.stack-toggle)

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages

# User
language-cython, v0.3.0
language-latex, v0.6.1
latex, v0.21.0
linter, v0.12.0
pdf-view, v0.19.0
project-manager, v1.15.5
vim-mode, v0.43.0

# Dev
No dev packages

Zooming support

Currently, zoom is hardcoded to 1.5. It would be great ✨ if the package supported the standard cmd-+ and cmd-- keybindings for zooming in and out.

Feature request: Watch file

Great plugin! I'd love it if it "watched" the PDF file and reloaded it if it changes. The use case I'm thinking of is compiling LaTeX documents to PDF, all within Atom.

Handle case when a file has a .pdf extension but isn't a PDF (or pdf.js thinks it isn't)

Would be cool to handle this error and notifying the user somehow, instead of silently logging an error to the console (which is what happens now).

Text selection and copy/paste support

Currently, it's possible to view and scroll the PDF only. It might be useful to have the ability to select and copy/paste text.

PDF.js supports this with an overlay on top of the canvas used for rendering (as shown in the demo), so it should be possible to make it work for Atom as well. 🔨 ✂️ 🍴

Render only when needed

As the web demo does, it would be great if only the pages that are currently in the viewport get rendered on an update. Otherwise, Atom hangs for ten seconds when updating a 100 page document.

Cannot install on Ubuntu 14.04 x64

This is my output:

Installing “[email protected]” failed.Hide output…

[email protected] install /tmp/apm-install-dir-11522-19394-163gwvj/node_modules/pdf-view/node_modules/pathwatcher/node_modules/runas
node-gyp rebuild

make: Entering directory /tmp/apm-install-dir-11522-19394-163gwvj/node_modules/pdf-view/node_modules/pathwatcher/node_modules/runas/build' CXX(target) Release/obj.target/runas/src/main.o make: Leaving directory/tmp/apm-install-dir-11522-19394-163gwvj/node_modules/pdf-view/node_modules/pathwatcher/node_modules/runas/build'

make: g++: Command not found
make: *** [Release/obj.target/runas/src/main.o] Error 127
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/opt/atom/resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack at ChildProcess.emit (events.js:98:17)
gyp ERR! stack at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Linux 3.13.0-46-generic
gyp ERR! command "node" "/opt/atom/resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /tmp/apm-install-dir-11522-19394-163gwvj/node_modules/pdf-view/node_modules/pathwatcher/node_modules/runas
gyp ERR! node -v v0.10.35
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok
npm ERR! Linux 3.13.0-46-generic
npm ERR! argv "/opt/atom/resources/app/apm/bin/node" "/opt/atom/resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/home/robbie/.atom/.apm/.apmrc" "--userconfig" "/home/robbie/.atom/.apmrc" "install" "/tmp/d-11522-19394-1w5t8rm/package.tgz" "--target=0.21.0" "--arch=x64"
npm ERR! node v0.10.35
npm ERR! npm v2.5.1
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild
npm ERR! You can get their info via:
npm ERR! npm owner ls runas
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /tmp/apm-install-dir-11522-19394-163gwvj/npm-debug.log

Status bar information

Might be nice to add some basic information about the PDF to the status bar, e.g. current page and total number of pages.

See the image-view package for inspiration.

Error activating package config for “pdf-view” SyntaxErrormessage:

Error activating package config for “pdf-view” SyntaxErrormessage: "/home/v3ss/.atom/packages/pdf-view/node_modules/pdf.js/build/singlefile/build/pdf.combined.js:26↵PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t↵ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^↵Unexpected token ILLEGAL"stack: "/home/v3ss/.atom/packages/pdf-view/node_modules/pdf.js/build/singlefile/build/pdf.combined.js:26↵PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t↵ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^↵SyntaxError: Unexpected token ILLEGAL↵ at exports.runInThisContext (vm.js:69:16)↵ at Module._compile (module.js:438:25)↵ at Object.Module._extensions..js (module.js:473:10)↵ at Module.load (/opt/atom/share/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)↵ at Function.Module._load (module.js:311:12)↵ at Module.require (module.js:363:17)↵ at require (module.js:379:17)↵ at Object. (/home/v3ss/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:4:1)↵ at Object. (/home/v3ss/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:1:1)↵ at Module._compile (module.js:455:26)↵ at Object.requireCoffeeScript as .coffee↵ at Module.load (/opt/atom/share/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)↵ at Function.Module._load (module.js:311:12)↵ at Module.require (module.js:363:17)↵ at require (module.js:379:17)↵ at Object. (/home/v3ss/.atom/packages/pdf-view/lib/pdf-editor.coffee:2:17)↵ at Object. (/home/v3ss/.atom/packages/pdf-view/lib/pdf-editor.coffee:1:1)↵ at Module._compile (module.js:455:26)↵ at Object.requireCoffeeScript as .coffee↵ at Module.load (/opt/atom/share/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)↵ at Function.Module._load (module.js:311:12)↵ at Module.require (module.js:363:17)↵ at require (module.js:379:17)↵ at Package.module.exports.Package.requireMainModule (/opt/atom/share/atom/resources/app/src/package.js:529:34)↵ at Package.module.exports.Package.activateConfig (/opt/atom/share/atom/resources/app/src/package.js:213:12)↵ at iterator (/opt/atom/share/atom/resources/app/node_modules/settings-view/lib/settings-view.js:413:23)↵ at /opt/atom/share/atom/resources/app/node_modules/settings-view/node_modules/async/lib/async.js:111:13↵ at Array.forEach (native)↵ at _each (/opt/atom/share/atom/resources/app/node_modules/settings-view/node_modules/async/lib/async.js:32:24)↵ at Object.async.each (/opt/atom/share/atom/resources/app/node_modules/settings-view/node_modules/async/lib/async.js:110:9)↵ at SettingsView.module.exports.SettingsView.activatePackages (/opt/atom/share/atom/resources/app/node_modules/settings-view/lib/settings-view.js:421:20)↵ at /opt/atom/share/atom/resources/app/node_modules/settings-view/lib/settings-view.js:101:24↵ at process._tickCallback (node.js:349:11)↵"proto: Error

Feature request: reload file

As I use pdf-view for viewing PDF files that are contiously updated, sometimes it will try to reload the PDF file when there is no such file, and fail. (Example: compiling a LaTeX file into a PDF fails.) If this happens, I currently have to close and reopen the file.

Therefore I suggest having a context-menu option or a keyboard shortcut that I could use to quickly reopen the file, without having to close and reopen its tab.

Module did not self-register

Version: PDF View 0.14.0
I'm seeing this in the error console:

[email protected]
Error message: module did not self-register

Uncaught Error: Module did not self-register.

Got this error after:

Updating to Atom 0.177.0 and pdf-view to 0.16.0.
Clicking on pdf file in tree view.

Atom Version: 0.177.0
System: Mac OS X 10.10.2
Thrown From: pdf-view package, v0.16.0

Stack Trace

Uncaught Error: Module did not self-register.

At /Applications/Atom.app/Contents/Resources/atom/common/lib/asar.js:422

Error: Module did not self-register.
  at Error (native)
  at Object.module.(anonymous function) [as .node] (/Applications/Atom.app/Contents/Resources/atom/common/lib/asar.js:422:20)
  at Module.load (/Applications/Atom.app/Contents/Resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:325:12)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at Object.<anonymous> (/Users/andrewrynhard/Development/projects/dotfiles/atom/packages/pdf-view/node_modules/pathwatcher/lib/main.js:6:13)
  at Object.<anonymous> (/Users/andrewrynhard/Development/projects/dotfiles/atom/packages/pdf-view/node_modules/pathwatcher/lib/main.js:207:4)
  at Module._compile (module.js:475:26)
  at Object.loadFile [as .js] (/Applications/Atom.app/Contents/Resources/app/src/6to5.js:140:21)
  at Module.load (/Applications/Atom.app/Contents/Resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:325:12)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at Object.<anonymous> (/Users/andrewrynhard/Development/projects/dotfiles/atom/packages/pdf-view/lib/pdf-editor-view.coffee:5:10)
  at Object.<anonymous> (/Users/andrewrynhard/Development/projects/dotfiles/atom/packages/pdf-view/lib/pdf-editor-view.coffee:1:1)
  at Module._compile (module.js:475:26)
  at Object.requireCoffeeScript [as .coffee] (/Applications/Atom.app/Contents/Resources/app/src/coffee-cache.js:74:19)
  at Module.load (/Applications/Atom.app/Contents/Resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:325:12)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at openUri (/Users/andrewrynhard/Development/projects/dotfiles/atom/packages/pdf-view/lib/pdf-editor.coffee:18:22)
  at wrappedOpener (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:568:16)
  at Workspace.module.exports.Workspace.openURIInPane (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:485:22)
  at Workspace.module.exports.Workspace.open (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:418:19)
  at TreeView.module.exports.TreeView.openSelectedEntry (/Applications/Atom.app/Contents/Resources/app/node_modules/tree-view/lib/tree-view.js:671:31)
  at TreeView.module.exports.TreeView.entryClicked (/Applications/Atom.app/Contents/Resources/app/node_modules/tree-view/lib/tree-view.js:415:18)
  at tree-view-file.<anonymous> (/Applications/Atom.app/Contents/Resources/app/node_modules/tree-view/lib/tree-view.js:171:26)
  at space-pen-div.jQuery.event.dispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/jquery/dist/jquery.js:4430:9)
  at space-pen-div.elemData.handle (/Applications/Atom.app/Contents/Resources/app/node_modules/jquery/dist/jquery.js:4116:28)

Commands

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages

# User
autocomplete-plus, v2.1.0
autocomplete-snippets, v1.0.1
coffee-lint, v0.7.3
language-docker, v1.1.2
language-latex, v0.4.1
pdf-view, v0.16.0
script, v2.16.0

# Dev
No dev packages

/cc @atom/core

LINK : fatal error LNK1158: cannot run 'rc.exe'

When I try to install I get the following error on one PC (works on others):

Installing pdf-view to C:\Users\chris.atom\packages failed

[email protected] install y:\temp\apm-install-dir-114818-8752-19az5vz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas
node-gyp rebuild

y:\temp\apm-install-dir-114818-8752-19az5vz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas>node "c:\tools\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\npm\bin\node-gyp-bin....\node_modules\node-gyp\bin\node-gyp.js" rebuild
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
main.cc
runas_win.cc
y:\temp\apm-install-dir-114818-8752-19az5vz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\nan\nan.h(672): warning C4244: 'return' : conversion from 'int64_t' to 'int', possible loss of data (..\src\main.cc) [y:\temp\apm-install-dir-114818-8752-19az5vz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas\build\runas.vcxproj]
Creating library y:\temp\apm-install-dir-114818-8752-19az5vz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas\build\Release\runas.lib and object y:\temp\apm-install-dir-114818-8752-19az5vz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas\build\Release\runas.exp
Generating code
Finished generating code
LINK : fatal error LNK1158: cannot run 'rc.exe' [y:\temp\apm-install-dir-114818-8752-19az5vz\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas\build\runas.vcxproj]

...

Windows 8.1 with VS 2012

Uncaught SyntaxError: /home/diego/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^Unexpected token ILLEGAL

The plugin dosen't work when i try to open a pdf file

Atom Version: 0.186.0
System: linux 3.18.6-1-ARCH
Thrown From: pdf-view package, v0.17.0

Stack Trace

Uncaught SyntaxError: /home/diego/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26
PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unexpected token ILLEGAL

At /home/diego/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26

/home/diego/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26
PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Unexpected token ILLEGAL
  at exports.runInThisContext (vm.js:75:16)
  at Module._compile (module.js:458:25)
  at Object.loadFile [as .js] (/usr/share/atom/resources/app/src/babel.js:162:21)
  at Module.load (module.js:370:32)
  at Function.Module._load (module.js:325:12)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at Object.<anonymous> (/home/diego/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:4:1)
  at Object.<anonymous> (/home/diego/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:1:1)
  at Module._compile (module.js:475:26)
  at Object.requireCoffeeScript (/usr/share/atom/resources/app/node_modules/coffee-cash/lib/coffee-cash.js:67:19)
  at Module.load (module.js:370:32)
  at Function.Module._load (module.js:325:12)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at openUri (/home/diego/.atom/packages/pdf-view/lib/pdf-editor.coffee:18:22)
  at wrappedOpener (/usr/share/atom/resources/app/src/workspace.js:578:16)
  at Workspace.module.exports.Workspace.openURIInPane (/usr/share/atom/resources/app/src/workspace.js:495:22)
  at Workspace.module.exports.Workspace.open (/usr/share/atom/resources/app/src/workspace.js:428:19)
  at TreeView.module.exports.TreeView.openSelectedEntry (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:710:31)
  at TreeView.module.exports.TreeView.entryClicked (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:427:18)
  at tree-view-file.<anonymous> (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:178:26)
  at space-pen-div.jQuery.event.dispatch (/usr/share/atom/resources/app/node_modules/jquery/dist/jquery.js:4430:9)
  at space-pen-div.elemData.handle (/usr/share/atom/resources/app/node_modules/jquery/dist/jquery.js:4116:28)

Add CONTRIBUTING guidelines

Embedded PDF images vanish

Hey!

OS: OSX 10.10.5
atom: 1.0.7
pdf-view: 0.23.0

I am using atom to preview a (latex generated) PDF file. Everything is fine, however figures vanish, reappear or are distorted when I change the zoom. Some figures newer show themselves. The PDF document itself is fine, as preview and other PDF viewer show the correct contents.

The attached screenshot demonstrates this, left atom pdf-view, right OSX-preview, both for the same document.

Thanks,
Lukas

PDF appears blurry, normal when opened in preview

Example attached.

Save zoom and scroll position on reload

If the file is modified, the view resets to the default zoom level and scrolls to the top. It'd be nice, if the zoom doesn't change and the scroll position stays the same.

Support for bookmarks

The pdf-viewer doesn't support hyperlinks inside the pdf. Can we have this feature too?

PDF viewer not working with atom V0.166

I am using atom version 0.166 and the PDF viewer doesn't seem to work, when opening a PDF I get the following error:

Uncaught SyntaxError: /home/doug/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26 PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Unexpected token ILLEGAL

and the this stack trace:

/home/doug/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26 PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ SyntaxError: Unexpected token ILLEGAL at exports.runInThisContext (vm.js:73:16) at Module._compile (module.js:451:25) at Object.Module._extensions..js (module.js:486:10) at Module.load (/usr/share/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36) at Function.Module._load (module.js:318:12) at Module.require (module.js:373:17) at require (module.js:392:17) at Object.<anonymous> (/home/doug/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:4:1) at Object.<anonymous> (/home/doug/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:1:1) at Module._compile (module.js:468:26) at Object.requireCoffeeScript [as .coffee] (/usr/share/atom/resources/app/src/coffee-cache.js:61:19) at Module.load (/usr/share/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36) at Function.Module._load (module.js:318:12) at Module.require (module.js:373:17) at require (module.js:392:17) at openUri (/home/doug/.atom/packages/pdf-view/lib/pdf-editor.coffee:18:22) at Workspace.module.exports.Workspace.openUriInPane (/usr/share/atom/resources/app/src/workspace.js:479:22) at Workspace.module.exports.Workspace.open (/usr/share/atom/resources/app/src/workspace.js:412:19) at TreeView.module.exports.TreeView.openSelectedEntry (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:639:31) at TreeView.module.exports.TreeView.entryClicked (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:383:18) at tree-view-file.<anonymous> (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:171:26) at space-pen-div.jQuery.event.dispatch (/usr/share/atom/resources/app/node_modules/archive-view/node_modules/atom-space-pen-views/node_modules/space-pen/vendor/jquery.js:4676:9) at space-pen-div.elemData.handle (/usr/share/atom/resources/app/node_modules/archive-view/node_modules/atom-space-pen-views/node_modules/space-pen/vendor/jquery.js:4360:46)

Uncaught Error: Cannot find module './../node_modules/pdf.js/build/generic/build/pdf.js'

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 0.181.0
System: linux 3.18.6-1-ARCH
Thrown From: pdf-view package, v0.17.0

Stack Trace

Uncaught Error: Cannot find module './../node_modules/pdf.js/build/generic/build/pdf.js'

At module.js:353

Error: Cannot find module './../node_modules/pdf.js/build/generic/build/pdf.js'
  at Module._resolveFilename (module.js:351:15)
  at Function.Module._resolveFilename (/usr/local/share/atom/resources/app/src/module-cache.js:383:52)
  at Function.Module._load (module.js:293:25)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at Object.<anonymous> (/home/ncaz/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:4:1)
  at Object.<anonymous> (/home/ncaz/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:1:1)
  at Module._compile (module.js:475:26)
  at Object.requireCoffeeScript (/usr/local/share/atom/resources/app/node_modules/coffee-cash/lib/coffee-cash.js:67:19)
  at Module.load (module.js:370:32)
  at Function.Module._load (module.js:325:12)
  at Module.require (module.js:380:17)
  at require (module.js:399:17)
  at openUri (/home/ncaz/.atom/packages/pdf-view/lib/pdf-editor.coffee:18:22)
  at wrappedOpener (/usr/local/share/atom/resources/app/src/workspace.js:566:16)
  at Workspace.module.exports.Workspace.openURIInPane (/usr/local/share/atom/resources/app/src/workspace.js:483:22)
  at Workspace.module.exports.Workspace.open (/usr/local/share/atom/resources/app/src/workspace.js:416:19)
  at TreeView.module.exports.TreeView.openSelectedEntry (/usr/local/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:671:31)
  at TreeView.module.exports.TreeView.entryClicked (/usr/local/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:415:18)
  at tree-view-file.<anonymous> (/usr/local/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:171:26)
  at space-pen-div.jQuery.event.dispatch (/usr/local/share/atom/resources/app/node_modules/jquery/dist/jquery.js:4430:9)
  at space-pen-div.elemData.handle (/usr/local/share/atom/resources/app/node_modules/jquery/dist/jquery.js:4116:28)

Commands

     -1:06.1 application:open-folder (atom-text-editor.editor)

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "seti-syntax"
    ],
    "autoHideMenuBar": true,
    "disabledPackages": [
      "linter-pylint"
    ]
  }
}

Installed Packages

# User
atom-django, v0.2.1
django-templates, v0.3.0
git-log, v0.3.0
linter, v0.11.1
linter-javac, v0.1.3
pdf-view, v0.17.0
seti-syntax, v0.3.3
tabs-to-spaces, v0.8.1
wakatime, v4.0.0

# Dev
No dev packages

Splitting a pane resets the location of the PDF

ctrl-k up/down/left/right causes the view to shift back to the top of the PDF. Small, but slightly problematic when viewing longer PDFs.

Atom.Object.defineProperty.get is deprecated.

Atom deprecation cop complains on use of atom.workspaceView, expects atom.views.getView(atom.workspace)`.

Provide a way to jump to a specific page

Uncaught EvalError: Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an al...

Steps:

1. Open a PDF file...

Atom Version: 1.0.5
System: Mac OS X 10.11
Thrown From: pdf-view package, v0.23.0

Stack Trace

Uncaught EvalError: Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self'".

At /Users/mathifonseca/.atom/packages/pdf-view/node_modules/pdfjs-dist/build/pdf.js:6589

EvalError: Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self'".

  at Function (native)
  at Object.FontLoader_getPathGenerator [as getPathGenerator] (/Users/mathifonseca/.atom/packages/pdf-view/node_modules/pdfjs-dist/build/pdf.js:6589:42)
  at Object.CanvasGraphics_paintChar [as paintChar] (/Users/mathifonseca/.atom/packages/pdf-view/node_modules/pdfjs-dist/build/pdf.js:4569:26)
  at Object.CanvasGraphics_showText [as showText] (/Users/mathifonseca/.atom/packages/pdf-view/node_modules/pdfjs-dist/build/pdf.js:4732:16)
  at Object.CanvasGraphics_executeOperatorList [as executeOperatorList] (/Users/mathifonseca/.atom/packages/pdf-view/node_modules/pdfjs-dist/build/pdf.js:4058:22)
  at Object.InternalRenderTask__next [as _next] (/Users/mathifonseca/.atom/packages/pdf-view/node_modules/pdfjs-dist/build/pdf.js:3209:39)

Commands

     -9:39.5.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -9:39.5.0 core:cancel (atom-text-editor.editor.is-focused)
     -9:39.3.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -9:39.3.0 core:cancel (atom-text-editor.editor.is-focused)
     -9:38.5.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -9:34.6.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -9:34.6.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -9:34.3.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -9:34.3.0 core:cancel (atom-text-editor.editor.is-focused)
     -9:24.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  4x -9:13.3.0 core:backspace (atom-text-editor.editor.mini.is-focused)
  2x -9:00.2.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -7:42.5.0 editor:delete-to-beginning-of-word (atom-text-editor.editor.mini.is-focused)
  2x -7:40.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -3:47.2.0 editor:delete-to-beginning-of-word (atom-text-editor.editor.mini.is-focused)
  2x -3:46.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ],
    "projectHome": "/Users/mathifonseca/code"
  }
}

Installed Packages

# User
atom-grails, v0.1.0
color-picker, v2.0.11
language-ansible, v0.1.3
language-apache, v1.3.0
language-groovy, v0.4.0
linter-ansible-lint, v0.0.7
minimap, v4.12.2
pdf-view, v0.23.0
pigments, v0.9.3
travis-ci-status, v0.16.0

# Dev
No dev packages

Needs basic tests

Would be 🆒 to have some basic tests to verify that PDFs are being rendered.

Uncaught Error: ENOENT: no such file or directory, open 'index.pdf'

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 0.190.0
System: Mac OS X 10.10.3
Thrown From: pdf-view package, v0.17.0

Stack Trace

Uncaught Error: ENOENT: no such file or directory, open 'index.pdf'

At fs.js:519

Error: ENOENT: no such file or directory, open 'index.pdf'
    at Error (native)
    at Object.fs.openSync (fs.js:544:18)
    at Object.module.(anonymous function) [as openSync] (ATOM_SHELL_ASAR.js:118:20)
    at Object.fs.readFileSync (fs.js:396:15)
    at Object.fs.readFileSync (ATOM_SHELL_ASAR.js:369:29)
    at PdfEditorView.module.exports.PdfEditorView.updatePdf (/Users/wanghaisheng/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:159:35)
    at PdfEditorView.module.exports.PdfEditorView.initialize (/Users/wanghaisheng/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:51:12)
    at PdfEditorView.View (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-space-pen-views/node_modules/space-pen/lib/space-pen.js:184:25)
    at PdfEditorView.ScrollView (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-space-pen-views/lib/scroll-view.js:12:47)
    at new PdfEditorView (/Users/wanghaisheng/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:26:50)

Commands

     -2:21.3 window:install-shell-commands (atom-text-editor.editor)
     -1:54.7 settings-view:install-packages-and-themes (atom-text-editor.editor)
     -1:45.9 core:confirm (atom-text-editor.editor.mini)

Config

{
  "core": {
    "followSymlinks": true,
    "themes": [
      "seti-ui",
      "solarized-light-syntax"
    ]
  }
}

Installed Packages

# User
pdf-view, v0.17.0
seti-ui, v0.6.3

# Dev
No dev packages

pdfs not rendered + error message from incompat. packages

From Incompatible Packages:

Listed below are the incompatible native modules that this package depends on.
[email protected]
Error message: Module version mismatch. Expected 16, got 14.
[email protected]
Error message: Module version mismatch. Expected 16, got 14.

I am running a atom directly from my locally cloned github repo of atom in Fedora 20. Your plugin worked before, I don't know what changed to make it not working, must be around Atom 0.16 or 0.17 when it stopped working.

Black blocks obscuring text in PDF files

I use pdf-view to render LaTeX files I compile in real time. I have recently come across what seems to be a bug in the rendering of the pages, which leads some of the text and formulas to be obscured by black boxes, similar to those that appear when selecting text in a normal PDF viewer.

This happens almost every time, but not always, and the part (and amount) of the text obscured varies for each time the file is opened. The obscured part is almost always at the bottom of the page.

I have had this problem on (at least) the following versions:

• Atom 0.190.0, 0.191.0 and 0.192.0 on Windows 8.1
• pdf-view 0.17.0 and 0.19.0

Below is the same part of the same file, along with the black boxes that appear. (The black edge at the bottom of the pictures is the separator between the pages.)

Remember zoom level and scroll position across sessions

Currently, if you quit and restart Atom, this package "forgets" the zoom level and scroll position for opened PDFs. It would be nice if it could remember that somehow.

Reduce loading time

The pdf-view package takes ~2 seconds to load, and another ~200ms to get activated. What if you require the PdfEditorView when you actually use it, instead of the top of the file?

Error rendering pdf on change if already opened

I have one problem with the plugin

Version: 0.13.0

When I have the pdf opened in a tab and then other tab builds the pdf, if I go back to the pdf tab it is completely distorted.

An example of the result can be seen in the image bellow.

https://www.dropbox.com/s/fr1ca6cge09vhel/Screenshot%202014-12-26%2012.30.48.png

Any ideas what might have broken it since last version?

Note: I'm generating the pdf from a latex file with thomasjo/atom-latex

Please bundle pdf.js

Could you please bundle pdf.js? We are behind a firewall and cloning from github fails:

Installing “[email protected]” failed.Hide output…
...
npm ERR! git clone git://github.com/mozilla/pdf.js.git github.com[0: 192.30.252.129]: errno=Operation timed out
npm ERR! Error: Command failed: Cloning into bare repository '/Users/laktak/.atom/.node-gyp/.atom/.apm/_git-remotes/git-github-com-mozilla-pdf-js-git-09e1fcd2'...
npm ERR! fatal: unable to connect to github.com:

Uncaught SyntaxError: /home/dylan/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^Unexpected token ILLEGAL

[Enter steps to reproduce below:]

1. ... Install pdf-view.
2. ... Try to open a pdf.

Atom Version: 0.174.0
System: linux 3.16.7.4-1-MANJARO
Thrown From: pdf-view package, v0.15.0

Stack Trace

Uncaught SyntaxError: /home/dylan/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26
PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unexpected token ILLEGAL

At /home/dylan/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26

/home/dylan/.atom/packages/pdf-view/node_modules/pdf.js/build/generic/build/pdf.js:26
PDFJS.build = 'fatal: Not a git repository (or any parent up to mount point /t
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Unexpected token ILLEGAL
  at exports.runInThisContext (vm.js:73:16)
  at Module._compile (module.js:451:25)
  at Object.Module._extensions..js (module.js:486:10)
  at Module.load (/usr/share/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:318:12)
  at Module.require (module.js:373:17)
  at require (module.js:392:17)
  at Object.<anonymous> (/home/dylan/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:4:1)
  at Object.<anonymous> (/home/dylan/.atom/packages/pdf-view/lib/pdf-editor-view.coffee:1:1)
  at Module._compile (module.js:468:26)
  at Object.requireCoffeeScript [as .coffee] (/usr/share/atom/resources/app/src/coffee-cache.js:65:19)
  at Module.load (/usr/share/atom/resources/app/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
  at Function.Module._load (module.js:318:12)
  at Module.require (module.js:373:17)
  at require (module.js:392:17)
  at openUri (/home/dylan/.atom/packages/pdf-view/lib/pdf-editor.coffee:18:22)
  at wrappedOpener (/usr/share/atom/resources/app/src/workspace.js:562:16)
  at Workspace.module.exports.Workspace.openURIInPane (/usr/share/atom/resources/app/src/workspace.js:485:22)
  at Workspace.module.exports.Workspace.open (/usr/share/atom/resources/app/src/workspace.js:418:19)
  at TreeView.module.exports.TreeView.openSelectedEntry (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:639:31)
  at TreeView.module.exports.TreeView.entryClicked (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:383:18)
  at tree-view-file.<anonymous> (/usr/share/atom/resources/app/node_modules/tree-view/lib/tree-view.js:171:26)
  at space-pen-div.jQuery.event.dispatch (/usr/share/atom/resources/app/node_modules/tree-view/node_modules/atom-space-pen-views/node_modules/space-pen/vendor/jquery.js:4676:9)
  at space-pen-div.elemData.handle (/usr/share/atom/resources/app/node_modules/tree-view/node_modules/atom-space-pen-views/node_modules/space-pen/vendor/jquery.js:4360:46)

Commands

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "seti-syntax"
    ],
    "autoHideMenuBar": false
  }
}

Installed Packages

# User
autocomplete-plus, v1.1.0
language-latex, v0.4.1
language-rust, v0.3.4
language-x86, v0.1.0
minimap, v3.5.5
pdf-view, v0.15.0
seti-syntax, v0.2.1

# Dev
No dev packages

/cc @atom/core

installing failed

i tried installing your packages but i always seem to get an error.
here the install log:

> [email protected] install C:\..[ my install location ]..\AppData\Local\Temp\apm-install-dir-114103-2704-a6jp77\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas
> node-gyp rebuild


C:\..[ my install location ]..\AppData\Local\Temp\apm-install-dir-114103-2704-a6jp77\node_modules\pdf-view\node_modules\pathwatcher\node_modules\runas>node "c:\ProgramData\chocolatey\lib\Atom.0.141.0\tools\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild 

npm http GET https://registry.npmjs.org/fs-plus
npm http GET https://registry.npmjs.org/pathwatcher
npm http 304 https://registry.npmjs.org/fs-plus
npm http 200 https://registry.npmjs.org/pathwatcher
npm http GET https://registry.npmjs.org/pathwatcher/-/pathwatcher-2.3.2.tgz
npm http 200 https://registry.npmjs.org/pathwatcher/-/pathwatcher-2.3.2.tgz
npm WARN `git config --get remote.origin.url` returned wrong result (https://github.com/mozilla/pdf.js.git) 
npm http GET https://registry.npmjs.org/underscore-plus
npm http GET https://registry.npmjs.org/rimraf
npm http GET https://registry.npmjs.org/mkdirp
npm http GET https://registry.npmjs.org/async
npm http GET https://registry.npmjs.org/emissary
npm http GET https://registry.npmjs.org/async
npm http GET https://registry.npmjs.org/grim
npm http GET https://registry.npmjs.org/iconv-lite
npm http GET https://registry.npmjs.org/event-kit
npm http GET https://registry.npmjs.org/nan/1.2.0
npm http GET https://registry.npmjs.org/q
npm http GET https://registry.npmjs.org/runas
npm http GET https://registry.npmjs.org/underscore-plus
npm http 200 https://registry.npmjs.org/mkdirp
npm http GET https://registry.npmjs.org/mkdirp/-/mkdirp-0.3.5.tgz
npm http 200 https://registry.npmjs.org/rimraf
npm http GET https://registry.npmjs.org/rimraf/-/rimraf-2.2.8.tgz
npm http 200 https://registry.npmjs.org/underscore-plus
npm http GET https://registry.npmjs.org/underscore-plus/-/underscore-plus-1.6.1.tgz
npm http 200 https://registry.npmjs.org/grim
npm http GET https://registry.npmjs.org/grim/-/grim-0.12.0.tgz
npm http 200 https://registry.npmjs.org/mkdirp/-/mkdirp-0.3.5.tgz
npm http 200 https://registry.npmjs.org/emissary
npm http 200 https://registry.npmjs.org/event-kit
npm http GET https://registry.npmjs.org/emissary/-/emissary-1.3.1.tgz
npm http GET https://registry.npmjs.org/event-kit/-/event-kit-0.6.0.tgz
npm http 200 https://registry.npmjs.org/iconv-lite
npm http GET https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.4.4.tgz
npm http 200 https://registry.npmjs.org/underscore-plus/-/underscore-plus-1.6.1.tgz
npm http 200 https://registry.npmjs.org/rimraf/-/rimraf-2.2.8.tgz
npm http 200 https://registry.npmjs.org/nan/1.2.0
npm http GET https://registry.npmjs.org/nan/-/nan-1.2.0.tgz
npm http 200 https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.4.4.tgz
npm http 200 https://registry.npmjs.org/grim/-/grim-0.12.0.tgz
npm http 200 https://registry.npmjs.org/runas
npm http 200 https://registry.npmjs.org/async
npm http GET https://registry.npmjs.org/runas/-/runas-1.0.1.tgz
npm http GET https://registry.npmjs.org/async/-/async-0.2.10.tgz
npm http 200 https://registry.npmjs.org/underscore-plus
npm http 200 https://registry.npmjs.org/async
npm http 200 https://registry.npmjs.org/event-kit/-/event-kit-0.6.0.tgz
npm http 200 https://registry.npmjs.org/emissary/-/emissary-1.3.1.tgz
npm http 200 https://registry.npmjs.org/async/-/async-0.2.10.tgz
npm http 200 https://registry.npmjs.org/runas/-/runas-1.0.1.tgz
npm http 200 https://registry.npmjs.org/nan/-/nan-1.2.0.tgz
npm http 200 https://registry.npmjs.org/q
npm http GET https://registry.npmjs.org/underscore
npm http GET https://registry.npmjs.org/q/-/q-1.0.1.tgz
npm http 200 https://registry.npmjs.org/underscore
npm http 200 https://registry.npmjs.org/q/-/q-1.0.1.tgz
npm http GET https://registry.npmjs.org/underscore/-/underscore-1.6.0.tgz
npm http 200 https://registry.npmjs.org/underscore/-/underscore-1.6.0.tgz
gypnpm http GET https://registry.npmjs.org/mixto
npm http GET https://registry.npmjs.org/property-accessors
npm http 200 https://registry.npmjs.org/property-accessors
npm http 200 https://registry.npmjs.org/mixto
npm http GET https://registry.npmjs.org/property-accessors/-/property-accessors-1.1.0.tgz
npm http GET https://registry.npmjs.org/mixto/-/mixto-1.0.0.tgz
npm http 200 https://registry.npmjs.org/mixto/-/mixto-1.0.0.tgz
npm http 200 https://registry.npmjs.org/property-accessors/-/property-accessors-1.1.0.tgz
npm ERR! Error: ENOENT, lstat 'C:\..[ my install location ]..\AppData\Local\Temp\apm-install-dir-114103-2704-a6jp77\node_modules\pdf-view\node_modules\pdf.js\l10n\en-US\viewer.properties'
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! System Windows_NT 6.2.9200
npm ERR! command "c:\\ProgramData\\chocolatey\\lib\\Atom.0.141.0\\tools\\Atom\\resources\\app\\apm\\node_modules\\atom-package-manager\\bin\\\\node.exe" "c:\\ProgramData\\chocolatey\\lib\\Atom.0.141.0\\tools\\Atom\\resources\\app\\apm\\node_modules\\atom-package-manager\\node_modules\\npm\\bin\\npm-cli.js" "--globalconfig" "c:\\ProgramData\\chocolatey\\lib\\Atom.0.141.0\\tools\\Atom\\resources\\app\\apm\\node_modules\\atom-package-manager\\.apmrc" "--userconfig" "C:\\..[ my install location ]..\\.atom\\.apmrc" "install" "C:\\..[ my install location ]..\\.atom\\.node-gyp\\.atom\\.apm\\pdf-view\\0.12.0\\package.tgz" "--target=0.18.0" "--arch=ia32" "--msvs_version=2013"
npm ERR! cwd C:\..[ my install location ]..\AppData\Local\Temp\apm-install-dir-114103-2704-a6jp77
npm ERR! node -v v0.10.32
npm ERR! npm -v 1.4.4
npm ERR! path C:\..[ my install location ]..\AppData\Local\Temp\apm-install-dir-114103-2704-a6jp77\node_modules\pdf-view\node_modules\pdf.js\l10n\en-US\viewer.properties
npm ERR! fstream_path C:\..[ my install location ]..\AppData\Local\Temp\apm-install-dir-114103-2704-a6jp77\node_modules\pdf-view\node_modules\pdf.js\l10n\en-US\viewer.properties
npm ERR! fstream_type File
npm ERR! fstream_class FileWriter
npm ERR! code ENOENT
npm ERR! errno 34
npm ERR! fstream_stack c:\ProgramData\chocolatey\lib\Atom.0.141.0\tools\Atom\resources\app\apm\node_modules\atom-package-manager\node_modules\npm\node_modules\fstream\lib\writer.js:284:26
npm ERR! fstream_stack Object.oncomplete (fs.js:107:15)
npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script.
npm ERR! This is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls runas
npm ERR! There is likely additional logging output above.

npm ERR! System Windows_NT 6.2.9200
npm ERR! command "c:\\ProgramData\\chocolatey\\lib\\Atom.0.141.0\\tools\\Atom\\resources\\app\\apm\\node_modules\\atom-package-manager\\bin\\\\node.exe" "c:\\ProgramData\\chocolatey\\lib\\Atom.0.141.0\\tools\\Atom\\resources\\app\\apm\\node_modules\\atom-package-manager\\node_modules\\npm\\bin\\npm-cli.js" "--globalconfig" "c:\\ProgramData\\chocolatey\\lib\\Atom.0.141.0\\tools\\Atom\\resources\\app\\apm\\node_modules\\atom-package-manager\\.apmrc" "--userconfig" "C:\\..[ my install location ]..\\.atom\\.apmrc" "install" "C:\\..[ my install location ]..\\.atom\\.node-gyp\\.atom\\.apm\\pdf-view\\0.12.0\\package.tgz" "--target=0.18.0" "--arch=ia32" "--msvs_version=2013"
npm ERR! cwd C:\..[ my install location ]..\AppData\Local\Temp\apm-install-dir-114103-2704-a6jp77
npm ERR! node -v v0.10.32
npm ERR! npm -v 1.4.4
npm ERR! code ELIFECYCLE
npm

Cannot install [email protected] in atom 0.177.0

The error message is below.

Installing “[email protected]” failed.Hide output…

[email protected] install /private/var/folders/kc/x4127j9s7zq226f9yfsjqn_h0000gp/T/apm-install-dir-11516-17903-spds63/node_modules/pdf-view/node_modules/pathwatcher/node_modules/runas
node-gyp rebuild

CXX(target) Release/obj.target/runas/src/main.o

In file included from ../src/main.cc:1:
../../nan/nan.h:623:19: error: no type named 'ExternalAsciiStringResource' in 'v8::String'; did you mean 'ExternalStringResource'?
v8::String::ExternalAsciiStringResource resource) {
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
ExternalStringResource
/Users/wuyangjack/.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:1936:19: note: 'ExternalStringResource' declared here
class V8_EXPORT ExternalStringResource
^
In file included from ../src/main.cc:1:
../../nan/nan.h:622:36: error: redefinition of 'NanNew'
NAN_INLINE v8::Localv8::String NanNew(
^
../../nan/nan.h:617:36: note: previous definition is here
NAN_INLINE v8::Localv8::String NanNew(
^
../../nan/nan.h:1993:12: error: no member named 'IsExternalAscii' in 'v8::String'; did you mean 'IsExternal'?
if (str->IsExternalAscii()) {
^~~~~~~~~~~~~~~
IsExternal
/Users/wuyangjack/.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:1900:8: note: 'IsExternal' declared here
bool IsExternal() const;
^
In file included from ../src/main.cc:1:
../../nan/nan.h:1994:23: error: no type named 'ExternalAsciiStringResource' in 'v8::String'; did you mean 'ExternalStringResource'?
const v8::String::ExternalAsciiStringResource ext;
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
ExternalStringResource
/Users/wuyangjack/.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:1936:19: note: 'ExternalStringResource' declared here
class V8_EXPORT ExternalStringResource
^
In file included from ../src/main.cc:1:
../../nan/nan.h:1995:16: error: no member named 'GetExternalAsciiStringResource' in 'v8::String'; did you mean 'GetExternalOneByteStringResource'?
ext = str->GetExternalAsciiStringResource();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GetExternalOneByteStringResource
/Users/wuyangjack/.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:2003:40: note: 'GetExternalOneByteStringResource' declared here
const ExternalOneByteStringResource* GetExternalOneByteStringResource() const;
^
In file included from ../src/main.cc:1:
../../nan/nan.h:1995:9: error: assigning to 'const v8::String::ExternalStringResource ' from incompatible type 'const v8::String::ExternalOneByteStringResource *'
ext = str->GetExternalAsciiStringResource();
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:1996:11: error: assigning to 'const char *' from incompatible type 'const uint16_t *' (aka 'const unsigned short *')
*data = ext->data();
^ ~~~~~~~~~~~
7 errors generated.
make: ** [Release/obj.target/runas/src/main.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack at ChildProcess.emit (events.js:98:17)
gyp ERR! stack at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.0.0
gyp ERR! command "node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /private/var/folders/kc/x4127j9s7zq226f9yfsjqn_h0000gp/T/apm-install-dir-11516-17903-spds63/node_modules/pdf-view/node_modules/pathwatcher/node_modules/runas
gyp ERR! node -v v0.10.35
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok
npm ERR! Darwin 14.0.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Applications/Atom.app/Contents/Resources/app/apm/.apmrc" "--userconfig" "/Users/wuyangjack/.atom/.apmrc" "install" "/private/var/folders/kc/x4127j9s7zq226f9yfsjqn_h0000gp/T/d-11516-17903-8oddll/package.tgz" "--target=0.21.0" "--arch=x64"
npm ERR! node v0.10.35
npm ERR! npm v2.3.0
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild
npm ERR! You can get their info via:
npm ERR! npm owner ls runas
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /private/var/folders/kc/x4127j9s7zq226f9yfsjqn_h0000gp/T/apm-install-dir-11516-17903-spds63/npm-debug.log