TCK Challenge: Cookie setMaxAgePositiveTest using incorrect CookiePolicy for Date parsing

[brideck]

TCK Challenge: Cookie setMaxAgePositiveTest using incorrect CookiePolicy for Date parsing

[markt-asf]

I agree that that date should be acceptable. That it isn't makes this challenge valid.
I am wondering how containers have passed the TCK. Something to look into but doesn't impact the status of this challenge.

[brideck]

I suspect that implementations might have some sort of compatibility setting. We certainly do, and have used it in the past, but it runs afoul of the 2-digit vs 4-digit year format that we discussed in the previous challenge. I would much prefer that this just work without such a setting, which, for us, is the format you see here.

[scottmarlow]

Sounds like we should exclude the test.
A pull request is needed to update https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/servlet/bin/ts.jtx + https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/install/jakartaee/bin/ts.jtx to do the exclude and once merged, should be back ported to 10.0.x branch so we can stage the Servlet + Platform TCKs.

We should validate that the excluded tests don't run with the change and then do a service release of the two TCKs.

[scottmarlow]

@brideck please do attach the two jtr files for the identified tests.

[scottmarlow]

From my local testing:

#-----testdescription-----
$file=jakartaeetck/src/com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet_http/cookie/URLClient.java
$root=jakartaeetck/src
assertion_ids=Servlet\:JAVADOC\:440  See assertion html documents.
classname=com.sun.ts.tests.servlet.pluggability.api.jakarta_servlet_http.cookie.URLClient
direction=forward
finder=cts
id=setMaxAgePositiveTest
keywords=all servlet javaee javaee_web_profile setMaxAgePositiveTest novehicle forward
service_eetest=no
testName=setMaxAgePositiveTest
testProps=\ webServerHost  webServerPort  ts_home
test_directory=com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet_http/cookie

#-----testdescription-----
$file=jakartaeetck/src/com/sun/ts/tests/servlet/api/jakarta_servlet_http/cookie/URLClient.java
$root=jakartaeetck/src
assertion_ids=Servlet\:JAVADOC\:440  See assertion html documents.
classname=com.sun.ts.tests.servlet.api.jakarta_servlet_http.cookie.URLClient
direction=forward
finder=cts
id=setMaxAgePositiveTest
keywords=all servlet javaee javaee_web_profile setMaxAgePositiveTest novehicle forward
service_eetest=no
testName=setMaxAgePositiveTest
testProps=\ webServerHost  webServerPort  ts_home
test_directory=com/sun/ts/tests/servlet/api/jakarta_servlet_http/cookie

Exclude for Platform TCK ts.jtx should be:

com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet_http/cookie/URLClient.java#setMaxAgePositiveTest
com/sun/ts/tests/servlet/api/jakarta_servlet_http/cookie/URLClient.java#setMaxAgePositiveTest

[scottmarlow]

https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-standalonetck-build-run-100/lastCompletedBuild/ passed with https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-servlet-tck-6.0.1.zip for this challenge (using https://download.eclipse.org/ee4j/glassfish/glassfish-7.0.0-M9.zip).

https://ci.eclipse.org/jakartaee-tck/job/10/job/eftl-jakartaeetck-run-100/153 passed using https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/staged/eftl/jakarta-jakartaeetck-10.0.1.zip + https://download.eclipse.org/ee4j/glassfish/glassfish-7.0.0-M9.zip.

[scottmarlow]

I think that this issue can be closed since jakartaee/specifications#579 is merged and the challenged TCK tests excluded from https://download.eclipse.org/jakartaee/servlet/6.0/jakarta-servlet-tck-6.0.1.zip + https://download.eclipse.org/jakartaee/platform/10/jakarta-jakartaeetck-10.0.1.zip

[markt-asf]

Closing this issue as this has been addressed in the refactored TCK for Servlet 6.1. Tomcat uses the Wed, 12 Oct 2022 15:18:45 GMT format and passes the TCK.