Comments (7)
I removed the TCK challenge prefix since no TCK test was referenced in issue description.
I think the code is correct and the Javadoc needs to be updated. That would make the behaviour consistent with an implementation that did not implement trailer fields. isTrailerFieldsReady()
would return true
and a subsequent call to getTrailerFields()
would return an empty Map.
from servlet.
@markt-asf I am asserting this is a valid TCK challenge. For the TCK test in question,
see https://github.com/eclipse-ee4j/jakartaee-tck/blob/da6a34066dd04a78e6b1656c923c9c5de97af182/src/com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpservletrequest40/Client.java#L295 for the failing TCK test
This is a valid TCK challenge so this test needs to be excluded because it fails on a spec / JavaDoc compliant implementation. Now for the next Servlet release this should be fixed in the JavaDoc and the test should be re-enabled. And then as part of the next Servlet release this should be called out as an incompatibility.
from servlet.
I don't understand how this is failing since the rest of the Javadoc for that method describes how the method is expected to behave and it is this behaviour that the TCK test is testing. I don't see anything in the TCK that explicitly tests the default.
Further, I have run that TCK test on Tomcat 10.1.x with the default as both true
and false
and the test passes (as expected since a spec compliant implementation is going to have to override the method anyway).
I am currently leaning towards rejecting this challenge.
from servlet.
Again, if any implementation out there is implementing according to the specification or JavaDoc the default behavior requires to return false. You are saying that Tomcat 10.1.x passes this test. This simply means that your implementation is NOT using the as per JavaDoc prescribed default code path as any part of your implementation. It does not mean that the TCK challenge does not exist.
from servlet.
Which version of which container using which Servlet API JAR fails this TCK test?
from servlet.
Absent a report of a container using the Servlet API JAR provided by this project failing the TCK test, this issue will be treated as a Javadoc bug and not as a TCK challenge. Given that the TCK doesn't test the default return value, I am struggling to see how this can be a valid challenge.
from servlet.
No information provided on a container failing the specified test. I've removed the challenge label and am resolving this bug as fixed.
from servlet.
Related Issues (20)
- TCK: Need to add the signature tests HOT 1
- jakarta.servlet-api.jar MANIFEST.MF contains path to builder's current directory HOT 6
- Need to update schema for 6.1.0 release HOT 1
- Servlet 6.1.0 - Tomcat 11.0.0-M19-SNAPSHOT certification request HOT 1
- New home for HttpServletRequest injection requirements
- tests should not be in the jakarta package HOT 6
- ServletResponse.setCharacterEncoding(CharSet encoding) throws NullPointerException if encoding is null
- Blocker for starting EE 11 ballot: TCK user guide, and two folders with a tck-runtime.jar and a tck-utils.jar. I guess an assembly file is needed to create a zip file with those two artefacts, and then we have to add a basic user guide still. HOT 1
- Servlet 6.1.0 - Tomcat 11.0.0-M20 certification request HOT 5
- ServletSecTestServlet imports org.slf4j.Logger but test war doesn't include sl4j HOT 6
- Servlet 6.1.0 - Tomcat 11.0.0-M20 certification request HOT 3
- Finalize the release of Jakarta Servlet 6.1 HOT 8
- Circular dependency between AttributeConverter and JPA HOT 1
- TCK for Servlet 6.1 invalid error code in servlet.tck.api.jakarta_servlet_http.httpservletresponse HOT 2
- TCK for servlet 6.1 servlet/tck/spec/serverpush /ServerPushTests#serverPushCookieTest HOT 1
- Clarify behaviour for container managed HTTP headers HOT 1
- addLinkHeader HOT 1
- Version javax.servlet-api 4.0.1 still can be used HOT 1
- TCK coverage missing for attribute elements of cookie-config introduced since web-common_6_0.xsd
- Should the new Servlet 6.1 `jakarta.servlet.error.method` attribute be added to `Table 10-1 Request Attributes and their types`? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from servlet.