jaliborc/bagbrother

Shared services and codebase between Bagnon and Bagnonium

Welcome!

I'm the author of addons like Bagnon, Scrap and PetTracker. If you're here because of something else and don't know what that means, don't worry about it 😉, just dodge the MMO gamers, I won't tell 🙈.

About Me

🎮 I've been a gamer and software developer for two decates now. My professsional journey started quite unexpectedly when I was just 12 years old, and created some of the most popular third-party software for World of Warcraft.

🎓 On the academic front, I hold a PhD in computer graphics and machine learning. My research has primarily focused on developing learning-based solutions to computer graphics problems, such as optimizing rendering performance and enhancing skin simulation, or improving hand-drawn animation.

bagbrother's Issues

Searching cached Bank window returns bad results and GetItemLink errors

Running Software (issues missing this information will be deleted):

• Addon version: 10.0.14
• Server patch: 10.0.2.47213

Have you read the changelog? (please don't waste our time)
Yes

Describe the bug
When searching the cached Bank frame, all items in bags (outside the default first bank bag) are highlighted. Search functions normally while at a banker.

To Reproduce
Steps to reproduce the behaviour:

1. Open cached Bank window with /bgn bank
2. Search for something
3. See almost all items highlighted, "GetItemLink" errors
4. Repeating the search in a banker window works as expected without errors

Expected behaviour
Only items matching the search should be highlighted.

Screenshots
Searching in cached Bank window (224 items highlighted)

Searching at actual banker window (4 items highlighted)

Error Logs

10x bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation))
[string "=[C]"]: in function `GetItemLink'
[string "@BagBrother/libs/ItemSearch-1.3-1/API.lua"]:40: in function `Matches'
[string "@BagBrother/addons/core/classes/item.lua"]:296: in function `UpdateSearch'
[string "@BagBrother/addons/core/classes/item.lua"]:214: in function `func'
[string "@BagBrother/libs/MutexDelay-1.0-2/MutexDelay-1.0.lua"]:36: in function <...ns/BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua:30>

Locals:
(*temporary) = "bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation))"

BattlePetTooltip

Which software were you running?

• Addon version name: Bagnon-10.2.15.zip
• Client used: [e.g. Vanilla 1.14.4, Retail PTR x.x.x, etc] Retail

Have you read the changelog?
Yes

Please describe the bug.
i l ogged in, error pop , pet in the bag caged

Any Screenshots?
If applicable, please add screenshots to help explain your problem.

Error Logs are Important!
Type /console scriptErrors 1 in the chat and reload the game. If an error window appears when reproducing the bug, please write here the first message (labelled 1/Many) that appeared. ⚠️ By default, the last error message is shown, not the first! You need to navigate back to the first error

60x BattlePetTooltip:SetPoint(): Usage: ("point" [, region or nil] [, "relativePoint"] [, offsetX, offsetY]
[string "=[C]"]: in function `SetPoint'
[string "@FrameXML/BattlePetTooltip.lua"]:53: in function <FrameXML/BattlePetTooltip.lua:23>
[string "=[C]"]: ?
[string "=[C]"]: in function `BattlePetToolTip_Show'
[string "@SharedXML/Tooltip/TooltipDataRules.lua"]:270: in function `func'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:151: in function <SharedXML/Tooltip/TooltipDataHandler.lua:146>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:173: in function <SharedXML/Tooltip/TooltipDataHandler.lua:169>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:225: in function <SharedXML/Tooltip/TooltipDataHandler.lua:224>
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:375: in function <SharedXML/Tooltip/TooltipDataHandler.lua:339>
[string "=[C]"]: in function `securecallfunction'
[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:336: in function <SharedXML/Tooltip/TooltipDataHandler.lua:335>
[string "=(tail call)"]: ?
...
[string "@BagBrother/core/classes/itemGroup.lua"]:32: in function `Update'
[string "@BagBrother/core/classes/itemGroup.lua"]:26: in function <BagBrother/core/classes/itemGroup.lua:12>
[string "=(tail call)"]: ?
[string "@Bagnon/src/frame.lua"]:24: in function `New'
[string "@BagBrother/core/api/frames.lua"]:83: in function `New'
[string "@BagBrother/core/core.lua"]:42: in function <BagBrother/core/core.lua:42>
[string "=[C]"]: ?
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@Ace3/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <Ace3/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals:
(*temporary) = BattlePetTooltip {
 0 = <userdata>
 linePool = <table> {
 }
 Owned = FontString {
 }
 layoutType = "TooltipDefaultLayout"
 AddLine = <function> defined @FrameXML/FloatingPetBattleTooltip.lua:124
 GetBackdropColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:294
 SpeedTexture = Texture {
 }
 SetBackdropBorderColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:298
 HealthTexture = Texture {
 }
 PowerTexture = Texture {
 }
 speciesID = 3382
 PetType = FontString {
 }
 Power = FontString {
 }
 Speed = FontString {
 }
 TooltipBackdropOnLoad = <function> defined @SharedXML/SharedTooltipTemplates.lua:275
 SetBorderBlendMode = <function> defined @SharedXML/SharedTooltipTemplates.lua:306
 PetTypeTexture = Texture {
 }
 GetBackdropBorderColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:302
 Name = FontString {
 }
 Health = FontString {
 }
 NineSlice = Frame {
 }
 SetBackdropColor = <function> defined @SharedXML/SharedTooltipTemplates.lua:290
 Level = FontString {
 }
 BattlePet = FontString {
 }
}

```.

Problem opening bags after pulling in latest changes

Which software were you running?

• Addon version name: BagBrother
• Client used: Vanilla 1.14.4.51311

Have you read the changelog?
Yes

Please describe the bug.
When logging in, I get the following LUA error popup (I have enabled them):

Please describe how to reproduce it.
After logging in, I can no longer open my bags.
It seems linked to the error log below.
Probably introduced by following commit:
a72c274
The error seems to be linked to Addon.CurrencyLimit

Any Screenshots?
If applicable, please add screenshots to help explain your problem.

Error Logs are Important!
Message: ...nterface/AddOns/BagBrother/core/features/caching.lua:113: 'for' limit must be a number
Time: Tue Sep 12 19:05:55 2023
Count: 1
Stack: ...nterface/AddOns/BagBrother/core/features/caching.lua:113: 'for' limit must be a number
[string "@Interface/AddOns/BagBrother/core/features/caching.lua"]:113: in function CURRENCY_TRACKED_CHANGED' [string "@Interface/AddOns/BagBrother/core/features/caching.lua"]:80: in function ?'
[string "@Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua"]:20: in function <...dOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:18>
[string "@Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua"]:56: in function <...dOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:53>
[string "=[C]"]: ?
[string "@Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...las/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function Fire' [string "@Interface/AddOns/BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua:119> [string "=[C]"]: in function LoadAddOn'
[string "@Interface_Vanilla/FrameXML/UIParent.lua"]:388: in function UIParentLoadAddOn' [string "@Interface_Vanilla/FrameXML/UIParent.lua"]:459: in function TimeManager_LoadUI'
[string "@Interface_Vanilla/FrameXML/UIParent.lua"]:717: in function <Interface_Vanilla/FrameXML/UIParent.lua:686>

Locals: self =

{
SendSignal = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:82
ParseItem = defined @Interface/AddOns/BagBrother/core/features/caching.lua:215
RegisterMessage = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:80
UnregisterMessage = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:143
isBankFrameOpen = false
player = {
}
SaveBag = defined @Interface/AddOns/BagBrother/core/features/caching.lua:186
PLAYER_EQUIPMENT_CHANGED = defined @Interface/AddOns/BagBrother/core/features/caching.lua:94
BANK_OPEN = defined @Interface/AddOns/BagBrother/core/features/caching.lua:124
SaveEquip = defined @Interface/AddOns/BagBrother/core/features/caching.lua:211
SendMessage = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:49
GUILDBANKBAGSLOTS_CHANGED = defined @Interface/AddOns/BagBrother/core/features/caching.lua:160
UnregisterAllEvents = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:164
UnregisterSignal = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:78
VAULT_CLOSE = defined @Interface/AddOns/BagBrother/core/features/caching.lua:147
PLAYER_MONEY = defined @Interface/AddOns/BagBrother/core/features/caching.lua:102
BANK_CLOSE = defined @Interface/AddOns/BagBrother/core/features/caching.lua:128
RegisterEvent = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:80
UnregisterAllMessages = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:164
CURRENCY_TRACKED_CHANGED = defined @Interface/AddOns/BagBrother/core/features/caching.lua:110
NewModule = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:68
PLAYER_LEVEL_UP = defined @Interface/AddOns/BagBrother/core/features/caching.lua:98
OnEnable = defined @Interface/AddOns/BagBrother/core/features/caching.lua:20
BAG_UPDATE = defined @Interface/AddOns/BagBrother/core/features/caching.lua:88
RegisterSignal = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:74
CURRENCY_DISPLAY_UPDATE = defined @Interface/AddOns/B

Message: ...nterface/AddOns/BagBrother/core/features/caching.lua:107: attempt to compare number with nil
Time: Tue Sep 12 19:05:56 2023
Count: 1
Stack: ...nterface/AddOns/BagBrother/core/features/caching.lua:107: attempt to compare number with nil
[string "@Interface/AddOns/BagBrother/core/features/caching.lua"]:107: in function ?' [string "@Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:109: in function <...las/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:109> [string "=[C]"]: ? [string "@Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...las/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function Fire'
[string "@Interface/AddOns/BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/BagBrother/libs/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals: self =

{
SendSignal = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:82
ParseItem = defined @Interface/AddOns/BagBrother/core/features/caching.lua:215
RegisterMessage = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:80
UnregisterMessage = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:143
isBankFrameOpen = false
player = {
}
SaveBag = defined @Interface/AddOns/BagBrother/core/features/caching.lua:186
PLAYER_EQUIPMENT_CHANGED = defined @Interface/AddOns/BagBrother/core/features/caching.lua:94
BANK_OPEN = defined @Interface/AddOns/BagBrother/core/features/caching.lua:124
SaveEquip = defined @Interface/AddOns/BagBrother/core/features/caching.lua:211
SendMessage = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:49
GUILDBANKBAGSLOTS_CHANGED = defined @Interface/AddOns/BagBrother/core/features/caching.lua:160
UnregisterAllEvents = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:164
UnregisterSignal = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:78
VAULT_CLOSE = defined @Interface/AddOns/BagBrother/core/features/caching.lua:147
PLAYER_MONEY = defined @Interface/AddOns/BagBrother/core/features/caching.lua:102
BANK_CLOSE = defined @Interface/AddOns/BagBrother/core/features/caching.lua:128
RegisterEvent = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:80
UnregisterAllMessages = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:164
CURRENCY_TRACKED_CHANGED = defined @Interface/AddOns/BagBrother/core/features/caching.lua:110
NewModule = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:68
PLAYER_LEVEL_UP = defined @Interface/AddOns/BagBrother/core/features/caching.lua:98
OnEnable = defined @Interface/AddOns/BagBrother/core/features/caching.lua:20
BAG_UPDATE = defined @Interface/AddOns/BagBrother/core/features/caching.lua:88
RegisterSignal = defined @Interface/AddOns/BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:74
CURRENCY_DISPLAY_UPDATE = defined @Interface/AddOns/BagBrother/core/features/caching.lua:106
GUILD_ROSTER_UPDATE = defined @Interface/AddOns/BagBrother/core/features/caching.lua:156
UnregisterEvent = defined @Interface/AddOns/Atlas/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:143
Tag = "BAGNON_"
}
_ = "CURRENCY_DISPLAY_UPDATE"
id = nil
quantity = nil
(*temporary) = {
tracked = {
}
}
(*temporary) = nil
(*temporary) = "attempt to compare number with nil"

empty icons for allied race in bagnon

When i click on char selection @ bags there is no icon for some allied races in char list.
For zandalar, high mountain tauren

bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation))

Searching bank item window, opened away from a bank. filter does not seem to narrow at all

28x bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation))
[string "=[C]"]: in function `GetItemLink'
[string "@BagBrother/libs/ItemSearch-1.3-1/API.lua"]:40: in function `Matches'
[string "@BagBrother/addons/core/classes/item.lua"]:296: in function `?'
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:114: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:114>
[string "=[C]"]: ?
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:24: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:20>
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:59: in function `SendMessage'
[string "@BagBrother/libs/WildAddon-1.0-1/WildAddon-1.0.lua"]:83: in function `SendSignal'
[string "@Bagnon/src/title.lua"]:56: in function <Bagnon/src/title.lua:54>

Not working

A week ago or two, the addon just stopped working. I have deleted the data in the WTF folder to make sure that nothing had got corrupted or so.
I dont know what could be wrong, but I am willing to test stuff if it would help.
I am playing wow classic.

lua error

7x BagBrother/core/classes/itemGroup.lua:71: attempt to index field 'Flash' (a nil value)
[string "@BagBrother/core/classes/itemGroup.lua"]:71: in function `?'
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:114: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:114>
[string "=[C]"]: ?
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:24: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:20>
[string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:59: in function `SendMessage'
[string "@BagBrother/libs/WildAddon-1.0-1/WildAddon-1.0.lua"]:83: in function `SendSignal'
[string "@BagBrother/core/classes/item.lua"]:114: in function <BagBrother/core/classes/item.lua:112>
[string "=(tail call)"]: ?
[string "@BagBrother/frames/containers/item.lua"]:46: in function <BagBrother/frames/containers/item.lua:45>
[string "=[C]"]: ?

Locals:
self = Frame {
 0 = <userdata>
 buttons = <table> {
 }
 order = <table> {
 }
 frame = BagnonInventory1 {
 }
 bags = <table> {
 }
}
_ = "BAGNON_FLASH_ITEM"
itemID = 204335
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 1 = BagnonContainerItem1 {
 }
 2 = BagnonContainerItem2 {
 }
 3 = BagnonContainerItem3 {
 }
 4 = BagnonContainerItem4 {
 }
 5 = BagnonContainerItem5 {
 }
 6 = BagnonContainerItem6 {
 }
 7 = BagnonContainerItem7 {
 }
 8 = BagnonContainerItem8 {
 }
 9 = BagnonContainerItem9 {
 }
 10 = BagnonContainerItem10 {
 }
 11 = BagnonContainerItem11 {
 }
 12 = BagnonContainerItem12 {
 }
 13 = BagnonContainerItem13 {
 }
 14 = BagnonContainerItem14 {
 }
 15 = BagnonContainerItem15 {
 }
 16 = BagnonContainerItem16 {
 }
 17 = BagnonContainerItem17 {
 }
 18 = BagnonContainerItem18 {
 }
 19 = BagnonContainerItem19 {
 }
 20 = BagnonContainerItem20 {
 }
 21 = BagnonContainerItem21 {
 }
 22 = BagnonContainerItem22 {
 }
 23 = BagnonContainerItem23 {
 }
 24 = BagnonContainerItem24 {
 }
 25 = BagnonContainerItem25 {
 }
 26 = BagnonContainerItem26 {
 }
 27 = BagnonContainerItem27 {
 }
 28 = BagnonContainerItem28 {
 }
 29 = BagnonContainerItem29 {
 }
 30 = BagnonContainerItem30 {
 }
 31 = BagnonContainerItem31 {
 }
 32 = BagnonContainerItem32 {
 }
 33 = BagnonContainerItem33 {
 }
 34 = BagnonContainerItem34 {
 }
 35 = BagnonContainerItem35 {
 }
 36 = BagnonContainerItem36 {
 }
 37 = BagnonContainerItem37 {
 }
 38 = BagnonContainerItem38 {
 }
 39 = BagnonContainerItem39 {
 }
 40 = BagnonContainerItem40 {
 }
 41 = BagnonContainerItem41 {
 }
 42 = BagnonContainerItem42 {
 }
 43 = BagnonContainerItem43 {
 }
 44 = BagnonContainerItem44 {
 }
 45 = BagnonContainerItem45 {
 }
 46 = BagnonContainerItem46 {
 }
 47 = BagnonContainerItem47 {
 }
 48 = BagnonContainerItem48 {
 }
 49 = BagnonContainerItem49 {
 }
 50 = BagnonContainerItem50 {
 }
 51 = BagnonContainerItem51 {
 }
 52 = BagnonContainerItem52 {
 }
 53 = BagnonContainerItem53 {
 }
 54 = BagnonContainerItem54 {
 }
 55 = BagnonContainerItem55 {
 }
 56 = BagnonContainerItem56 {
 }
 57 = BagnonContainerItem57 {
 }
 58 = BagnonContainerItem58 {
 }
 59 = BagnonContainerItem59 {
 }
 60 = BagnonContainerItem60 {
 }
 61 = BagnonContainerItem61 {
 }
 62 = BagnonContainerItem62 {
 }
 63 = BagnonContainerItem63 {
 }
 64 = BagnonContainerItem64 {
 }
 65 = BagnonContainerItem65 {
 }
 66 = BagnonContainerItem66 {
 }
 67 = BagnonContainerItem67 {
 }
 68 = BagnonContainerItem68 {
 }
 69 = BagnonContainerItem69 {
 }
 70 = BagnonContainerItem70 {
 }
 71 = BagnonContainerItem71 {
 }
 72 = BagnonContainerItem72 {
 }
 73 = BagnonContainerItem73 {
 }
 74 = BagnonContainerItem74 {
 }
 75 = BagnonContainerItem75 {
 }
 76 = BagnonContainerItem76 {
 }
 77 = BagnonContainerItem77 {
 }
 78 = BagnonContainerItem78 {
 }
 79 = BagnonContainerItem79 {
 }
 80 = BagnonContainerItem80 {
 }
 81 = BagnonContainerItem81 {
 }
 82 = BagnonContainerItem82 {
 }
 83 = BagnonContainerItem83 {
 }
 84 = BagnonContainerItem84 {
 }
 85 = BagnonContainerItem85 {
 }
 86 = BagnonContainerItem86 {
 }
 87 = BagnonContainerItem87 {
 }
 88 = BagnonContainerItem88 {
 }
 89 = BagnonContainerItem89 {
 }
 90 = BagnonContainerItem90 {
 }
 91 = BagnonContainerItem91 {
 }
 92 = BagnonContainerItem92 {
 }
 93 = BagnonContainerItem93 {
 }
 94 = BagnonContainerItem94 {
 }
 95 = BagnonContainerItem95 {
 }
 96 = BagnonContainerItem96 {
 }
 97 = BagnonContainerItem97 {
 }
 98 = BagnonContainerItem98 {
 }
 99 = BagnonContainerItem99 {
 }
 100 = BagnonContainerItem100 {
 }
 101 = BagnonContainerItem101 {
 }
 102 = BagnonContainerItem102 {
 }
 103 = BagnonContainerItem103 {
 }
 104 = BagnonContainerItem104 {
 }
 105 = BagnonContainerItem105 {
 }
 106 = BagnonContainerItem106 {
 }
 107 = BagnonContainerItem107 {
 }
 108 = BagnonContainerItem108 {
 }
 109 = BagnonContainerItem109 {
 }
 110 = BagnonContainerItem110 {
 }
 111 = BagnonContainerItem111 {
 }
 112 = BagnonContainerItem112 {
 }
 113 = BagnonContainerItem113 {
 }
 114 = BagnonContainerItem114 {
 }
 115 = BagnonContainerItem115 {
 }
 116 = BagnonContainerItem116 {
 }
 117 = Bagn

Bags is not translated, a few other notes

Which software were you running?

• Addon version name: Bagnon beta
  SoD

Have you read the changelog?
Nope

Please describe the bug.
The word "Bags" is not in the translation string.

The reordering doesn't have any description of what happens for a left click

Also I noticed the string L.Money updates the phrase in the options window, but doesn't seem to update the phrase in the bag where it shows your gold.

Please describe how to reproduce it.
Open the bag and hover over the Bags button (in another language) and The reorder button

Any Screenshots?

Filter generates error

When trying to apply searchfilers in Bagnon for retail you end up with an stream of errors. The filter tried in this instace is ilvl:3 that generated the following.

Wow version 10.0.2.47213
Bagnon version: 10.0.14

490x ...ceBagBrother/libs/ItemSearch-1.3-1/Filters.lua:157: attempt to call field 'GetCurrentItemLevel' (a nil value)
[string "@BagBrother/libs/ItemSearch-1.3-1/Filters.lua"]:157: in function <...ceBagBrother/libs/ItemSearch-1.3/Filters.lua:156>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@BagBrother/libs/CustomSearch-1.0-10/CustomSearch-1.0.lua"]:87: in function `Match'
[string "@BagBrother/libs/CustomSearch-1.0-10/CustomSearch-1.0.lua"]:49: in function `MatchAny'
[string "@BagBrother/libs/CustomSearch-1.0-10/CustomSearch-1.0.lua"]:39: in function <...agBrother/libs/CustomSearch-1.0/CustomSearch-1.0.lua:37>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@BagBrother/addons/core/classes/item.lua"]:296: in function `?'
[string "@BagBrother/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:119: in function <...her/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@BagBrother/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:29: in function <...her/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:25>
[string "@BagBrother/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:64: in function `SendMessage'
[string "@BagBrother/libs/WildAddon-1.0-1/WildAddon-1.0.lua"]:83: in function `SendSignal'
[string "@Bagnon/src/searchFrame.lua"]:78: in function <Bagnon/src/searchFrame.lua:74>

Lua Errors new patch 10.1

Running Software (issues missing this information will be deleted):

• Addon version: Bagnon-10.0.16 / Bagnon_Scrap-10-9.2.7
• Server patch: 10.1.0.49426

To Reproduce
Steps to reproduce the behaviour:

1. Go to 'WoW Retail'
2. Click on 'Bag'
3. See error

623x BagBrother/libs/ItemSearch-1.3-2/API.lua:53: attempt to index field 'args' (a nil value)
[string "@BagBrother/libs/ItemSearch-1.3-2/API.lua"]:53: in function <BagBrother/libs/ItemSearch-1.3/API.lua:50>
[string "@BagBrother/libs/ItemSearch-1.3-2/API.lua"]:58: in function IsUnusable' [string "@BagBrother/addons/core/classes/item.lua"]:243: in function <...rfaceBagBrother/addons/core/classes/item.lua:233> [string "@Bagnon_Scrap/Bagnon_Scrap.lua"]:45: in function UpdateBorder'
[string "@BagBrother/addons/core/classes/item.lua"]:206: in function <...rfaceBagBrother/addons/core/classes/item.lua:199>
[string "=[C]"]: in function Update' [string "@BagBrother/addons/core/classes/item.lua"]:134: in function <...rfaceBagBrother/addons/core/classes/item.lua:129> [string "=[C]"]: in function Show'
[string "@BagBrother/addons/core/classes/item.lua"]:47: in function <...rfaceBagBrother/addons/core/classes/item.lua:39>
[string "=(tail call)"]: ?
[string "@BagBrother/addons/core/classes/itemGroup.lua"]:124: in function `func'
[string "@BagBrother/libs/MutexDelay-1.0-2/MutexDelay-1.0.lua"]:36: in function <...ns/BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua:30>

Locals:
lines =

{
1 = {
}
2 = {
}
3 = {
}
4 = {
}
5 = {
}
6 = {
}
7 = {
}
8 = {
}
9 = {
}
}
(for index) = 8
(for limit) = 5
(for step) = -1
i = 8
(*temporary) = nil
(*temporary) = {
leftText = ""
maxPrice = -1
price = 280619
leftColor = {
}
type = 11
}
(*temporary) = -1
(temporary) = 0
(temporary) = "attempt to index field 'args' (a nil value)"
C = {
TooltipInfo = {
}
IsItemCache = {
}
CurrencyInfo = {
}
Container = {
}
}
id = 204461
L = {
CLASS_REQUIREMENT = "Classes: (.)"
PLAYER_CLASS = "Mage"
IN_SET = "Equipment Sets: |cFFFFFFFF(.)|r"
}

Unable to split stacks in guild bank

Running Software (issues missing this information will be deleted):

• Addon version: 10.1.2 (issue started in 10.1.1)
• Server patch: 3.4.2.50375 (wrath classic)

Describe the bug
Unable to split stacks out of guild bank again

4x BagBrother/frames/guild/item.lua:30: attempt to compare number with nil
[string "@BagBrother/frames/guild/item.lua"]:30: in function <BagBrother/frames/guild/item.lua:26>

Locals:
self = BagnonGuildItem91 {
 timeSinceUpgradeCheck = 0
 OnEnter = <function> defined @BagBrother/core/classes/item.lua:118
 __super = <table> {
 }
 UnregisterAll = <function> defined @BagBrother/core/classes/base.lua:27
 IconOverlay = Texture {
 }
 Super = <function> defined @BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:157
 Bind = <function> defined @BagBrother/core/classes/item.lua:91
 IconBorder = Texture {
 }
 flashAnim = AnimationGroup {
 }
 OnReceiveDrag = <function> defined @BagBrother/frames/guild/item.lua:59
 icon = BagnonGuildItem91IconTexture {
 }
 Backgrounds = <table> {
 }
 UpdateTooltip = <function> defined @BagBrother/core/classes/item.lua:118
 ExtendedOverlay = Texture {
 }
 __type = "Button"
 __count = 91
 GetFrameID = <function> defined @BagBrother/core/classes/parented.lua:35
 NewItemTexture = Texture {
 }
 Delay = <function> defined @BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua:27
 SplitStack = <function> defined @BagBrother/frames/guild/item.lua:75
 BagStaticBottom = Texture {
 }
 UpdateLocked = <function> defined @BagBrother/core/classes/item.lua:182
 UnregisterMessage = <function> defined @AtlasLootClassic/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:143
 Update = <function> defined @BagBrother/core/classes/item.lua:141
 flash = Texture {
 }
 Dummy = Button {
 }
 RegisterFrameSignal = <function> defined @BagBrother/core/classes/base.lua:15
 SetDesaturated = <function> defined @BagBrother/core/classes/item.lua:187
 UpdateSearch = <function> defined @BagBrother/core/classes/item.lua:215
 hasItem = true
 UnregisterSignal = <function> defined @BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:78
 count = 5
 GetProfile = <function> defined @BagBrother/core/classes/parented.lua:19
 info = <table> {
 }
 GetQuery = <function> defined @BagBrother/core/classes/item.lua:305
 OnDragStart = <function> defined @BagBrother/frames/guild/item.lua:53
 frame = BagnonGuild1 {
 }
 Delaying = <function> defined @BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua:46
 Count = BagnonGuildItem91Count {
 }
 UnregisterAllEvents = <function> defined =[C]:-1
 IconGlow = Texture {
 }
 searchOverlay = BagnonGuildItem91SearchOverlay {
 }
 Construct = <function> defined @BagBrother/frames/guild/item.lua:13
 BagFamilies = <table> {
 }
 SendSignal = <function> defined @BagBrother/libs/WildAddon-1.0/WildAddon-1.0.lua:82
 bag = 1
 BattlepayItemTexture = Texture {
 }
 GetOwner = <function> defined @BagBrother/core/classes/parented.lua:27
 JunkIcon = Texture {
 }
 GetTipAnchor = <function> defined @BagBrother/core/classes/tipped.lua:19
 __template = "ContainerFrameItemButtonTemplate"
 Flash = AnimationGroup {
 }
 UnregisterEvent = <function> defined =[C]:-1
 GetClassName = <function> defined @BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:100
 GetClass = <function> defined @BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:135
 ShowTooltip = <function> defined @BagBrother/frames/guild/item.lua:68
 newitemglowAnim = AnimationGroup {
 }
 IsAbstract = <function> defined @BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:116
 UpdateUpgradeIcon = <function> defined @BagBrother/core/classes/item.lua:223
 New = <function> defined @BagBrother/core/classes/item.lua:38
 GetSlot = <function> defined @BagBrother/core/classes/item.lua:320
 GetSuper = <function> defined @BagBrother/libs/Poncho-2.0/Poncho-2.0.lua:104
 OnPostClick = <function> defined @BagBrother/core/classes/item.lua:112
 GetInfo = <function> defined @BagBrother/core/classes/item.lua:297
 GetTemplate = <function> defined @AddO

You are not in a raid group -spam

Which software were you running?

• Addon version name: 10.2.12 (Bagnon version)
• Client used: Retail 10.2. But this problem has existed for a while without me bothering to troubleshoot it until now.

Have you read the changelog?
Yes

Please describe the bug.
When in a group thats formed through matchmaking (LFR, BG etc), the chat will prompt a "You are not in a raid group" everytime the event "GROUP_ROSTER_UPDATE" fires.

Please describe how to reproduce it.
See description above.
Discovered it was Bagnon doing it by running a hooksecurefunc and filtering out for channel "RAID" while in LFR.

Any Screenshots?
No

Error Logs are Important!
No error logs, as its not producing an error. Just chat output.

I've done a workaround for myself by updating the event handling to reflect the change of chat-type:

File: BagBrother\core\features\updateDetection.lua
Line 31: self:RegisterUpdateEvent('GROUP_ROSTER_UPDATE', function() return (IsPartyLFG() and "INSTANCE_CHAT") or (IsInGroup() and 'RAID') end)

Updating/Fixing the Clean up for special bag types

putting this under a feature because i don't think its a taint or bug because its not breaking anything it just might be need a slight alter
i have been going through sorting my bank and adjusting the sort properties in the Bagbrother\Core\Api\Sorting.lua
to get a better understanding of what the parameters are for the clean up feature and what ive noticed is that it doesn't know how to prioritize items what i mean by this is that it wont move an item that can go into more than one special bag types. even if it has room for them here are a few examples
Note: i have also moved the bag slots around and put basic bags between them to see if it would then put the materials together but it does not. and reversing bag slot order doesn't change anything only how its shown to me, because i don't think there is a option for it sort items by its properties in reverse order or even by simply switching what it views as slot 1 and last slot

so here are my bags not full sorted you can see some Ore and Bars around.

Now after auto sort it looks like this you can see its moved those materials up to the top because the mining bag is full and can see where its left space in the Engineering Bag

and now i manually move the items showing that they can all fit in both bags because Elemental materials are allowed in both Special Bag Types, but the sorting ignores that.

and now i click sort gain and we end up back where we started

that said, because of everyone having there own way of how they want to sort things means you cant please everyone, and im very happy with the addon been using it forever. i didn't want be rude submitting one of these and hoped i could figure out the right combination to sort it myself but change to much and it breaks. and im not great with coding.

the fixes that come to mind would having special bag types prioritize of normal bags and have items that can fit multiple bag types have less priority to those that cant so it wont ignore items while having free space.

but since its not technically broken i was wondering maybe if you could add a little text info of how people can go about sorting it how they want it or in terms of features, maybe more sort "styles" or "filters", or potentially sort "profiles" that could be imported/exported and shared amongst the community

separate bags into different sections

I want to use Bagnon but i like having bags "separated" , is there a way to have each bag in a group, include a screen shot from another game as an example of what i mean.

Wrath Classic IsBattlePayItem method error

Wrath Classic v3.4.1.47612

repro steps

1. open inventory bag
2. pick up new item

Stack: ...rface/AddOns/BagBrother/addons/core/classes/item.lua:458: attempt to call field 'IsBattlePayItem' (a boolean value)
[string "@Interface/AddOns/BagBrother/addons/core/classes/item.lua"]:458: in function `IsPaid'
[string "@Interface/AddOns/BagBrother/addons/core/classes/item.lua"]:322: in function `UpdateNewItemAnimation'
[string "@Interface/AddOns/BagBrother/addons/core/classes/item.lua"]:216: in function `func'
[string "@Interface/AddOns/BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua"]:36: in function <...ns/BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua:30>

changing BagBrother/addons/core/classes/item.lua line 458 to return C.IsBattlePayItem solves issue

Dropdown.lua

Hi,

I have this error popping since few weeks now :

4x ...BagBrother/libs/Sushi-3.1-5/classes/drops/Dropdown.lua:148: calling 'IsMouseOver' on bad self (Usage: local isMouseOver = self:IsMouseOver([offsetTop, offsetBottom, offsetLeft, offsetRight]))
[string "=[C]"]: in function `IsMouseOver'
[string "@BagBrother/libs/Sushi-3.1-5/classes/drops/Dropdown.lua"]:148: in function <...BagBrother/libs/Sushi-3.1/classes/drops/Dropdown.lua:147>
[string "@BagBrother/libs/Sushi-3.1-5/classes/drops/Dropdown.lua"]:153: in function <...BagBrother/libs/Sushi-3.1/classes/drops/Dropdown.lua:147>
[string "=(tail call)"]: ?
[string "@BagBrother/libs/Sushi-3.1-5/classes/drops/Dropdown.lua"]:93: in function <...BagBrother/libs/Sushi-3.1/classes/drops/Dropdown.lua:92>

Locals:
(*temporary) = SimpleCheckout {
0 =
RightOutside = Line {
}
RightInside = Line {
}
Background = Frame {
}
CalculateDesiredSize = defined @Blizzard_StoreUI/Blizzard_SimpleCheckout.lua:101
OnShow = defined @Blizzard_StoreUI/Blizzard_SimpleCheckout.lua:54
OnLoad = defined @Blizzard_StoreUI/Blizzard_SimpleCheckout.lua:25
OnHide = defined @Blizzard_StoreUI/Blizzard_SimpleCheckout.lua:61
LeftOutside = Line {
}
OnExternalLink = defined @Blizzard_StoreUI/Blizzard_SimpleCheckout.lua:83
TopInside = Line {
}
BottomOutside = Line {
}
CloseButton = Button {
}
TopOutside = Line {
}
BottomInside = Line {
}
OnEvent = defined @Blizzard_StoreUI/Blizzard_SimpleCheckout.lua:29
LeftInside = Line {
}
RecalculateSize = defined @Blizzard_StoreUI/Blizzard_SimpleCheckout.lua:139
OnRequestNewSize = defined @Blizzard_StoreUI/Blizzard_SimpleCheckout.lua:75
}

lua error on login

Running Software (issues missing this information will be deleted):

• Addon version: 10.1.3
• Server patch: 10.1.5

Have you read the changelog? (please don't waste our time)
yes

Describe the bug
not sure what it's messing up

To Reproduce
Steps to reproduce the behaviour:

1. login

Expected behaviour
nothing

Screenshots
If applicable, add screenshots to help explain your problem.

Error Logs
20x BagBrother/core/api/owners.lua:75: invalid order function for sorting
[string "=[C]"]: in function sort' [string "@BagBrother/core/api/owners.lua"]:75: in function Sort'
[string "@BagBrother/core/api/owners.lua"]:66: in function ?' [string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:109: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:109> [string "=[C]"]: ? [string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@Ace3/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function Fire'
[string "@Ace3/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <Ace3/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals:
(*temporary) =

{
1 = {
}
2 = {
}
3 = {
}
4 = {
}
5 = {
}
6 = {
}
7 = {
}
8 = {
}
9 = {
}
10 = {
}
11 = {
}
12 = {
}
13 = {
}
14 = {
}
15 = {
}
16 = {
}
17 = {
}
18 = {
}
19 = {
}
20 = {
}
21 = {
}
22 = {
}
23 = {
}
24 = {
}
25 = {
}
26 = {
}
}
(*temporary) = defined @BagBrother/core/api/owners.lua:75
(temporary) = {
profile = {
}
isguild = 11
name = "Goldcapped"
address = "®Goldcapped-Mal'Ganis"
id = "Goldcapped"
offline = true
cache = {
}
realm = "Mal'Ganis"
}
(temporary) = {
profile = {
}
isguild = 11
name = "Goldcapped"
address = "®Goldcapped-Mal'Ganis"
id = "Goldcapped"
offline = true
cache = {
}
realm = "Mal'Ganis"
}
(temporary) = {
profile = {
}
isguild = 12
name = "Body By WoW"
address = "®Body By WoW-Mal'Ganis"
id = "Body By WoW"
offline = true
cache = {
}
realm = "Mal'Ganis"

Does not work with CraftUI tooltips anymore

See