Giter Site home page Giter Site logo

Comments (11)

JasperAppec avatar JasperAppec commented on July 28, 2024

Thanks for the report.

Please let me know if it's working now. I don't have a proper environment setup at this moment so can't test it thoroughly.

from sai-editor.

 avatar commented on July 28, 2024

Tested it now and it outputs both values and column names as expected. Thanks! 👍


I should probably mention that there is no button or menu to set the NegativeCondition value in the GUI. Do you prefer to have that reported in a new issue, so you can close this one? :)

from sai-editor.

JasperAppec avatar JasperAppec commented on July 28, 2024

Great to hear! 😄
My last commit (8a052f1) just fixed a minor mistake in the last commit.

As for the NegativeCondition, from what I remember this was more like an optional condition value rather than a new field or am I wrong? What I mean is that it was only used for a handful of condition types.

Would it be a good idea to put NegativeCondition input field right below the ConditionValue3 field?

from sai-editor.

 avatar commented on July 28, 2024

It looks like there is space to put the GUI NegativeCondition selector above [Error type:] and [Error text id:] so those 2 controls get pushed down 1 place. I also think it is logical to find the NegativeCondition selector just behind the ConditionValue1 selector. I hope this makes sense. Image:

condition-editor


edit: Maybe you are right about the NegativeCondition being just an optional condition value, but I have found it very useful in some of my recent Pull Requests to TrinityCore, like in
[3.3.5] Core/Scripts: move druid FP NPC scripts to DB/SAI #17134

If you look in [the conditions section] of my SQL in https://github.com/TrinityCore/TrinityCore/pull/17134/files , you will see that I found it more practical to use it those 2 times to make the conditions coherent, even if I could have chosen the opposite faction in ConditionValue1.

from sai-editor.

JasperAppec avatar JasperAppec commented on July 28, 2024

How is this?

from sai-editor.

 avatar commented on July 28, 2024

Will do a new pull and check. Reporting back after testing. :)

from sai-editor.

 avatar commented on July 28, 2024

Hmm... I can't seem to open Condition-Editor after compiling the new version. Do I need to downgrade or upgrade my Visual Studio 2013 update 5 (or use VS2015) to make the current build work as .EXE ?

sai-editor open conditions-editor

Full output text: http://pastebin.com/bUuFXzgm (Condition-Editor Unhandled Exception)

from sai-editor.

JasperAppec avatar JasperAppec commented on July 28, 2024

Oops, try now.

from sai-editor.

 avatar commented on July 28, 2024

(Sorry for the delayed reply, I had a busy day driving around on Crete with my parents. :) )
Yes, it works now. The placing is good, I approve of your changes. :)

condition-editor codition editing

from sai-editor.

 avatar commented on July 28, 2024

Never mind, I think my latest suggestions are way outside of this issue. I will remove this extra text in https://github.com/Discover-/SAI-Editor/issues/42#issuecomment-220045853 and move it to a new issue. Thanks a lot for keeping up your work on this. 👍

from sai-editor.

 avatar commented on July 28, 2024

New issue based on the content I moved: [Condition-Editor] : GUI + functionality changes wanted #44

from sai-editor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.