jasper-rietrae2/sai-editor

Editor for TrinityCore's SAI (SmartAI / smart_scripts) database scripting system

Deprecated

This software is no longer maintained, you can check Keira3: a modern version of the SAI Editor inspired by this project or WoW Database Editor an IDE for TrinityCore database including smart scripts editor.

SAI-Editor

Editor for TrinityCore's SAI (SmartAI / smart_scripts) database scripting system.

Links

http://www.trinitycore.org/ https://trinitycore.atlassian.net/wiki/spaces/tc/pages/2130108/smart+scripts

sai-editor's Issues

[Condition-Editor] : GUI + functionality changes wanted

(issue content moved here from issue #42 because the original issue was solved)

I don't like being pedantic, but I usually am. If I may point out a detail regarding the selection of the upper right hand options [Gossip menu entry] and [Gossip menu text entry], I only get zero (0) as values instead of the actual gossip_menu.entry + gossip_menu.text_id as in this example:

1. This window needs to be larger (higher) to show the bottom button options at all.
2. Maybe Condition-Editor ( [Codition editing] + [Conditions overview] ) could be resizeable?
3. In the 3 lines in the image example above, I have manually entered the values for gossip_menu.entry (SourceGroup) + gossip_menu.text_id (SourceEntry) in line 1 and 2, because the Editor only adds 0, which is not a valid value in the gossip_menu table. Line 3 shows the result from picking those values from the list selectors. Those values could in theory be valid for gossip_menu_option, but not for gossip_menu.

SELECT * FROM `gossip_menu` WHERE `entry`= 0 AND `text_id` = 0;

 entry  text_id
------  -------

Result: (empty table)

Likewise, for gossip_menu_option, the values 0,0 will only result in this output:

SELECT * FROM `gossip_menu_option` WHERE `menu_id`= 0 AND `id`= 0;

menu_id      id  option_icon  option_text               OptionBroadcastTextID  option_id  npc_option_npcflag  action_menu_id  action_poi_id  box_coded  box_money  box_text  BoxBroadcastTextID
-------  ------  -----------  ------------------------  ---------------------  ---------  ------------------  --------------  -------------  ---------  ---------  --------  ------------------
      0       0            0  GOSSIP_OPTION_QUESTGIVER                      0          2                   2               0              0          0          0                             0

If I may suggest a change, it would be that those 2 options change names if the user selects SOURCE_TYPE_GOSSIP_MENU (14), the names of those 2 options can be replaced with [Gossip menu entry] and [Gossip menu text_id]. In the same way, if the user selects SOURCE_TYPE_GOSSIP_MENU_OPTION (15), the names could reflect the actual table column names gossip_menu_option.menu_id and gossip_menu_option.id (you can of course choose to put your own version of the column names there, as long as it makes sense and refers to the actual column names).

---

Looking back at the [Codition editing] tab, may I suggest that the 3 lines below [Condition type] are by default labeled as ConditionValue1,ConditionValue2,ConditionValue3 just like in the DB conditions table, and that the names change depending on the selected [Condition type]? (You can continue to use the existing behaviour that the ConditionValue2 and ConditionValue3 names are hidden if they are not used by the selected Condition type.)

If I may suggest another detail change for the column names in the [Conditions overview] tab, based on the assumption that Condition-Editor can be made a bit larger or resizeable, is it possible to set the column heading names to be expanded to show the entire name text for all the column header names by default? (This is only a cosmetic suggestion, since those names are expanded only in text view in SQLyog or other MySQL editors I have used.) :)

Parameters dont work!

Hello,
i want edit my Smart_script bud TAB with Parameters doesnt work and when i want to execute script, some errors will show.

Previous versions like 1.3.0 working better or i dont know where is the problem...

Fields not updating

When switching from say line 1 to line 3, none of the information updates. The only way I have found to update the information is to click "generate comments". Even when clicking on generate, the fields are slow to update. Im using Win7 64bit, SAI-Editor 1.5 and SQLyog. The databases seems fine, wow runs fine, auth and world.exe run fine. Not sure if its me or something else. The two screen shots are examples. They show the same information even though different line items are selected.

EDIT: I uninstalled the .exe I downloaded from TC and pulled and compiled my own. Doing so seemed to clear up the issue, so it must be something that was recently fixed?

Implement Squirrel for auto updating

Alt+F4 is not working

can not open

I do not know why and I have used 1.4.3 and well but 1.5.0 open it and can not open and not errors

win 10 x64

ItemExtendedCost.dbc

Is it possible to add ItemExtendedCost.dbc to the dbc sqlite db?

Eventtypes/Actionstype: Lost Paramentries

Just like to report a minor issue while filling fields in eventparam_x/actionparam_x.
The values in these fields disappear after the comments were generated.

Example:
Before: http://pokit.org/get/?5fef3473ff692b6ab91c293d2da52db0.jpg
Creaturemodelfield has datas

-> then after running the generating button

http://pokit.org/get/?c7590ccac58f76d65ecc713a8db0c620.jpg
Creaturemodelfield lost datas

This also happens with some eventparams.

Best regards :)

z and o

On action 62 (teleport) the z and o values are not exported in the sql query

(And maybe also not loaded correct)

The application won't auto connect if "Don't use a database" option is checked

The UI freezes but the controlbox still works. Debug in MainForm.MainForm_Load:~L241.

Bug minimizing

OS: Windows 7 Ultimate x64
Compiling: Release/Debug - Mixed Platforms

When you minimize the window disappears, for example:

Open to SAI-Editor:

Minimizing:

$exception {"未将对象引用设置到对象的实例。"} System.NullReferenceException

我使用win10 vs2017 进行编译，没有出错 调试运行出现$exception {"未将对象引用设置到对象的实例。"} System.NullReferenceException
希望解决 谢谢

[Eventparameter] Proposal: Remove eventparameters while using eventtype 61

Easiest example can be found here TrinityCore/TrinityCore@03c1769#commitcomment-20491592

The issue:

If you create a new line with eventtype 61 and if you use the "Link from" button then, the eventparameters will be copied to your new line. eventtype 61 should never contain any values in eventparam1 till eventparam4.

Thank you very much for reading the report :)

New Difficulty flags for SAI Editor.

Blizzard in Pandaria and to Draenor add new flags.
Need add for avoid confusion

enum Difficulty : uint8
{
    DIFFICULTY_NONE           = 0,
    DIFFICULTY_NORMAL         = 1,
    DIFFICULTY_HEROIC         = 2,
    DIFFICULTY_10_N           = 3,
    DIFFICULTY_25_N           = 4,
    DIFFICULTY_10_HC          = 5,
    DIFFICULTY_25_HC          = 6,
    DIFFICULTY_LFR            = 7,
    DIFFICULTY_CHALLENGE      = 8,
    DIFFICULTY_40             = 9,
    DIFFICULTY_HC_SCENARIO    = 11,
    DIFFICULTY_N_SCENARIO     = 12,
    DIFFICULTY_NORMAL_RAID    = 14,
    DIFFICULTY_HEROIC_RAID    = 15,
    DIFFICULTY_MYTHIC_RAID    = 16,
    DIFFICULTY_LFR_NEW        = 17,
    DIFFICULTY_EVENT_RAID     = 18,
    DIFFICULTY_EVENT_DUNGEON  = 19,
    DIFFICULTY_EVENT_SCENARIO = 20,
    DIFFICULTY_MYTHIC         = 23,
    DIFFICULTY_TIMEWALKER     = 24,

    MAX_DIFFICULTY
};

enum DifficultyFlags
{
    DIFFICULTY_FLAG_HEROIC          = 0x01,
    DIFFICULTY_FLAG_DEFAULT         = 0x02,
    DIFFICULTY_FLAG_CAN_SELECT      = 0x04, // Player can select this difficulty in dropdown menu
    DIFFICULTY_FLAG_CHALLENGE_MODE  = 0x08,

    DIFFICULTY_FLAG_LEGACY          = 0x20,
    DIFFICULTY_FLAG_DISPLAY_HEROIC  = 0x40, // Controls icon displayed on minimap when inside the instance
    DIFFICULTY_FLAG_DISPLAY_MYTHIC  = 0x80  // Controls icon displayed on minimap when inside the instance
};

[1.5.1] Condition-Editor missing 2 SQL output options: NegativeCondition & ErrorType

SAI-Editor / Condition-Editor version: 1.5.1

Maybe this is a minor detail (I don't know), but it would be very useful if Condition-Editor could add SQL output of the 2 condition options NegativeCondition and ErrorType, at least for TrinityCore conditions SQL scripts.

As it is now, the action button [Generate SQL] does not add these 2 options to the SQL output. The Condition-Editor only shows these 2 options in the [Conditions overview] tab.
(sorry for not pointing this detail out in the first version of this post)

At the moment, those 2 options are missing in the SQL output from Condition-Editor version 1.5.1.
(I don't know how much is involved to make this change, so if it is too much work, I don't blame you.) :)

---

edit: Added "Milestone" or points to this issue post:

• Add NegativeCondition output to SQL (default: 0)
• Add ErrorType output to SQL (default: 0)

6.x sqlite database missing

@Rushor any chance you want to do this?

[Error] Cannot open SAI Editor

A freind just reported, that the SAI Editor some times does not correctly starts.

Quote from him:

For some reason as soon as i run the exe, it shows in task manager and almost instantly closes, no error, no nothing, Antivirus is off.
1.5.0 works, that's the old one. 1.5.1 does not work.

Any ideas why it does not work? Maybe @Faq @FrancescoBorzi can help? :)

Download issue

This might be an issue with the SAIEditor uploaded or the tool its compressed with?
Anyhow, I tried downloading latest and it's not recognized as a zip.
So... I renamed it as a .rar
... and it worked.

Windows7 (64bit)

Maybe it's my crappy Windows...
But, if anyone has an issue uncompressing or opening the zip, winrar recognizes it as a .7z file.

quest_template

errors appear on quest links, seems like quest_template querys are not updated.

Have to Click "Generate Comments" Every Time

You have to click "Generate Comments" every time you want to see the Dynamic Script Information and the Parameters updated when selecting a new event. In the previous version you didn't have to do this

Add missing events, actions and targets

Exception thrown when selecting a world database after starting up with 'UseWorldDatabase' setting on false

Wrong SMART_ACTION_SET_EVENT_PHASE, SMART_ACTION_INC_EVENT_PHASE, SMART_ACTION_RANDOM_PHASE & SMART_ACTION_RANDOM_PHASE_RANGE parameters

The tooltips and parameter names given by the editor for these actions suggest phaseMask are used when core-side those actions set phase indexes. More simply a creature can't be in multiple phases at once so it doesn't make sense to put a phase mask in a phase setter.
More technically, SmartScript::mEventPhase is the creature current phase index. The smartAI phase related actions use SmartScript::SetPhase which set mEventPhase. Which is only accessed in IsInPhase, which uses mEventPhase as a phase index. (SmartScript.h::219).

Here is the db fix part I made if you want to use it :

UPDATE action_type_information
SET 
tooltip = "Set the creature's event phase to a new value", 
parameterString1 = "Phase index"
WHERE action_type = 22;

UPDATE action_type_information
SET tooltip = "Increment or decrement the creature's event phase"
WHERE action_type = 23;

UPDATE action_type_information
SET 
tooltip = "Set the creature's event phase to a new value", 
parameterString1 = "Phase index 1",
parameterString2 = "Phase index 2",
parameterString3 = "Phase index 3",
parameterString4 = "Phase index 4",
parameterString5 = "Phase index 5",
parameterString6 = "Phase index 6"
WHERE action_type = 30;

UPDATE action_type_information
SET 
tooltip = "Set the creature's event phase randomly between two indexes values",
parameterString1 = "Phase index 1",
parameterString2 = "Phase index 2"
WHERE action_type = 31;

Exceptions thrown after setting phase color

Changing the phase of an event and then selecting another item throws some errors because of a missing selected item at a given moment.

Crash when deleting last row

Offline, WOTLK, Ctrl+D on last SAI line

Alt+F4 and menu option "Exit (Alt + F4)" disabled

Version: 1.4.3 from http://www.trinitycore.org/f/files/file/17-sai-editor/
(I could not find which commit rev. hash the 1.4.3 version uses)

If you want to close the application, the only working option is the [X] in the top right corner.
The keyboard combo Alt+F4 and File menu option "Exit" does not react at all (disabled).

Failed to start

When the program starts it stops working.
The problem occurs in systems architecture 64-bit
Problem signature :
  Problem Event Name : CLR20r3
  Problem Signature 01: sai- editor.exe
  Problem Signature 02: 1.4.2.0
  Problem Signature 03: 530ce74f
  Problem Signature 04: mscorlib
  Problem Signature 05: 4.0.0.0
  Problem Signature 06: 52ccf750
  Problem Signature 07: 1204
  Problem Signature 08: 89
  Problem Signature 09: System.TypeLoadException
  OS Version : 6.1.7601.2.1.0.256.48
  Locale ID : 3082
  Additional Information 1: 0a9e
  Additional Information 2 : 0a9e372d3b4ad19135b953a78882e789
  Additional Information 3: 0a9e
  Additional Information 4: 0a9e372d3b4ad19135b953a78882e789

Read our privacy statement online :
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0c0a

If the online privacy statement is not available , please read our privacy statement offline:
  C: \ Windows \ system32 \ en-GB \ erofflps.txt

Phasemasks can't be used at all

Everytime you put a phasemask, and then select another line, it throws an error (4 errors in a row if you click "ok") and it's impossible to use phases at all o_0
This is an app-breaking issue, it blocks the user or he has to crash the application. And can never make phased mobs.

Doesn't close on Windows 7

The application is unable to close at Windows 7 for some reason. Might be related to the WndProc override call to prevent the form from being moved during expanding/contracting.