[Eventparameter] Proposal: Remove eventparameters while using eventtype 61

[Rushor]

[Eventparameter] Proposal: Remove eventparameters while using eventtype 61

[JasperAppec]

I could fix it for you sometime soon, but rolling out a full update is going to take me more time that I don't really have. Would that be okay?

[Rushor]

yeah sure :)

[JasperAppec]

I just tried this and the event parameters aren't copied over when using the "Link to" button. Are you sure it wasn't a human error?

[Rushor]

hm no, maybe i used an outdated version - i will update to the newest one and test it again

[JasperAppec]

Alright let me know!

[Rushor]

okay i cloned the newest version (branch master) and it's the same issue, i will make a video

[Rushor]

and the video: https://youtu.be/c8dhw13Rwws

thanks for reviewing it :)

[JasperAppec]

Weird, I can't reproduce it myself. Even with LinkFrom. Can you try it without using a world database?

[Rushor]

yep without database connection it works fine :o

-- <Could not generate name> SAI
SET @ENTRY := 19;
-- No changes to the AIName were made because there is no world database connection.
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,1,1,0,100,0,2000,2000,2000,2000,11,@ENTRY*100+08,0,0,0,0,0,1,0,0,0,0,0,0,0,"Npc - Event - Action (phase) (dungeon difficulty)"),
(@ENTRY,0,1,0,61,0,100,0,0,0,0,0,11,7,0,0,0,0,0,1,0,0,0,0,0,0,0,"Npc - Event - Action (phase) (dungeon difficulty)");

[JasperAppec]

Ah I see. I don't have a world database to test it with atm, so it'll be trial and error. I'll give it a shot later.

[JasperAppec]

@Rushor let me know if it works with recent commit. Still don't have a local database for TC myself and I'm clueless as to why it works without a database connection.

I now remember why commenting code is good practice... 😞

[Rushor]

@Discover- yes that fix works fine. thank you! <3

[JasperAppec]

Great to hear! Thanks for testing, no problem. 😄