javalent / settings-search Goto Github PK
View Code? Open in Web Editor NEWAdds a search bar to Obsidian.md's settings
License: MIT License
Adds a search bar to Obsidian.md's settings
License: MIT License
All other plugins should load correctly when this plugin is enabled
Latest version prevents certain plugins from loading correctly.
For example, the smart connections plugin does not load with Settings Search enabled. Disabling Settings Search fixes this issue, and Smart Connections loads correctly.
caught (in promise) TypeError: Cannot read properties of undefined (reading 'includes')
at t.eval (plugin:settings-search:266:54)
at t.wrapper [as addSettingTab] (plugin:settings-search:59:20)
at t.addSettingTab (app.js:1:2028572)
at SmartConnectionsPlugin.initialize (plugin:smart-connections:511:10)
1.4.14
1.3.9
No response
Hello,
I just logged these issues in other plugins, and in both cases, turning off Settings Search and re-starting made the issues go away:
Setup
When I click the arrow, I expect to be taken to the plugin's settings, or at least have it highlighted in the community plugins page. As it stands, it just takes me to the top of the community plugins page and gets me to search again from there.
In my view this is a bug even though I submitted it as a feature request. Any plans on fixing this?
Please move the settings section to the top. Hot keys move down to bottom.
Settings should be the first. Since your plugin's name is Settings search. ๐
Thanks for creating this nice plugin.
The README file says:
You can use the keyboard to navigate the search results. The up and down arrow keys can be used to move through the results, and the enter button will take you to the setting.
If I press CTRL+,
to display the settings dialog window and then type "core pl" into the search field in the top left corner (let's say I want to browse core plugin settings) the top item in "Settings search results" in the right pane is "Search core plugins" but how can I use keyboard navigation to activate it? Tab does not work, arrow keys does not work, enter does not work. Also, I was used to that pressing ESC would close the settings dialog. However, now ESC does nothing and I have to manually close the dialog by pressing the cross mark in the top right corner. If I do this, and close the dialog and then reopen it again by pressing CTRL+, the search field is already filled out with "core pl" but the "Settings search results" in the right pane does not show "Search core plugins" any more as the top result.
I am on Linux using Obsidian version 0.14.2
see Reocin/obsidian-markdown-formatting-assistant-plugin#65 (comment)
getting this message consistently in developer console
seems to be a conflict with markdown formatting assitant and will post problem there too...
turning off settings search eliminates error message
plugin:obsidian-markdown-formatting-assistant-plugin:5107 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'active')
at eval (plugin:obsidian-markdown-formatting-assistant-plugin:5107:56)
at e.addToggle (app.js:1:1135946)
at SettingsTab.eval (plugin:obsidian-markdown-formatting-assistant-plugin:5106:22)
at step (plugin:obsidian-markdown-formatting-assistant-plugin:79:23)
at Object.eval [as next] (plugin:obsidian-markdown-formatting-assistant-plugin:60:53)
at eval (plugin:obsidian-markdown-formatting-assistant-plugin:53:71)
at new Promise (<anonymous>)
at __awaiter (plugin:obsidian-markdown-formatting-assistant-plugin:49:12)
at SettingsTab.display (plugin:obsidian-markdown-formatting-assistant-plugin:4893:16)
at SettingsSearch.getTabResources (plugin:settings-search:170:15)
I am adding the style settings settings with this bit of code
// compatability with Settings Search Plugin
if ((window as any).SettingsSearch) {
const settingsSearch: any = (window as any).SettingsSearch;
settingsSearch.removeTabResources('obsidian-style-settings');
for (const parsedCSSSetting of this.settingsList) {
console.log('test');
settingsSearch.addResources(...parsedCSSSetting.settings.map(x => {
const settingsSearchResource: SettingsSeachResource = {
tab: 'obsidian-style-settings',
name: 'Style Settings',
text: getTitle(x) ?? "",
desc: getDescription(x) ?? "",
}
// console.log(settingsSearchResource);
return settingsSearchResource;
}))
}
}
Settings Search uses the text
field as the title of the setting, as described in the comment
The name of the setting to add.
The name of the settings tab is used as the name of the settings.
it would be nice to have the search field be focused automatically so the user can open settings via hotkey then immediately type the setting they want without having to remove their hands from the keyboard. currently, the "Search installed plugins" field is the active focus but I believe that search is subsumed by the global search of this plugin
Hi @valentine195!
I noticed that all the settings specific to some plugins (ie your Admonition, Kanban, Excalidraw etc.) won't result when I search for them as you can see here
It would be great if plugin with loads of settings, like Excalidraw, could take advantage of the search bar
Thank you in advance!
Hey and thanks for this great plugin, Please add a more keyboard friendly alternative to up and down arrows for navigation in search results.
Hello @valentine195 !!!
I don't know if is feasible but would be great if we could navigate between the search matches using the keyboard :)
If possible ๐
1- highlight the active match while using the keyboard to navigate
2- would be very useful if we could hit enter to "execute" the highlighted match
Thanks for reading this.
Test
Test
Test
Test
I found that a bit confusing. Had to enable/disable it and hunt for the GUI change. Thanks for the useful plugin!
Nice plugin. Currently, it is capable of searching & jumping to the correct settings page.
But when dealing with really-long settings pages (namely, Excalidraw and Style settings), only jumping to the right page still leaves an awful lot of reading and scrolling to do.
When clicking the link from search result, jump to the exact line that contains your query, instead of only jumping to the page.
Hello @valentine195 !!!!
If possible would be great if we could have the caret cursor focused on the search field when opening settings.
Have a great day!
Please try to install obsidian-enhancing-export plugin and you'll notice that the UI is unresponsive and there are some errors in the console. More details here
pretty much what the title says. I also encountered a similar issue with the Dynamic Highlights Plugin, btw.
the latest version cause a bug : setting button disappear for some plugins
plugin icon disappear from ribbon left sidebar
1.4.14
1.3.9
No response
Thanks for this awesome plugin @valentine195 !
The placeholder text "Search settings..." was being cut off on my system (I use the standard Dark theme)
I added this custom CSS to fix it:
/* slightly wider settings nav area */
.modal.mod-settings .vertical-tab-header {
flex: 0 0 220px;
}
When searching for a term that matches a plugin name, in the matched results I get a cog icon (to access the plugin's options/settings) and an arrow icon (presumably to go to the plugin's entry in the Community Plugins section).
However, whenever I use the arrow icon for any plugin, it never actually takes me to that plugin's entry, but rather it just dumps me at the beginning of the Community Plugins list, where I then have to manually scroll through all the entries to find the plugin for myself.
I'm not sure whether this is by design or not, but it would be good if the arrow icon in the Settings Search results took you to the general Community Plugins section and scrolled you down to the correct specific plugin entry.
Thanks.
Hello @valentine195 !!!!
Would be amazing if we could open the plugin settings with the global search.
Today, if we search for a plug-in, we are redirect to the community plugins instead for the settings tab of the plug-in.
Have a great day!!!!
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.