Comments (3)
[email protected] who raised this issue in Chromium code review 333603002:
https://codereview.chromium.org/333603002
Original comment by [email protected]
on 23 Jun 2014 at 9:58
from cld2.
This is looking more important now that Chromium is running into issues that
exacerbate the problem:
https://code.google.com/p/chromium/issues/detail?id=367239
In a complex project that uses CLD2, having to fork the build logic on
CLD2_DYNAMIC_MODE is sub-optimal.
I suggest we go ahead with the fix proposed above, with one caveat: While we're
here, we add a new method:
bool isDataDynamic()
This method can be declared in the .h and implemented with a simple
preprocessor check in the c++ code to return either true (if CLD2_DYNAMIC_MODE)
or false (otherwise). This will still allow dependent projects to be smart. The
cost is that we will need to bring in a total of 5 function signatures into the
header (the 4 that already exist, plus the new one); this shouldn't be a big
deal, though, since there's no extra includes and build optimizations should be
able to simply discard the unused symbols in most projects. Very low cost, and
makes life easier. I'm going to go ahead with this.
Original comment by [email protected]
on 25 Jul 2014 at 8:07
from cld2.
Committed in r162.
Original comment by [email protected]
on 25 Jul 2014 at 9:56
- Changed state: Fixed
from cld2.
Related Issues (20)
- CLD2 result chunk vector omits portions of input file HOT 6
- Dynamic data loading should not use iostream HOT 5
- Windows build fails: undeclared identifier 'close' HOT 6
- Support mmap-ing dynamic data on win32 HOT 5
- Build warning on Windows with clang HOT 2
- Eliminate redundancy and/or simplify default case for compiling unittest_data.h HOT 4
- Missing include in cld2_dynamic_data_loader.cc HOT 1
- cld2_dynamic_data.cc and cld2_dynamic_data_loader.cc problems on Win32 HOT 10
- Enable dynamic data for 20141015 release HOT 1
- New GCC 5.0 hits problem with narrowing in list-initializers HOT 2
- CLD should check result of "new" in all use cases HOT 1
- please use CFLAGS CXXFLAGS CPPFLAGS and LDFLAGS HOT 3
- please provide a SONAME HOT 13
- cld2 testsuite failures HOT 3
- Compilation issues in Visual Studio
- Compilation failure on VS2015 on Windows
- Check in tools for generating generated_* files HOT 2
- Add armv8-a support HOT 5
- new code location? HOT 6
- Add possibility to set MinReliableKeepPercent HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cld2.