jj101k/frequency_histogram

frequency_histogram's Issues

Noise reduction is ineffective in some obvious cases

Those peaks emphatically should not be present

Wind direction is always high for 0, 360 and low for 1

Note: I don't think any effort has been included to express this as a finite field
Note: Haven't checked the data for this

Noise reduction should be on by default

Noise reduction is very good at dealing with low-resolution data, but with it initially off the user is presented with information which is fully expected to be lower-quality.

Raw, raw day & histogram should have Y axis values

Raw, raw day: the actual value
Histogram: the frequency (integer).

Note that "Interpolated histogram" (sic) doesn't have a single value for the vertical because it's dependent on the width of the slice, but it could express values in "frequency per unit", eg. if you have 20 "per 1 degree C" you'd understand that if you're looking at it as a 2 degree C chunk it would mean 40.

You should be able to hover to get a value at a point

Regardless of graph, you should be able to hover over and get information about the X and Y values and meaning at that X point

Noise reduction can cause anomalous frequency drops

Relative Humidity values > 100 are implied

The spanning code takes runs of the same value to be oscillating around the target point at just under the sensor precision, in order to provide a value with some actual width. Unfortunately, readings at the edge of possible values do happen (eg. 100% in this case), which causes the span to run over.

Should validate the frequency indication with random sampling

The frequency indication differs from the literal histogram. Running through the source data picking two points and a random distance between them should produce a frequency plot which closely resembles the indication, and that should be tested.

Some graphs are shallower than intended

All graphs should have the same render height.

Noise reduction may be too aggressive in some cases

See right hand side:

A visibly angled line is not intended here.

PWC has a numbered X axis, but that makes no sense for the data type

It should just be unnumbered

Add user-level error reporting

At the moment, errors are only in the console log. While logging them is appropriate, the user should at least get an "internal error" message.

Raw & raw day should have horizontal axis values

Currently they have nothing, but raw day is simply 0-24, and raw can at least include the month

If the value never changes, it's not shown

Artificial case here, but:

Misrender for ETH -> All -> Histogram

Noticed with BHX/canvas

Histogram: some data produces frequencies which run below the zero axis line

Canvas->ETD->all->histogram

Cause is unknown, but several others also go very slightly over the line