joeroe/rpaleoclim

R interface for PaleoClim paleoclimate data

rpaleoclim's Issues

Switch from raster to terra

Amongst other things, rgdal is on the way out: https://cran.r-project.org/web/packages/rgdal/index.html

Adjust timeout option for large files

As suggested in ?download.file.

Add tests

The PaleoClim URLs don't seem to be particularly stable, so having tests to check that the downloads still work is essential for this package.

Make sure failed downloads are removed

See #2. Switching from download.file() to curl::curl_download() might fix this for free.

Release rpaleoclim 1.0.0

First release:

• usethis::use_cran_comments()
• Update (aspirational) install instructions in README
• Proofread Title: and Description:
• Check that all exported functions have @return and @examples
• Check that Authors@R: includes a copyright holder (role 'cph')
• Check licensing of included files
• Review https://github.com/DavisVaughan/extrachecks

Prepare for release:

• git pull
• Check if any deprecation processes should be advanced, as described in Gradual deprecation
• devtools::build_readme()
• urlchecker::url_check()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• rhub::check_for_cran()
• git push
• Draft blog post

Submit to CRAN:

• usethis::use_version('major')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• git push
• usethis::use_github_release()
• usethis::use_dev_version()
• git push
• Finish blog post
• Tweet
• Add link to blog post in pkgdown news menu

(Re)add examples to function documentation

For rOpenSci submission #9.

Add vignette

For rOpenSci submission #9. See https://r-pkgs.org/man.html?q=donttest#man-functions

• Background on PaleoClim/CHELSA
  • Add citations
• Installation
• Data available
  • Intro/disclaimer
  • Table of periods
  • Table of bioclimatic variables
  • Other options (resolution)
• Retrieving data
• Caching
• Compatibility with raster

Subset by bioclim variable in paleoclim()

Could be useful.

Add PaleoClim citation to DESCRIPTION

Add cache_path parameter

Defaulting to fs::path_temp as now, but allowing the user to e.g. cache files in the working directory to reuse between sessions.

Be polite

pkgcheck results - master

Checks for rpaleoclim (v0.9)

git hash: 49e77025

• ✔️ Package name is available
• ✔️ has a 'CITATION' file.
• ✔️ has a 'codemeta.json' file.
• ✖️ does not have a 'contributing' file.
• ✔️ uses 'roxygen2'.
• ✔️ 'DESCRIPTION' has a URL field.
• ✔️ 'DESCRIPTION' has a BugReports field.
• ✖️ Package has no HTML vignettes
• ✖️ These functions do not have examples: [construct_paleoclim_url, load_paleoclim, paleoclim].
• ✔️ Package has continuous integration checks.
• ✔️ Package coverage is 100%.
• ✔️ R CMD check found no errors.
• ✔️ R CMD check found no warnings.

Important: All failing checks above must be addressed prior to proceeding

Package License: MIT + file LICENSE

Issues pulling specific paleoclim rasters

I'm having issues downloading specific raster sets (at any resolution). These include the LGM and MPWP right now, but may also include others that I haven't tested yet. Any ideas why this might be?

trying URL 'http://sdmtoolbox.org/paleoclim.org/data/chelsa_LGM/chelsa_LGM_v1_2B_r10m.zip'
Content type 'application/zip' length 17468981 bytes (16.7 MB)

downloaded 63 KB

Error in utils::download.file(url, tmpfile, "auto") :
download from 'http://sdmtoolbox.org/paleoclim.org/data/chelsa_LGM/chelsa_LGM_v1_2B_r10m.zip' failed
In addition: Warning messages:
1: In utils::download.file(url, tmpfile, "auto") :
downloaded length 65380 != reported length 17468981
2: In utils::download.file(url, tmpfile, "auto") :
URL 'http://sdmtoolbox.org/paleoclim.org/data/chelsa_LGM/chelsa_LGM_v1_2B_r10m.zip': Timeout of 60 seconds was reached

Migrate caching functionality to memoise?

Maybe. Might be overkill. https://github.com/r-lib/memoise

curl timeout in workflows

Error in curl::curl_download(url, tmpfile, quiet = quiet) :
Timeout was reached: [] Connection timed out after 10000 milliseconds

I sporadically see this error in R CMD check workflows, in the example for paleoclim(). It varies from whether 1-3 will fail, but it's always at least one, and usually Windows. I haven't been able to reproduce it locally, even on very spotty connections and even after htting SDMtoolbox.org repeatedly.

The timeout is on receiving any response from the server, not downloading the file, so this is a separate issue from #2.

According to jeroen/curl#72 it could have something to do with bad DNS but I find it a bit surprising this would affect GitHub Actions.

I've tried working around it by dropping the example, but this is holding up submission to rOpenSci (#9) and is obviously not ideal anyway. I've also tried \donttest, but since this is now run on CRAN and using R CMD check --as-cran, it doesn't help. \dontrun maybe would, but it isn't recommended for CRAN submissions apparently.

Next to try: increasing the timeout limit manually per jeroen/curl#173

Remove suggested `rgdal` as soon as possible

raster stopped using rgdal and rgeos in favour of terra in September 2022; rgdal, rgeos and maptools will be archived in October 2023 (see: https://r-spatial.org/r/2023/05/15/evolution4.html, https://r-spatial.github.io/evolution/). When rgdal is not on the library path, this is the CMD check log:
00check.log with test details:
testthat.Rout.zip
Almost certainly, both the Suggests: listing and the test are left over from before #10.

Release rpaleoclim 1.0.1

Prepare for release:

• git pull
• Check current CRAN check results
• Polish NEWS
• urlchecker::url_check()
• devtools::build_readme()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• revdepcheck::revdep_check(num_workers = 4)
• Update cran-comments.md
• git push

Submit to CRAN:

• usethis::use_version('patch')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version(push = TRUE)