Display of INVENTORY section, with headings

[johnjung]

Display of INVENTORY section, with headings

[johnjung]

I need to figure out which situations I should display labels in...please let me know if you'd like to try the following approach:

1. Display did elements that include containers like table-rows. In this case, elements other than containers are collected in the rightmost column where each element gets a label, like "title".
2. When did elements do NOT include containers, display each child as its own one-cell row in the table-like output. (In other words, display each child as a block level element.) In this case, do not generate labels.

(1) is already happening- the difference in (2) is that in situations like the one you mentioned above, labels like "title" won't appear. Most of the children of did elements are unittitle, unitdate, and unitid elements, so hopefully they will be understandable without labels.

Please let me know if you want to try it like this.

The second part of this is balancing the visual weight of things like "Scope and Content" and "Series I: Administration" in your example. This is a little trickier, so I'd like to split that out into a separate issue once we've finished this part.

[MomoMoses]

Hey, Yeah I think you're right that the info is understandable without labels, so if go with that version. And I get that it should be another issue on its own for the section display.

…

On Wed, Oct 6, 2021, 1:52 PM John Jung ***@***.***> wrote: I need to figure out which situations I should display labels in...please let me know if you'd like to try the following approach: 1. Display did elements that include containers like table-rows. In this case, elements other than containers are collected in the rightmost column where each element gets a label, like "title". 2. When did elements do NOT include containers, display each child as its own one-cell row in the table-like output. (In other words, display each child as a block level element.) In this case, do not generate labels. (1) is already happening- the difference in (2) is that in situations like the one you mentioned above, labels like "title" won't appear. Most of the children of did elements are unittitle, unitdate, and unitid elements, so hopefully they will be understandable without labels. Please let me know if you want to try it like this. The second part of this is balancing the visual weight of things like "Scope and Content" and "Series I: Administration" in your example. This is a little trickier, so I'd like to split that out into a separate issue once we've finished this part. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA263WXR56GCJXZ2JTX7E2LUFSLGJANCNFSM5FMR75EQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[johnjung]

Ok- the first part of this is now live in the portal test server. Here's the commit.

Please let me know if this looks ok. If so we can move onto the second part.

[johnjung]

Also see #46.

[johnjung]

Part 2 of this looks like it's covered in issue 46. I'm going to close this out, please feel free to reopen if necessary.

[MomoMoses]

Rereading this I see that there may have been a misunderstanding. I don't think the labels need to appear in the table-row displays at all. With our without containers.

[johnjung]

Closing this issue again because I believe we have this covered in #46.