Giter Site home page Giter Site logo

Comments (6)

johnjung avatar johnjung commented on September 11, 2024

Is it possible to re-word this as an issue that can be fixed? If not, lets close this issue out.

from bmrcportal.

johnjung avatar johnjung commented on September 11, 2024

Right now, the transform tries to turn extptr and extref elements into HTML links, and it turns linkgrp elements into HTML unordered lists. Would you prefer that, if those elements appear in the EAD, nothing appears in the HTML? Or would you prefer that if those elements appear that plain text is output to HTML instead?

from bmrcportal.

MomoMoses avatar MomoMoses commented on September 11, 2024

If you grep the database as it exists right now, do these elements appear? I don't see them in the NAFAN dataset at all. If they don't appear, it does no harm, but no good either. Since it's done, though, I would leave it as you have it--those transforms are logical.

from bmrcportal.

johnjung avatar johnjung commented on September 11, 2024

Ok, that's great. There are currently no examples of extptr or linkgrp elements, however, there are extref elements- they appear in the following finding aids:

BMRC.HARSH.ABBOTT_SENGSTACKE.xml
BMRC.HARSH.DURHAM.xml
BMRC.HARSH.WYATT.xml
BMRC.NU.TRANSP-LIB_MENUS.xml
BMRC.UOC.ACLU_IL.xml
BMRC.UOC.AFR-STUDIES_WKSHP.xml
BMRC.UOC.AFRICANSTUDIES.xml
BMRC.UOC.AFRICANWKSP.xml
BMRC.UOC.AVC_CHI.xml
BMRC.UOC.BURGESS.xml
BMRC.UOC.BURGESSADDENDA.xml
BMRC.UOC.CAHUSAC.xml
BMRC.UOC.CIVDISARMCOMM.xml
BMRC.UOC.SUNRA.xml

If you'd like to take a look to see how those elements render, please do. Otherwise we can close out this issue.

from bmrcportal.

MomoMoses avatar MomoMoses commented on September 11, 2024

I haven't found any that are rendering properly as clickable links. I had thought that was the aim...?

from bmrcportal.

johnjung avatar johnjung commented on September 11, 2024

The original issue here is now resolved, and yesterday's comment is a duplicate of #52. I'm going to close this issue out and finish resolving it over there.

from bmrcportal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.