Giter Site home page Giter Site logo

Comments (2)

johnjung avatar johnjung commented on September 11, 2024

My preference is to clean things like this up in the XML itself, if possible, since improvements there will affect any system that uses these finding aids, and not just the portal. (The finding aids will also probably outlive any system they're being displayed in, so hopefully improvements to them are a better investment than improvements to any website code.)

If we do decide to fix this in the portal code, there are at least two issues to deal with. First, some facets, like "Washington, D.C.", do contain trailing periods- so any code that tries to strip out punctuation needs a list of terms like that to avoid.

The second issue relates to the links from these terms in finding aids to new searches. Stripping out punctuation creates situations where a highlighted search term in a finding aid could contain a trailing period, but the facet itself doesn't. If we link those highlighted search terms to search results via facets, then we would need to watch for this, since it would be easy to create links for highlighted terms in finding aids that don't have any results when clicked.

Let me know what you think about this. It's possible to treat this as a code issue, but it gets a little involved. If we choose to spend development time here it will leave less time for improvements in other places.

from bmrcportal.

MomoMoses avatar MomoMoses commented on September 11, 2024

Agreed to fix in data cleanup efforts rather than in development time. :)

from bmrcportal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.