Detects indents in json-mode incorrectly

[jscheid]

Detects indents in json-mode incorrectly

[rrthomas]

The logic is working as intended. You can set dtrt-indent-max-merge-deviation to, in this case, 9.00. If you'd like to suggest an improvement to the logic, please do!

[aaronjensen]

It doesn't take into account the indentation rules of a file? It seems like things after "rules": { have 2 * indent-size.

[rrthomas]

Sorry, I don't understand what you mean by "indentation rules". Maybe read the docstring of dtrt-indent-max-merge-deviation, if you haven't already?

[aaronjensen]

I was (incorrectly, it seems) assuming that dtrt-indent took into account how files are meant to be indented rather than just counting whitespace and guessing.

In other words, it could look at a json file like:

{
  foo: {
    bar: 3
  }
}

and know, that because indentation typically happens after a line ends w/ {, that the indentation setting must be 2. I'm sure that that would be a rather tricky and probably hard thing to implement, so I totally get why it works the way it does.

I set dtrt-indent-max-merge-deviation to 9.0 and I'll see how it goes. I really only ever have problems w/ eslint/tslint json rule files because of their particular shape. Thanks much for the help.

[rrthomas]

Yes, dtrt-indent is dumb; on the other hand, it's already quite complicated, and trying to infer how files are "meant to be" indented is probably a mug's game. If you have files that have explicit information on how they're supposed to be indented, that's fine, don't use dtrt-indent on them, and enforce their indentation (as fmt or go fmt do). dtrt-indent is meant for use when this information isn't available.

Closing.