1.4.1 breaks old node

[jsx-eslint]

1.4.1 breaks old node

[ljharb]

That line points to https://npmcdn.com/[email protected]/lib/values/expressions/index.js → https://github.com/evcohen/jsx-ast-utils/blob/master/src/values/expressions/index.js#L44 - this can be fixed by @raylu by polyfilling it, but it can and should be fixed here by importing a standalone function for it.

Luckily, https://npmjs.com/object.assign works for both cases ;-)

[ljharb]

We should probably run tests on 0.10 if possible, to avoid similar regressions.

[beefancohen]

Still crazy to me that 1.4.0 works, though???

[ljharb]

Using babel often gives you es3 for free ¯_(ツ)_/¯

[ljharb]

@evcohen this may be causing a breaking change in eslint-plugin-react; see jsx-eslint/eslint-plugin-react#1158.

[beefancohen]

fack i still don't get how this broke, the code didnt change. We also use Object.assign in other places?

will ponyfill object.assign and publish v1.4.2

[raylu]

Sorry, I misdiagnosed what was in 1.4.1. It wasn't just PR 30.

It broke with 93fdce1 and #25, but based on the referenced PR you already figured it out.