Giter Site home page Giter Site logo

blizzmove's People

Contributors

fubawow avatar numynum avatar zacade avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

blizzmove's Issues

Feature request: reset position on frame close

Personally I loved the functionality of the an older version which would just reset windows on closing them rather than keeping them constant until reload/logoff.
Was using the outdated version until pre-patch because of it so I was wondering if there is any way you could implement an option to toggle that would just not save the frame location?
Sometimes I just prefer that method of handling it when dealing with a lot of things at once.

Looking at it I'd think it would just be within OnMouseUp?
if toggle then
frameData.storage.dragged = false;
else
frameData.storage.dragPoints = GetFramePoints(frame);
frameData.storage.dragged = true;
end

Remember Permanently

I have set my settings to "Remember permanently" and it seems to work on some toons and not others. Specifically the "Game Menu". On some toons it uses the saved position, on others it doesn't. On the ones it doesn't, it remembers until I log out and back in.

Option to blacklist windows

This addon can move the loot window, but I have it set to open at cursor. Often I can accidentally move the loot window and cause this addon to override my setting to have it show at cursor, meaning I have to shift+click the loot window to reset positioning.

This really becomes an issue when the loot window keeps closing before I can shift click it.

My suggestion is to have a list of currently modified windows, and an option there to reset the window and blacklist it from being modified in future.

Option dialogue to toggle the saving of the frames

There was a an options dialogue in an older version. I decided back then to not add Ace3 options just for one option. So probably would still do the same.

The old code was a button. Now a checkbox would probably be better to toggle the saving the frames.

local function createOptionPanel()
	optionPanel = CreateFrame( "Frame", "BlizzMovePanel", UIParent );
	local title = optionPanel:CreateFontString(nil, "ARTWORK", "GameFontNormalLarge")
	title:SetPoint("TOPLEFT", 16, -16)
	local version = GetAddOnMetadata("BlizzMove","Version") or ""
	title:SetText("BlizzMove "..version)

	local subtitle = optionPanel:CreateFontString(nil, "ARTWORK", "GameFontHighlightSmall")
	subtitle:SetHeight(35)
	subtitle:SetPoint("TOPLEFT", title, "BOTTOMLEFT", 0, -8)
	subtitle:SetPoint("RIGHT", optionPanel, -32, 0)
	subtitle:SetNonSpaceWrap(true)
	subtitle:SetJustifyH("LEFT")
	subtitle:SetJustifyV("TOP")

	subtitle:SetText("Click the button below to reset all frames.")

	local button = CreateFrame("Button",nil,optionPanel, "UIPanelButtonTemplate")
	button:SetWidth(100)
	button:SetHeight(30)
	button:SetScript("OnClick", resetDB)
	button:SetText("Reset")
	button:SetPoint("TOPLEFT",20,-60)
	
	optionPanel.name = "BlizzMove";
	InterfaceOptions_AddCategory(optionPanel);
end

way to disable possition saving

Lately Blizzmove started to safe it's possition so anytime i even accidentaly move a window i have to shift click to reset the position (or it resets with reload) It never did it before always when i turned off the window it used to reset. Also, as far as i know the addon should not save positions at all. Is there a way to prevent this?

TalkingHeadFrame anchor family connection bug

from discord:

Got a quick bug to send over.
It seems if you move the talking head frame it will start tossing lua errors.

Message: Action[SetPoint] failed because[SetPoint would result in anchor family connection]: attempted from: TalkingHeadFrame:SetPoint.

Torghast Powers - UI Window issues

Confirmed that BlizzMove is the issue here by removing Blizzmove and the Torghast issues below work again:

1: When you accept a power - any power you try to click on aftewards has 0 action by clicking.
2: When you accept a power - most of the powers show the power name (top of its window) but the details/graphic is blanked. https://puu.sh/HpJIo/41eba99ac4.png
3: This only took place in Skoldus Hall - Fractured Chambers was unnaffected on 2 different characters.

WHAT I TRIED:
1: /reload command - takes care of accepting powers but the power information inside of their respective windows is still blank.
2: Restarted Client/PC -
3: Disabled BlizzMove addon - this successfully made everything work fine - determined Blizzmove needs update.

Issue when attempting to cast spell from spellbook

I can't seem to reproduce the error, nor does a console error popup but whenever I try and click a spell from my spellbook a blizzard pop-up appears that says

"BlizzMove has been blocked from an action only available to the Blizzard UI. You can disable this addon and reload the UI."

I disabled other addons to ensure that it was BlizzMove causing the issue.

Like I said, it leaves no console or error files so I don't have much I could post for help

Breath Bar

please add "MirrorTimer1" Breathbar to Frames.lua

Thx and greetings

Anima power

when in torghast and having Blizzmove on it messes with the anima power blobs when you click on them. can't interact with them. Works just fine when i turn the addon off. Worked fine in torghast before the eight hour server maintenance. Well not sure what happend but when i deleted it out of my WTF folder and reenabled it that seemed to take care of the problem.

Shop Frame not movable

Hi, I just noticed that the Shop Frame is not movable and it also is not mentioned in the configuration.
I don't know if this is on purpose but I think since you can move and adjust every other frame, the shop should also be included.

best regards.

Cannot select torgast powers

When in Torgast, I have to disable BlizzMove or I cannot view Torgast power descriptions or make a selection.

Saving frame positions via ctrl+click

From garak8402 on WoWI:

Hi there, longtime Blizzmove user here:). I used to love when this addon had the ctrl+click feature to save frame positions. I eventually used MoveAnything to achieve this, but there isn't a working version for Classic that I'm yet aware of. So I got to messing around with the old files on curseforge and found that (to a large extent) version 1.4 still works!

version 1.4 on curse

Everything moves, scales and saves positions fine EXCEPT for the talent frame. There may be more but that's the only one I noticed. It does throw an error, but only initially upon logging in. As a suggestion, unless it's impossible to fix, is this something that can be reimplemented in a future update? Thanks!!

TalkingHeadUI Frame error

24x Action[SetPoint] failed because[SetPoint would result in anchor family connection]: attempted from: TalkingHeadFrame:SetPoint.
[string "=[C]"]: ?
[string "=[C]"]: in function SetPoint' [string "@FrameXML\UIParent.lua"]:2619: in function <FrameXML\UIParent.lua:2532> [string "=[C]"]: in function securecall'
[string "@FrameXML\UIParent.lua"]:3231: in function UIParentManageFramePositions' [string "@FrameXML\UIParent.lua"]:2637: in function <FrameXML\UIParent.lua:2624> [string "=[C]"]: in function SetAttribute'
[string "@FrameXML\UIParent.lua"]:3427: in function <FrameXML\UIParent.lua:3425>
[string "=[C]"]: in function UIParent_ManageFramePositions' [string "@FrameXML\MultiActionBars.lua"]:116: in function MultiActionBar_Update'
[string "@FrameXML\UIParent.lua"]:1574: in function <FrameXML\UIParent.lua:1277>

Locals:
(*temporary) = TalkingHeadFrame {
0 =
OnManagedAlertFrameVisibilityChanged = defined =[C]:-1
PortraitFrame = {
}
NameFrame = {
}
SetHeight = defined =[C]:-1
SetAlertContainer = defined =[C]:-1
BackgroundFrame = {
}
SetPoint = defined =[C]:-1
frameData =

{
}
TextFrame = {
}
MainFrame = {
}
OnPostShow = defined =[C]:-1
GetAlertContainer = defined =[C]:-1
alertContainer = AlertFrame {
}
OnPostHide = defined =[C]:-1
ManagesOwnOutroAnimation = defined =[C]:-1
SetExternallyManagedOutroAnimation = defined =[C]:-1
SetWidth = defined =[C]:-1
}
(*temporary) = "BOTTOM"
(*temporary) = "UIParent"
(*temporary) = "BOTTOM"
(*temporary) = 0
(*temporary) = 75

Temporary solution:Comment out lines 879-885 of the Frams.lua file

--[[["Blizzard_TalkingHeadUI"] =
{
["TalkingHeadFrame"] =
{
MinVersion = 40000, -- Added when?
},
},]]--

Can't type in Submit a Bug window

On WoW Live (not Beta) I am unable to type in the Submit a bug window when BlizzMove is enabled.
I installed the mod via Twitch client.

Installed version: 3.0.1
Game Version: 9.0.01

Error trying to rehook an already hooked frame

1x Ace3\AceHook-3.0\AceHook-3.0-9.lua:180: Attempting to rehook already active hook OnMouseDown.
[string "=[C]"]: ?
[string "@ace3\AceHook-3.0\AceHook-3.0-9.lua"]:180: in function <Ace3\AceHook-3.0\AceHook-3.0.lua:118>
[string "@ace3\AceHook-3.0\AceHook-3.0-9.lua"]:411: in function SecureHookScript' [string "@BlizzMove\BlizzMove-v3.0.16.lua"]:687: in function <BlizzMove\BlizzMove.lua:645> [string "=[C]"]: ? [string "@BlizzMove\BlizzMove-v3.0.16.lua"]:736: in function MakeFrameMovable'
[string "@BlizzMove\BlizzMove-v3.0.16.lua"]:753: in function ProcessFrame' [string "@BlizzMove\BlizzMove-v3.0.16.lua"]:785: in function ProcessFrames'
[string "@BlizzMove\BlizzMove-v3.0.16.lua"]:882: in function <BlizzMove\BlizzMove.lua:874>
[string "=[C]"]: ?
[string "@ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:527: in function EnableAddon' ... [string "@PetTracker\libs\WildAddon-1.0\WildAddon-1.0-1.lua"]:20: in function <...dOns\PetTracker\libs\WildAddon-1.0\WildAddon-1.0.lua:18> [string "@PetTracker\libs\WildAddon-1.0\WildAddon-1.0-1.lua"]:56: in function <...dOns\PetTracker\libs\WildAddon-1.0\WildAddon-1.0.lua:53> [string "=[C]"]: ? [string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@Ace3\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function Fire'
[string "@ace3\AceEvent-3.0\AceEvent-3.0-4.lua"]:120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>
[string "=[C]"]: in function LoadAddOn' [string "@FrameXML\UIParent.lua"]:504: in function UIParentLoadAddOn'
[string "@FrameXML\UIParent.lua"]:551: in function `CombatLog_LoadUI'
[string "@FrameXML\UIParent.lua"]:1394: in function <FrameXML\UIParent.lua:1277>

If there is at least one World Quest tracked only that section is Visible, normal quest list is gone.

From the curseforge comments:

Moving the Quest objectives still causing issue.
If there is at least one World Quest tracked only that section is Visible, normal quest list is gone.
If Untracking all World Quest only that time can see normal quests.
Only fix is to delete the Objective frame section from locale-layout file.

Only fix is to delete the Objective frame section from locale-layout file.

Error when editing roles in Guild/Community panels.

3x [ADDON_ACTION_FORBIDDEN] AddOn 'BlizzMove' tried to call the protected function 'SetGuildRankOrder()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function SetGuildRankOrder' [string "@Blizzard_Communities\GuildRoster.lua"]:174: in function func'
[string "@SharedXML\UIDropDownMenu.lua"]:905: in function `UIDropDownMenuButton_OnClick'
[string ":OnClick"]:1: in function <[string ":OnClick"]:1>

When I move the windows, I get this error

Global variable CanIMogIt tainted by BlizzMove - Interface\AddOns\CanIMogIt\core.lua:5
Execution tainted by BlizzMove while reading CanIMogIt - Interface\AddOns\CanIMogIt\code.lua:479 _GetAppearances()
Interface\AddOns\CanIMogIt\code.lua:502
Interface\FrameXML\StaticPopup.lua:4989 StaticPopup_OnClick()
An action was blocked because of taint from BlizzMove - LeaveClub()
Interface\FrameXML\StaticPopup.lua:2358 OnAccept()
Interface\FrameXML\StaticPopup.lua:5021 StaticPopup_OnClick()
StaticPopup1Button1:OnClick()

Shift right click doesn't reset Sanctum Reservoir window

The Sanctum Reservoir window (Sanctum Upgrades) is movable, but doesn't reset to default position on shift right click. Other windows do reset on shift right click. I only tested this on Kyrian covenant, since it's the only one I have at this moment.

Lua errors

Classic WOW,zhCH client,BlizzMove-v2.0.4-classic.

2x BlizzMove\BlizzMove-v2.0.4-classic.lua:81: attempt to index global 'ClubFinderGuildFinderFrame' (a nil value)
BlizzMove\BlizzMove-v2.0.4-classic.lua:81: in function `?'
BlizzMove\BlizzMove-v2.0.4-classic.lua:131: in function <BlizzMove\BlizzMove.lua:129>
[C]: in function `LoadAddOn'
FrameXML\UIParent.lua:353: in function `UIParentLoadAddOn'
FrameXML\UIParent.lua:465: in function `Communities_LoadUI'
FrameXML\ItemRef.lua:337: in function <FrameXML\ItemRef.lua:1>
[C]: ?
[C]: ?
[C]: ?
...aceBlizzard_CombatLog\Blizzard_CombatLog.lua:3527: in function `SetItemRef'
FrameXML\ChatFrame.lua:3516: in function <FrameXML\ChatFrame.lua:3515>
[C]: ?
[C]: in function `ChatFrame_OnHyperlinkShow'
[string "*:OnHyperlinkClick"]:1: in function <[string "*:OnHyperlinkClick"]:1>

Locals:
(*temporary) = <function> defined @BlizzMove\Handle.lua:79
(*temporary) = <table> {
 CreateMoveHandleAtPoint = <function> defined @BlizzMove\Handle.lua:4
 SetMoveHandle = <function> defined @BlizzMove\Handle.lua:79
 GetFrameToMove = <function> defined @BlizzMove\Handle.lua:21
}
(*temporary) = nil
(*temporary) = "attempt to index global 'ClubFinderGuildFinderFrame' (a nil value)"

pressing SHIFT+Click does not reset a moved frame.

So I just installed BlizzMove, and after moving a frame, I get the message 'frame has moved, press SHIFT+Click to reset it', but when I do a SHIFT+Click, nothing happens. I've tried clicking inside the frame, outside it, on its top bar, but nothing resets it. Is that functionality broken?

3.0.12.a not working

My client auto-updated to the new release and all of my frames moved back to default and I was unable to move anything. There were no errors, acting more like the addon wasn't loading. I reverted back to 3.0.12 and all is fine.

Classic: Frame messages on login

When logging into Classic WoW, I see the following frame messages printed to chat, every time:

BlizzMove: Could not find frame ( Build: 38386 | Version: 11307 ): FriendsListFrameScrollFrame
BlizzMove: Could not find frame ( Build: 38386 | Version: 11307 ): QuickJoinScrollFrame
BlizzMove: Could not find frame ( Build: 38386 | Version: 11307 ): IgnoreListFrameScrollFrame

I have not changed any of the default addon settings, so every frame available in the config is enabled.

Running 3.0.13 Classic version

CinematicFrame moveable why?!

hi there,
why the "CinematicFrame" is moveable?

i know i can disable it in the lua but it eludes my understanding why this is moveable at all ^^
because it just moves the Top and Bottom Border while a Cinematic is active and meanwhile SHIFT + Click does now work!

greetings

Failure messages on login

When I log in, I see 2 errors printed to chat:

BlizzMove: Failed to make frame movable: PVPMatchResults
BlizzMove: Failed to make frame movable: ChannelFrame

FrameStrata

Is it possible to manually set up the FrameStrata of the windows you move ?

We need and update

having conflicts with it so i have not been able to use please update this i really love it

Talking head seems work under various instances

Hey, first of all, i love this addon, is just brilliant.

I see talking head in default and modify location y can't move one, the default one, is posible to unifique all the position of talking to just one location.

Official Classic Release

I believe this addon works for Classic but would you consider doing an official release for it?

Move 'Open Mail' separately from 'Inbox'

Currently the frame for an open mail is locked to being at the right side of the inbox.

Being able to unlock this anchor would be nice, though I don't know if there's a technical limitation to this.

(Classic)

Feature Request

Feature Request:

Save frame position for map on logging out/in.

Thanks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.