Giter Site home page Giter Site logo

Comments (5)

zaCade avatar zaCade commented on May 26, 2024

Went ahead and tested this, with both alpha2 and alpha3 i can move the talent frame. You sure you havent accidentally disabled it in the options?

Or do you maybe have other addons that might affect that frame?

from blizzmove.

syntruth avatar syntruth commented on May 26, 2024

Same in 3.0.1. Upon logging in, I am unable to move the Talents window. It is checked in the Blizzard_TalentUI panel, and toggling it back and forth allows the Talents panel to be dragged again. No errors are thrown that I am seeing, etc.

from blizzmove.

zaCade avatar zaCade commented on May 26, 2024

@tuftelien does toggling the talentframe in the options also make it draggable for you?

Also, could both of you try if this behavior also happens if only blizzmove is loaded?
If it doesn't happen with just blizzmove loaded, it might be an other addon breaking something. So try loading your addons one by one untill it breaks, and let me know wich one it is. That way we can look into a workaround to fix this issue.

from blizzmove.

tuftelien avatar tuftelien commented on May 26, 2024

I finally got around to debug this, and found that DejaClassicStats is interfering with BlizzMove. More specifically, it hooks into the OnShow and OnHide of the talent frame:

DCS_BLIZZ_SKILL_PANELS = {
	"TradeSkill",
	"Craft",
	"Talent",
}

local DejaClassicStatsExpandEventFrame = CreateFrame("Frame", "DejaClassicStatsExpandEventFrame", UIParent)
DejaClassicStatsExpandEventFrame:RegisterEvent("ADDON_LOADED")

DejaClassicStatsExpandEventFrame:SetScript("OnEvent", function(self, event, arg1)
	if event == "ADDON_LOADED" and arg1 == "DejaClassicStats" then
		self:UnregisterEvent("ADDON_LOADED")
		for k, v in ipairs(DCS_BLIZZ_SKILL_PANELS) do
			if _G[v.."Frame"] == nil then
				if _G[v.."Frame"] == "DetailsFrame" then return
				else
					LoadAddOn("Blizzard_"..v.."UI")
					_G[v.."Frame"]:HookScript("OnShow", function(self)
						if PaperDollFrame:IsVisible() then
							local checked = gdbprivate.gdb.gdbdefaults.dejacharacterstatsExpandChecked.ExpandSetChecked
							if checked == true then
								DCS_CharacterFrame_Collapse()
							end
						end
					end)
					_G[v.."Frame"]:HookScript("OnHide", function(self)
						if TradeSkillFrame:IsVisible() or CraftFrame:IsVisible() or TalentFrame:IsVisible() then return
						else
							local checked = gdbprivate.gdb.gdbdefaults.dejacharacterstatsExpandChecked.ExpandSetChecked
							if checked == true then
								DCS_CharacterFrame_Expand()
							end
						end
					end)
				end
			end
		end
	end
end)

Toggling the setting enables the frame to be moved (though breaking DejaClassicStats' auto-hide) until a reload.

from blizzmove.

zaCade avatar zaCade commented on May 26, 2024

Seems its because some addons forceload load on demand addons, and when they got loaded between two certain moments during loading, they would go unnoticed as being loaded in our addon, added a loop that should prevent this in v3.0.8.

from blizzmove.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.